sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code
3de528753a
samba-mirror/lib/util/util_str_hex.h

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

6 lines
141 B
C
Raw Normal View History

lib: Simplify parse_guid_string() and ndr_syntax_id_from_string() Return "bool" instead of NTSTATUS, use hex_byte() instead of read_hex_bytes(). And parse directly into a struct GUID instead of the components. 99 lines less code. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Samuel Cabrero <scabrero@samba.org>
2021-01-24 11:15:29 +03:00
#include "replace.h"
shift read_hex_bytes() and parse_guid_string() into lib/util read_hex_bytes() is going to be used in lib/util/rfc1738.c. parse_guid_string() is shifted for two reasons: Firstly, it is called very often in some operations, sometimes constituting a few percent of the CPU load, and it makes several calls to read_hex_bytes(). We want the compiler to be able to inline those calls if it thinks that is wise. Secondly, there are other places that could do with fast GUID parsing. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2018-02-16 07:53:15 +03:00
lib: Simplify parse_guid_string() and ndr_syntax_id_from_string() Return "bool" instead of NTSTATUS, use hex_byte() instead of read_hex_bytes(). And parse directly into a struct GUID instead of the components. 99 lines less code. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Samuel Cabrero <scabrero@samba.org>
2021-01-24 11:15:29 +03:00
bool hex_uint32(const char *in, uint32_t *out);
struct GUID;
bool parse_guid_string(const char *s, struct GUID *guid);
Copy Permalink