1996-05-04 11:50:46 +04:00
/*
2002-01-30 09:08:46 +03:00
Unix SMB / CIFS implementation .
1996-05-04 11:50:46 +04:00
Samba utility functions
1998-01-22 16:27:43 +03:00
Copyright ( C ) Andrew Tridgell 1992 - 1998
2002-11-13 02:20:50 +03:00
Copyright ( C ) Jeremy Allison 2001 - 2002
2001-11-12 03:53:34 +03:00
Copyright ( C ) Simo Sorce 2001
2003-08-01 19:21:20 +04:00
Copyright ( C ) Jim McDonough < jmcd @ us . ibm . com > 2003
1996-05-04 11:50:46 +04:00
This program is free software ; you can redistribute it and / or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation ; either version 2 of the License , or
( at your option ) any later version .
This program is distributed in the hope that it will be useful ,
but WITHOUT ANY WARRANTY ; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE . See the
GNU General Public License for more details .
You should have received a copy of the GNU General Public License
along with this program ; if not , write to the Free Software
Foundation , Inc . , 675 Mass Ave , Cambridge , MA 0213 9 , USA .
*/
# include "includes.h"
2005-04-06 20:28:04 +04:00
extern fstring local_machine ;
extern char * global_clobber_region_function ;
extern unsigned int global_clobber_region_line ;
extern fstring remote_arch ;
2004-12-07 21:25:53 +03:00
/* Max allowable allococation - 256mb - 0x10000000 */
# define MAX_ALLOC_SIZE (1024*1024*256)
1998-07-29 07:08:05 +04:00
# if (defined(HAVE_NETGROUP) && defined (WITH_AUTOMOUNT))
1998-08-08 05:15:14 +04:00
# ifdef WITH_NISPLUS_HOME
1999-12-13 16:27:58 +03:00
# ifdef BROKEN_NISPLUS_INCLUDE_FILES
/*
* The following lines are needed due to buggy include files
* in Solaris 2.6 which define GROUP in both / usr / include / sys / acl . h and
* also in / usr / include / rpcsvc / nis . h . The definitions conflict . JRA .
* Also GROUP_OBJ is defined as 0x4 in / usr / include / sys / acl . h and as
* an enum in / usr / include / rpcsvc / nis . h .
*/
# if defined(GROUP)
# undef GROUP
1997-10-20 16:10:58 +04:00
# endif
1999-12-13 16:27:58 +03:00
# if defined(GROUP_OBJ)
# undef GROUP_OBJ
1998-04-10 00:48:48 +04:00
# endif
1997-10-20 16:10:58 +04:00
1999-12-13 16:27:58 +03:00
# endif /* BROKEN_NISPLUS_INCLUDE_FILES */
# include <rpcsvc/nis.h>
# endif /* WITH_NISPLUS_HOME */
# endif /* HAVE_NETGROUP && WITH_AUTOMOUNT */
2004-11-25 03:07:01 +03:00
enum protocol_types Protocol = PROTOCOL_COREPLUS ;
1996-05-04 11:50:46 +04:00
/* a default finfo structure to ensure all fields are sensible */
2000-04-30 08:45:16 +04:00
file_info def_finfo = { - 1 , 0 , 0 , 0 , 0 , 0 , 0 , " " , " " } ;
1996-05-04 11:50:46 +04:00
1996-08-19 15:17:29 +04:00
/* this is used by the chaining code */
int chain_size = 0 ;
1996-05-04 11:50:46 +04:00
int trans_num = 0 ;
1997-09-05 00:26:07 +04:00
static enum remote_arch_types ra_type = RA_UNKNOWN ;
1999-12-13 16:27:58 +03:00
pstring user_socket_options = DEFAULT_SOCKET_OPTIONS ;
1997-10-19 19:33:25 +04:00
2002-11-13 02:20:50 +03:00
/***********************************************************************
Definitions for all names .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
static char * smb_myname ;
static char * smb_myworkgroup ;
static char * smb_scope ;
static int smb_num_netbios_names ;
static char * * smb_my_netbios_names ;
/***********************************************************************
Allocate and set myname . Ensure upper case .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
BOOL set_global_myname ( const char * myname )
{
SAFE_FREE ( smb_myname ) ;
2004-12-07 21:25:53 +03:00
smb_myname = SMB_STRDUP ( myname ) ;
2002-11-13 02:20:50 +03:00
if ( ! smb_myname )
return False ;
2003-07-03 23:11:31 +04:00
strupper_m ( smb_myname ) ;
2002-11-13 02:20:50 +03:00
return True ;
}
const char * global_myname ( void )
{
return smb_myname ;
}
/***********************************************************************
Allocate and set myworkgroup . Ensure upper case .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
BOOL set_global_myworkgroup ( const char * myworkgroup )
{
SAFE_FREE ( smb_myworkgroup ) ;
2004-12-07 21:25:53 +03:00
smb_myworkgroup = SMB_STRDUP ( myworkgroup ) ;
2002-11-13 02:20:50 +03:00
if ( ! smb_myworkgroup )
return False ;
2003-07-03 23:11:31 +04:00
strupper_m ( smb_myworkgroup ) ;
2002-11-13 02:20:50 +03:00
return True ;
}
const char * lp_workgroup ( void )
{
return smb_myworkgroup ;
}
/***********************************************************************
Allocate and set scope . Ensure upper case .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
BOOL set_global_scope ( const char * scope )
{
SAFE_FREE ( smb_scope ) ;
2004-12-07 21:25:53 +03:00
smb_scope = SMB_STRDUP ( scope ) ;
2002-11-13 02:20:50 +03:00
if ( ! smb_scope )
return False ;
2003-07-03 23:11:31 +04:00
strupper_m ( smb_scope ) ;
2002-11-13 02:20:50 +03:00
return True ;
}
2002-12-06 22:59:04 +03:00
/*********************************************************************
Ensure scope is never null string .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2002-11-13 02:20:50 +03:00
const char * global_scope ( void )
{
2002-12-06 22:59:04 +03:00
if ( ! smb_scope )
set_global_scope ( " " ) ;
2002-11-13 02:20:50 +03:00
return smb_scope ;
}
static void free_netbios_names_array ( void )
{
int i ;
for ( i = 0 ; i < smb_num_netbios_names ; i + + )
SAFE_FREE ( smb_my_netbios_names [ i ] ) ;
SAFE_FREE ( smb_my_netbios_names ) ;
smb_num_netbios_names = 0 ;
}
static BOOL allocate_my_netbios_names_array ( size_t number )
{
free_netbios_names_array ( ) ;
smb_num_netbios_names = number + 1 ;
2004-12-07 21:25:53 +03:00
smb_my_netbios_names = SMB_MALLOC_ARRAY ( char * , smb_num_netbios_names ) ;
2002-11-13 02:20:50 +03:00
if ( ! smb_my_netbios_names )
return False ;
memset ( smb_my_netbios_names , ' \0 ' , sizeof ( char * ) * smb_num_netbios_names ) ;
return True ;
}
static BOOL set_my_netbios_names ( const char * name , int i )
{
SAFE_FREE ( smb_my_netbios_names [ i ] ) ;
2004-12-07 21:25:53 +03:00
smb_my_netbios_names [ i ] = SMB_STRDUP ( name ) ;
2002-11-13 02:20:50 +03:00
if ( ! smb_my_netbios_names [ i ] )
return False ;
2003-07-03 23:11:31 +04:00
strupper_m ( smb_my_netbios_names [ i ] ) ;
2002-11-13 02:20:50 +03:00
return True ;
}
2006-04-08 21:25:31 +04:00
/***********************************************************************
Free memory allocated to global objects
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
void gfree_names ( void )
{
SAFE_FREE ( smb_myname ) ;
SAFE_FREE ( smb_myworkgroup ) ;
SAFE_FREE ( smb_scope ) ;
free_netbios_names_array ( ) ;
}
void gfree_all ( void )
{
gfree_names ( ) ;
gfree_loadparm ( ) ;
gfree_case_tables ( ) ;
gfree_debugsyms ( ) ;
gfree_charcnv ( ) ;
gfree_messsges ( ) ;
/* release the talloc null_context memory last */
talloc_nc_free ( ) ;
}
2002-11-13 02:20:50 +03:00
const char * my_netbios_names ( int i )
{
return smb_my_netbios_names [ i ] ;
}
BOOL set_netbios_aliases ( const char * * str_array )
{
size_t namecount ;
/* Work out the max number of netbios aliases that we have */
for ( namecount = 0 ; str_array & & ( str_array [ namecount ] ! = NULL ) ; namecount + + )
;
if ( global_myname ( ) & & * global_myname ( ) )
namecount + + ;
/* Allocate space for the netbios aliases */
if ( ! allocate_my_netbios_names_array ( namecount ) )
return False ;
/* Use the global_myname string first */
namecount = 0 ;
if ( global_myname ( ) & & * global_myname ( ) ) {
set_my_netbios_names ( global_myname ( ) , namecount ) ;
namecount + + ;
}
if ( str_array ) {
size_t i ;
for ( i = 0 ; str_array [ i ] ! = NULL ; i + + ) {
size_t n ;
BOOL duplicate = False ;
/* Look for duplicates */
for ( n = 0 ; n < namecount ; n + + ) {
if ( strequal ( str_array [ i ] , my_netbios_names ( n ) ) ) {
duplicate = True ;
break ;
}
}
if ( ! duplicate ) {
if ( ! set_my_netbios_names ( str_array [ i ] , namecount ) )
return False ;
namecount + + ;
}
}
}
return True ;
}
1996-05-04 11:50:46 +04:00
1996-10-24 04:09:08 +04:00
/****************************************************************************
2002-11-13 02:20:50 +03:00
Common name initialization code .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
BOOL init_names ( void )
{
char * p ;
int n ;
if ( global_myname ( ) = = NULL | | * global_myname ( ) = = ' \0 ' ) {
2003-02-24 06:09:08 +03:00
if ( ! set_global_myname ( myhostname ( ) ) ) {
2002-11-13 02:20:50 +03:00
DEBUG ( 0 , ( " init_structs: malloc fail. \n " ) ) ;
return False ;
}
}
if ( ! set_netbios_aliases ( lp_netbios_aliases ( ) ) ) {
DEBUG ( 0 , ( " init_structs: malloc fail. \n " ) ) ;
return False ;
}
fstrcpy ( local_machine , global_myname ( ) ) ;
2003-09-05 23:59:55 +04:00
trim_char ( local_machine , ' ' , ' ' ) ;
2002-11-13 02:20:50 +03:00
p = strchr ( local_machine , ' ' ) ;
if ( p )
* p = 0 ;
2003-07-03 23:11:31 +04:00
strlower_m ( local_machine ) ;
2002-11-13 02:20:50 +03:00
DEBUG ( 5 , ( " Netbios name list:- \n " ) ) ;
for ( n = 0 ; my_netbios_names ( n ) ; n + + )
DEBUGADD ( 5 , ( " my_netbios_names[%d]= \" %s \" \n " , n , my_netbios_names ( n ) ) ) ;
return ( True ) ;
}
/**************************************************************************n
2002-07-15 14:35:28 +04:00
Find a suitable temporary directory . The result should be copied immediately
2001-11-16 00:50:29 +03:00
as it may be overwritten by a subsequent call .
2002-07-15 14:35:28 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2002-11-13 02:20:50 +03:00
const char * tmpdir ( void )
1996-10-24 04:09:08 +04:00
{
2002-11-13 02:20:50 +03:00
char * p ;
2001-11-16 00:50:29 +03:00
if ( ( p = getenv ( " TMPDIR " ) ) )
2002-11-13 02:20:50 +03:00
return p ;
return " /tmp " ;
1996-10-24 04:09:08 +04:00
}
r2868: Well, I'm not quite sure what I'm doing back in Samba 3.0, but anyway...
I've been grumbling about under-efficient calls in SAMR, and finally
got around to fixing some of them.
We now call sys_getgroups() (which in turn calls initgroups(), until
glibc 3.4 is released) to figure out a user's group membership. This
is far, far more efficient than scanning all the groups looking for a
match, and is still the 'posix way', just using an effiecient call.
The seperate issue of 'who is in this group' remains, but this one has
been biting some people.
I need to talk to VL about how best to exersise nasty corner cases,
but my initial tests hold strong. (The code is also much simpiler
than before, which has to count for something :-)
Andrew Bartlett
(This used to be commit dc19f161698dab5b71d61fa2bacc7e7b8da5fbba)
2004-10-09 05:44:05 +04:00
/****************************************************************************
Add a gid to an array of gids if it ' s not already there .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2005-03-27 20:33:04 +04:00
void add_gid_to_array_unique ( TALLOC_CTX * mem_ctx , gid_t gid ,
2005-10-18 07:24:00 +04:00
gid_t * * gids , size_t * num_gids )
r2868: Well, I'm not quite sure what I'm doing back in Samba 3.0, but anyway...
I've been grumbling about under-efficient calls in SAMR, and finally
got around to fixing some of them.
We now call sys_getgroups() (which in turn calls initgroups(), until
glibc 3.4 is released) to figure out a user's group membership. This
is far, far more efficient than scanning all the groups looking for a
match, and is still the 'posix way', just using an effiecient call.
The seperate issue of 'who is in this group' remains, but this one has
been biting some people.
I need to talk to VL about how best to exersise nasty corner cases,
but my initial tests hold strong. (The code is also much simpiler
than before, which has to count for something :-)
Andrew Bartlett
(This used to be commit dc19f161698dab5b71d61fa2bacc7e7b8da5fbba)
2004-10-09 05:44:05 +04:00
{
int i ;
2005-10-18 07:24:00 +04:00
for ( i = 0 ; i < * num_gids ; i + + ) {
r2868: Well, I'm not quite sure what I'm doing back in Samba 3.0, but anyway...
I've been grumbling about under-efficient calls in SAMR, and finally
got around to fixing some of them.
We now call sys_getgroups() (which in turn calls initgroups(), until
glibc 3.4 is released) to figure out a user's group membership. This
is far, far more efficient than scanning all the groups looking for a
match, and is still the 'posix way', just using an effiecient call.
The seperate issue of 'who is in this group' remains, but this one has
been biting some people.
I need to talk to VL about how best to exersise nasty corner cases,
but my initial tests hold strong. (The code is also much simpiler
than before, which has to count for something :-)
Andrew Bartlett
(This used to be commit dc19f161698dab5b71d61fa2bacc7e7b8da5fbba)
2004-10-09 05:44:05 +04:00
if ( ( * gids ) [ i ] = = gid )
return ;
}
2005-03-27 20:33:04 +04:00
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
if ( mem_ctx ! = NULL ) {
2005-10-18 07:24:00 +04:00
* gids = TALLOC_REALLOC_ARRAY ( mem_ctx , * gids , gid_t , * num_gids + 1 ) ;
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
} else {
2005-10-18 07:24:00 +04:00
* gids = SMB_REALLOC_ARRAY ( * gids , gid_t , * num_gids + 1 ) ;
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
}
r2868: Well, I'm not quite sure what I'm doing back in Samba 3.0, but anyway...
I've been grumbling about under-efficient calls in SAMR, and finally
got around to fixing some of them.
We now call sys_getgroups() (which in turn calls initgroups(), until
glibc 3.4 is released) to figure out a user's group membership. This
is far, far more efficient than scanning all the groups looking for a
match, and is still the 'posix way', just using an effiecient call.
The seperate issue of 'who is in this group' remains, but this one has
been biting some people.
I need to talk to VL about how best to exersise nasty corner cases,
but my initial tests hold strong. (The code is also much simpiler
than before, which has to count for something :-)
Andrew Bartlett
(This used to be commit dc19f161698dab5b71d61fa2bacc7e7b8da5fbba)
2004-10-09 05:44:05 +04:00
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
if ( * gids = = NULL ) {
r2868: Well, I'm not quite sure what I'm doing back in Samba 3.0, but anyway...
I've been grumbling about under-efficient calls in SAMR, and finally
got around to fixing some of them.
We now call sys_getgroups() (which in turn calls initgroups(), until
glibc 3.4 is released) to figure out a user's group membership. This
is far, far more efficient than scanning all the groups looking for a
match, and is still the 'posix way', just using an effiecient call.
The seperate issue of 'who is in this group' remains, but this one has
been biting some people.
I need to talk to VL about how best to exersise nasty corner cases,
but my initial tests hold strong. (The code is also much simpiler
than before, which has to count for something :-)
Andrew Bartlett
(This used to be commit dc19f161698dab5b71d61fa2bacc7e7b8da5fbba)
2004-10-09 05:44:05 +04:00
return ;
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
}
r2868: Well, I'm not quite sure what I'm doing back in Samba 3.0, but anyway...
I've been grumbling about under-efficient calls in SAMR, and finally
got around to fixing some of them.
We now call sys_getgroups() (which in turn calls initgroups(), until
glibc 3.4 is released) to figure out a user's group membership. This
is far, far more efficient than scanning all the groups looking for a
match, and is still the 'posix way', just using an effiecient call.
The seperate issue of 'who is in this group' remains, but this one has
been biting some people.
I need to talk to VL about how best to exersise nasty corner cases,
but my initial tests hold strong. (The code is also much simpiler
than before, which has to count for something :-)
Andrew Bartlett
(This used to be commit dc19f161698dab5b71d61fa2bacc7e7b8da5fbba)
2004-10-09 05:44:05 +04:00
2005-10-18 07:24:00 +04:00
( * gids ) [ * num_gids ] = gid ;
* num_gids + = 1 ;
r2868: Well, I'm not quite sure what I'm doing back in Samba 3.0, but anyway...
I've been grumbling about under-efficient calls in SAMR, and finally
got around to fixing some of them.
We now call sys_getgroups() (which in turn calls initgroups(), until
glibc 3.4 is released) to figure out a user's group membership. This
is far, far more efficient than scanning all the groups looking for a
match, and is still the 'posix way', just using an effiecient call.
The seperate issue of 'who is in this group' remains, but this one has
been biting some people.
I need to talk to VL about how best to exersise nasty corner cases,
but my initial tests hold strong. (The code is also much simpiler
than before, which has to count for something :-)
Andrew Bartlett
(This used to be commit dc19f161698dab5b71d61fa2bacc7e7b8da5fbba)
2004-10-09 05:44:05 +04:00
}
1996-05-04 11:50:46 +04:00
/****************************************************************************
2002-01-21 09:12:22 +03:00
Like atoi but gets the value up to the separator character .
1996-05-04 11:50:46 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2001-11-16 00:50:29 +03:00
2003-02-24 06:09:08 +03:00
static const char * Atoic ( const char * p , int * n , const char * c )
1996-05-04 11:50:46 +04:00
{
2003-08-15 06:28:13 +04:00
if ( ! isdigit ( ( int ) * p ) ) {
1998-11-10 21:14:16 +03:00
DEBUG ( 5 , ( " Atoic: malformed number \n " ) ) ;
return NULL ;
}
1996-05-04 11:50:46 +04:00
1999-12-13 16:27:58 +03:00
( * n ) = atoi ( p ) ;
- group database API. oops and oh dear, the threat has been carried out:
the pre-alpha "domain group" etc parameters have disappeared.
- interactive debug detection
- re-added mem_man (andrew's memory management, detects memory corruption)
- american spellings of "initialise" replaced with english spelling of
"initialise".
- started on "lookup_name()" and "lookup_sid()" functions. proper ones.
- moved lots of functions around. created some modules of commonly used
code. e.g the password file locking code, which is used in groupfile.c
and aliasfile.c and smbpass.c
- moved RID_TYPE_MASK up another bit. this is really unfortunate, but
there is no other "fast" way to identify users from groups from aliases.
i do not believe that this code saves us anything (the multipliers)
and puts us at a disadvantage (reduces the useable rid space).
the designers of NT aren't silly: if they can get away with a user-
interface-speed LsaLookupNames / LsaLookupSids, then so can we. i
spoke with isaac at the cifs conference, the only time for example that
they do a security context check is on file create. certainly not on
individual file reads / writes, which would drastically hit their
performance and ours, too.
- renamed myworkgroup to global_sam_name, amongst other things, when used
in the rpc code. there is also a global_member_name, as we are always
responsible for a SAM database, the scope of which is limited by the role
of the machine (e.g if a member of a workgroup, your SAM is for _local_
logins only, and its name is the name of your server. you even still
have a SID. see LsaQueryInfoPolicy, levels 3 and 5).
- updated functionality of groupname.c to be able to cope with names
like DOMAIN\group and SERVER\alias. used this code to be able to
do aliases as well as groups. this code may actually be better
off being used in username mapping, too.
- created a connect to serverlist function in clientgen.c and used it
in password.c
- initialisation in server.c depends on the role of the server. well,
it does now.
- rpctorture. smbtorture. EXERCISE EXTREME CAUTION.
(This used to be commit 0d21e1e6090b933f396c764af535ca3388a562db)
1998-11-17 19:19:04 +03:00
1999-12-13 16:27:58 +03:00
while ( ( * p ) & & isdigit ( ( int ) * p ) )
1998-11-10 21:14:16 +03:00
p + + ;
2002-11-13 02:20:50 +03:00
if ( strchr_m ( c , * p ) = = NULL ) {
1998-11-10 21:14:16 +03:00
DEBUG ( 5 , ( " Atoic: no separator characters (%s) not found \n " , c ) ) ;
return NULL ;
}
return p ;
1996-05-04 11:50:46 +04:00
}
1998-11-10 21:14:16 +03:00
/*************************************************************************
2001-11-16 00:50:29 +03:00
Reads a list of numbers .
1998-11-10 21:14:16 +03:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2001-11-16 00:50:29 +03:00
2003-02-24 06:09:08 +03:00
const char * get_numlist ( const char * p , uint32 * * num , int * count )
1996-05-04 11:50:46 +04:00
{
1998-11-10 21:14:16 +03:00
int val ;
if ( num = = NULL | | count = = NULL )
return NULL ;
( * count ) = 0 ;
( * num ) = NULL ;
2001-11-16 00:50:29 +03:00
while ( ( p = Atoic ( p , & val , " :, " ) ) ! = NULL & & ( * p ) ! = ' : ' ) {
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
* num = SMB_REALLOC_ARRAY ( ( * num ) , uint32 , ( * count ) + 1 ) ;
if ( ! ( * num ) ) {
1998-11-10 21:14:16 +03:00
return NULL ;
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
}
1999-12-13 16:27:58 +03:00
( * num ) [ ( * count ) ] = val ;
( * count ) + + ;
1998-11-10 21:14:16 +03:00
p + + ;
}
1996-05-04 11:50:46 +04:00
1998-11-10 21:14:16 +03:00
return p ;
}
1996-05-04 11:50:46 +04:00
/*******************************************************************
2001-11-16 00:50:29 +03:00
Check if a file exists - call vfs_file_exist for samba files .
1996-05-04 11:50:46 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2001-11-16 00:50:29 +03:00
2002-01-15 04:37:12 +03:00
BOOL file_exist ( const char * fname , SMB_STRUCT_STAT * sbuf )
1996-05-04 11:50:46 +04:00
{
2002-11-13 02:20:50 +03:00
SMB_STRUCT_STAT st ;
2001-11-16 00:50:29 +03:00
if ( ! sbuf )
sbuf = & st ;
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
if ( sys_stat ( fname , sbuf ) ! = 0 )
return ( False ) ;
1996-05-04 11:50:46 +04:00
2002-07-15 14:35:28 +04:00
return ( ( S_ISREG ( sbuf - > st_mode ) ) | | ( S_ISFIFO ( sbuf - > st_mode ) ) ) ;
1996-05-04 11:50:46 +04:00
}
/*******************************************************************
2001-11-16 00:50:29 +03:00
Check a files mod time .
1996-05-04 11:50:46 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2001-11-16 00:50:29 +03:00
2002-01-15 04:37:12 +03:00
time_t file_modtime ( const char * fname )
1996-05-04 11:50:46 +04:00
{
2002-11-13 02:20:50 +03:00
SMB_STRUCT_STAT st ;
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
if ( sys_stat ( fname , & st ) ! = 0 )
return ( 0 ) ;
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
return ( st . st_mtime ) ;
1996-05-04 11:50:46 +04:00
}
/*******************************************************************
2001-11-16 00:50:29 +03:00
Check if a directory exists .
1996-05-04 11:50:46 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2001-11-16 00:50:29 +03:00
1998-09-02 00:11:54 +04:00
BOOL directory_exist ( char * dname , SMB_STRUCT_STAT * st )
1996-05-04 11:50:46 +04:00
{
2002-11-13 02:20:50 +03:00
SMB_STRUCT_STAT st2 ;
BOOL ret ;
1997-08-21 00:32:23 +04:00
2002-11-13 02:20:50 +03:00
if ( ! st )
st = & st2 ;
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
if ( sys_stat ( dname , st ) ! = 0 )
return ( False ) ;
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
ret = S_ISDIR ( st - > st_mode ) ;
if ( ! ret )
errno = ENOTDIR ;
return ret ;
1996-05-04 11:50:46 +04:00
}
/*******************************************************************
2002-11-13 02:20:50 +03:00
Returns the size in bytes of the named file .
1996-05-04 11:50:46 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2002-11-13 02:20:50 +03:00
1999-12-13 16:27:58 +03:00
SMB_OFF_T get_file_size ( char * file_name )
1996-05-04 11:50:46 +04:00
{
2002-11-13 02:20:50 +03:00
SMB_STRUCT_STAT buf ;
buf . st_size = 0 ;
if ( sys_stat ( file_name , & buf ) ! = 0 )
return ( SMB_OFF_T ) - 1 ;
return ( buf . st_size ) ;
1996-05-04 11:50:46 +04:00
}
/*******************************************************************
2002-11-13 02:20:50 +03:00
Return a string representing an attribute for a file .
1996-05-04 11:50:46 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2002-11-13 02:20:50 +03:00
1998-11-09 23:33:37 +03:00
char * attrib_string ( uint16 mode )
1996-05-04 11:50:46 +04:00
{
2002-11-13 02:20:50 +03:00
static fstring attrstr ;
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
attrstr [ 0 ] = 0 ;
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
if ( mode & aVOLID ) fstrcat ( attrstr , " V " ) ;
if ( mode & aDIR ) fstrcat ( attrstr , " D " ) ;
if ( mode & aARCH ) fstrcat ( attrstr , " A " ) ;
if ( mode & aHIDDEN ) fstrcat ( attrstr , " H " ) ;
if ( mode & aSYSTEM ) fstrcat ( attrstr , " S " ) ;
if ( mode & aRONLY ) fstrcat ( attrstr , " R " ) ;
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
return ( attrstr ) ;
1996-05-04 11:50:46 +04:00
}
/*******************************************************************
2002-11-13 02:20:50 +03:00
Show a smb message structure .
1996-05-04 11:50:46 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2002-11-13 02:20:50 +03:00
1998-11-10 21:14:16 +03:00
void show_msg ( char * buf )
1996-05-04 11:50:46 +04:00
{
1998-11-10 21:14:16 +03:00
int i ;
int bcc = 0 ;
1998-03-03 23:19:14 +03:00
2002-11-13 02:20:50 +03:00
if ( ! DEBUGLVL ( 5 ) )
return ;
2002-09-25 19:19:00 +04:00
1998-11-10 21:14:16 +03:00
DEBUG ( 5 , ( " size=%d \n smb_com=0x%x \n smb_rcls=%d \n smb_reh=%d \n smb_err=%d \n smb_flg=%d \n smb_flg2=%d \n " ,
smb_len ( buf ) ,
( int ) CVAL ( buf , smb_com ) ,
( int ) CVAL ( buf , smb_rcls ) ,
( int ) CVAL ( buf , smb_reh ) ,
( int ) SVAL ( buf , smb_err ) ,
( int ) CVAL ( buf , smb_flg ) ,
( int ) SVAL ( buf , smb_flg2 ) ) ) ;
2002-09-25 19:19:00 +04:00
DEBUGADD ( 5 , ( " smb_tid=%d \n smb_pid=%d \n smb_uid=%d \n smb_mid=%d \n " ,
1998-11-10 21:14:16 +03:00
( int ) SVAL ( buf , smb_tid ) ,
( int ) SVAL ( buf , smb_pid ) ,
( int ) SVAL ( buf , smb_uid ) ,
2002-09-25 19:19:00 +04:00
( int ) SVAL ( buf , smb_mid ) ) ) ;
DEBUGADD ( 5 , ( " smt_wct=%d \n " , ( int ) CVAL ( buf , smb_wct ) ) ) ;
1996-05-04 11:50:46 +04:00
1998-11-10 21:14:16 +03:00
for ( i = 0 ; i < ( int ) CVAL ( buf , smb_wct ) ; i + + )
2002-09-25 19:19:00 +04:00
DEBUGADD ( 5 , ( " smb_vwv[%2d]=%5d (0x%X) \n " , i ,
1998-11-10 21:14:16 +03:00
SVAL ( buf , smb_vwv + 2 * i ) , SVAL ( buf , smb_vwv + 2 * i ) ) ) ;
2002-09-25 19:19:00 +04:00
1998-11-10 21:14:16 +03:00
bcc = ( int ) SVAL ( buf , smb_vwv + 2 * ( CVAL ( buf , smb_wct ) ) ) ;
2002-09-25 19:19:00 +04:00
DEBUGADD ( 5 , ( " smb_bcc=%d \n " , bcc ) ) ;
1998-11-10 21:14:16 +03:00
2002-11-13 02:20:50 +03:00
if ( DEBUGLEVEL < 10 )
return ;
1998-11-10 21:14:16 +03:00
2002-11-13 02:20:50 +03:00
if ( DEBUGLEVEL < 50 )
bcc = MIN ( bcc , 512 ) ;
1998-11-10 21:14:16 +03:00
2002-09-25 19:19:00 +04:00
dump_data ( 10 , smb_buf ( buf ) , bcc ) ;
1998-11-10 21:14:16 +03:00
}
1996-05-04 11:50:46 +04:00
/*******************************************************************
2002-11-13 02:20:50 +03:00
Set the length and marker of an smb packet .
1996-05-04 11:50:46 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2002-11-13 02:20:50 +03:00
1998-11-10 21:14:16 +03:00
void smb_setlen ( char * buf , int len )
1996-05-04 11:50:46 +04:00
{
2002-11-13 02:20:50 +03:00
_smb_setlen ( buf , len ) ;
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
SCVAL ( buf , 4 , 0xFF ) ;
SCVAL ( buf , 5 , ' S ' ) ;
SCVAL ( buf , 6 , ' M ' ) ;
SCVAL ( buf , 7 , ' B ' ) ;
1998-11-10 21:14:16 +03:00
}
1996-05-04 11:50:46 +04:00
/*******************************************************************
2002-11-13 02:20:50 +03:00
Setup the word count and byte count for a smb message .
1996-05-04 11:50:46 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2002-11-13 02:20:50 +03:00
1998-11-10 21:14:16 +03:00
int set_message ( char * buf , int num_words , int num_bytes , BOOL zero )
1996-05-04 11:50:46 +04:00
{
2001-02-20 15:45:50 +03:00
if ( zero )
memset ( buf + smb_size , ' \0 ' , num_words * 2 + num_bytes ) ;
2002-01-11 22:10:25 +03:00
SCVAL ( buf , smb_wct , num_words ) ;
2001-02-20 15:45:50 +03:00
SSVAL ( buf , smb_vwv + num_words * SIZEOFWORD , num_bytes ) ;
smb_setlen ( buf , smb_size + num_words * 2 + num_bytes - 4 ) ;
return ( smb_size + num_words * 2 + num_bytes ) ;
}
/*******************************************************************
2002-11-13 02:20:50 +03:00
Setup only the byte count for a smb message .
2001-02-20 15:45:50 +03:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2002-11-13 02:20:50 +03:00
2001-09-17 08:23:48 +04:00
int set_message_bcc ( char * buf , int num_bytes )
2001-02-20 15:45:50 +03:00
{
int num_words = CVAL ( buf , smb_wct ) ;
SSVAL ( buf , smb_vwv + num_words * SIZEOFWORD , num_bytes ) ;
smb_setlen ( buf , smb_size + num_words * 2 + num_bytes - 4 ) ;
2001-09-17 08:23:48 +04:00
return ( smb_size + num_words * 2 + num_bytes ) ;
1996-05-04 11:50:46 +04:00
}
2001-03-10 14:38:27 +03:00
/*******************************************************************
2002-11-13 02:20:50 +03:00
Setup only the byte count for a smb message , using the end of the
message as a marker .
2001-03-10 14:38:27 +03:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2002-11-13 02:20:50 +03:00
2001-09-17 08:23:48 +04:00
int set_message_end ( void * outbuf , void * end_ptr )
2001-03-10 14:38:27 +03:00
{
2001-09-17 08:23:48 +04:00
return set_message_bcc ( ( char * ) outbuf , PTR_DIFF ( end_ptr , smb_buf ( ( char * ) outbuf ) ) ) ;
2001-03-10 14:38:27 +03:00
}
1996-05-04 11:50:46 +04:00
/*******************************************************************
2002-11-13 02:20:50 +03:00
Reduce a file name , removing . . elements .
1996-05-04 11:50:46 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2002-11-13 02:20:50 +03:00
1996-05-04 11:50:46 +04:00
void dos_clean_name ( char * s )
{
2002-11-13 02:20:50 +03:00
char * p = NULL ;
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
DEBUG ( 3 , ( " dos_clean_name [%s] \n " , s ) ) ;
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
/* remove any double slashes */
all_string_sub ( s , " \\ \\ " , " \\ " , 0 ) ;
1996-05-04 11:50:46 +04:00
2004-03-09 03:17:14 +03:00
while ( ( p = strstr_m ( s , " \\ .. \\ " ) ) ! = NULL ) {
2002-11-13 02:20:50 +03:00
pstring s1 ;
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
* p = 0 ;
pstrcpy ( s1 , p + 3 ) ;
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
if ( ( p = strrchr_m ( s , ' \\ ' ) ) ! = NULL )
* p = 0 ;
else
* s = 0 ;
pstrcat ( s , s1 ) ;
}
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
trim_string ( s , NULL , " \\ .. " ) ;
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
all_string_sub ( s , " \\ . \\ " , " \\ " , 0 ) ;
1996-05-04 11:50:46 +04:00
}
/*******************************************************************
2002-11-13 02:20:50 +03:00
Reduce a file name , removing . . elements .
1996-05-04 11:50:46 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2002-11-13 02:20:50 +03:00
1996-05-04 11:50:46 +04:00
void unix_clean_name ( char * s )
{
2002-11-13 02:20:50 +03:00
char * p = NULL ;
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
DEBUG ( 3 , ( " unix_clean_name [%s] \n " , s ) ) ;
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
/* remove any double slashes */
all_string_sub ( s , " // " , " / " , 0 ) ;
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
/* Remove leading ./ characters */
if ( strncmp ( s , " ./ " , 2 ) = = 0 ) {
trim_string ( s , " ./ " , NULL ) ;
if ( * s = = 0 )
pstrcpy ( s , " ./ " ) ;
}
1997-02-10 23:03:56 +03:00
2004-03-09 03:17:14 +03:00
while ( ( p = strstr_m ( s , " /../ " ) ) ! = NULL ) {
2002-11-13 02:20:50 +03:00
pstring s1 ;
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
* p = 0 ;
pstrcpy ( s1 , p + 3 ) ;
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
if ( ( p = strrchr_m ( s , ' / ' ) ) ! = NULL )
* p = 0 ;
else
* s = 0 ;
pstrcat ( s , s1 ) ;
}
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
trim_string ( s , NULL , " /.. " ) ;
1996-05-04 11:50:46 +04:00
}
/*******************************************************************
2002-11-13 02:20:50 +03:00
Close the low 3 fd ' s and open dev / null in their place .
1996-05-04 11:50:46 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2002-11-13 02:20:50 +03:00
2002-08-17 21:00:51 +04:00
void close_low_fds ( BOOL stderr_too )
1996-05-04 11:50:46 +04:00
{
2002-12-12 02:54:40 +03:00
# ifndef VALGRIND
2002-11-13 02:20:50 +03:00
int fd ;
int i ;
close ( 0 ) ;
close ( 1 ) ;
if ( stderr_too )
close ( 2 ) ;
/* try and use up these file descriptors, so silly
library routines writing to stdout etc won ' t cause havoc */
for ( i = 0 ; i < 3 ; i + + ) {
if ( i = = 2 & & ! stderr_too )
continue ;
fd = sys_open ( " /dev/null " , O_RDWR , 0 ) ;
if ( fd < 0 )
fd = sys_open ( " /dev/null " , O_WRONLY , 0 ) ;
if ( fd < 0 ) {
DEBUG ( 0 , ( " Can't open /dev/null \n " ) ) ;
return ;
}
if ( fd ! = i ) {
DEBUG ( 0 , ( " Didn't get file descriptor %d \n " , i ) ) ;
return ;
}
}
2002-12-12 02:54:40 +03:00
# endif
1996-05-04 11:50:46 +04:00
}
2005-05-18 22:02:15 +04:00
/*******************************************************************
Write data into an fd at a given offset . Ignore seek errors .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
ssize_t write_data_at_offset ( int fd , const char * buffer , size_t N , SMB_OFF_T pos )
{
size_t total = 0 ;
ssize_t ret ;
if ( pos = = ( SMB_OFF_T ) - 1 ) {
return write_data ( fd , buffer , N ) ;
}
# if defined(HAVE_PWRITE) || defined(HAVE_PRWITE64)
while ( total < N ) {
ret = sys_pwrite ( fd , buffer + total , N - total , pos ) ;
if ( ret = = - 1 & & errno = = ESPIPE ) {
return write_data ( fd , buffer + total , N - total ) ;
}
if ( ret = = - 1 ) {
DEBUG ( 0 , ( " write_data_at_offset: write failure. Error = %s \n " , strerror ( errno ) ) ) ;
return - 1 ;
}
if ( ret = = 0 ) {
return total ;
}
total + = ret ;
pos + = ret ;
}
return ( ssize_t ) total ;
# else
/* Use lseek and write_data. */
if ( sys_lseek ( fd , pos , SEEK_SET ) = = - 1 ) {
if ( errno ! = ESPIPE ) {
return - 1 ;
}
}
return write_data ( fd , buffer , N ) ;
# endif
}
1996-08-22 10:32:03 +04:00
/****************************************************************************
2002-11-13 02:20:50 +03:00
Set a fd into blocking / nonblocking mode . Uses POSIX O_NONBLOCK if available ,
else
if SYSV use O_NDELAY
if BSD use FNDELAY
1996-08-22 10:32:03 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2002-11-13 02:20:50 +03:00
1998-11-10 21:14:16 +03:00
int set_blocking ( int fd , BOOL set )
1996-08-22 10:32:03 +04:00
{
2002-11-13 02:20:50 +03:00
int val ;
1996-08-22 10:32:03 +04:00
# ifdef O_NONBLOCK
# define FLAG_TO_SET O_NONBLOCK
# else
# ifdef SYSV
# define FLAG_TO_SET O_NDELAY
# else /* BSD */
# define FLAG_TO_SET FNDELAY
# endif
# endif
2002-11-13 02:20:50 +03:00
if ( ( val = sys_fcntl_long ( fd , F_GETFL , 0 ) ) = = - 1 )
return - 1 ;
if ( set ) /* Turn blocking on - ie. clear nonblock flag */
val & = ~ FLAG_TO_SET ;
else
val | = FLAG_TO_SET ;
return sys_fcntl_long ( fd , F_SETFL , val ) ;
1996-08-22 10:32:03 +04:00
# undef FLAG_TO_SET
}
1996-05-04 11:50:46 +04:00
/****************************************************************************
2001-09-04 23:10:30 +04:00
Transfer some data between two fd ' s .
1996-05-04 11:50:46 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2002-01-04 00:48:17 +03:00
# ifndef TRANSFER_BUF_SIZE
# define TRANSFER_BUF_SIZE 65536
# endif
2001-09-04 23:10:30 +04:00
ssize_t transfer_file_internal ( int infd , int outfd , size_t n , ssize_t ( * read_fn ) ( int , void * , size_t ) ,
ssize_t ( * write_fn ) ( int , const void * , size_t ) )
{
2002-01-04 00:48:17 +03:00
char * buf ;
2001-09-04 23:10:30 +04:00
size_t total = 0 ;
ssize_t read_ret ;
2002-01-03 22:57:12 +03:00
ssize_t write_ret ;
size_t num_to_read_thistime ;
size_t num_written = 0 ;
2001-09-04 23:10:30 +04:00
2004-12-07 21:25:53 +03:00
if ( ( buf = SMB_MALLOC ( TRANSFER_BUF_SIZE ) ) = = NULL )
2002-01-04 00:48:17 +03:00
return - 1 ;
2001-09-04 23:10:30 +04:00
while ( total < n ) {
2002-01-04 00:48:17 +03:00
num_to_read_thistime = MIN ( ( n - total ) , TRANSFER_BUF_SIZE ) ;
2001-09-04 23:10:30 +04:00
2002-01-03 22:57:12 +03:00
read_ret = ( * read_fn ) ( infd , buf , num_to_read_thistime ) ;
2001-09-04 23:10:30 +04:00
if ( read_ret = = - 1 ) {
DEBUG ( 0 , ( " transfer_file_internal: read failure. Error = %s \n " , strerror ( errno ) ) ) ;
2002-01-04 00:48:17 +03:00
SAFE_FREE ( buf ) ;
2001-09-04 23:10:30 +04:00
return - 1 ;
}
if ( read_ret = = 0 )
break ;
2002-01-03 22:57:12 +03:00
num_written = 0 ;
2001-09-04 23:10:30 +04:00
2002-01-03 22:57:12 +03:00
while ( num_written < read_ret ) {
2002-01-04 00:37:45 +03:00
write_ret = ( * write_fn ) ( outfd , buf + num_written , read_ret - num_written ) ;
2001-09-04 23:10:30 +04:00
if ( write_ret = = - 1 ) {
DEBUG ( 0 , ( " transfer_file_internal: write failure. Error = %s \n " , strerror ( errno ) ) ) ;
2002-01-04 00:48:17 +03:00
SAFE_FREE ( buf ) ;
2001-09-04 23:10:30 +04:00
return - 1 ;
}
if ( write_ret = = 0 )
return ( ssize_t ) total ;
2002-01-03 22:57:12 +03:00
num_written + = ( size_t ) write_ret ;
2001-09-04 23:10:30 +04:00
}
1996-05-04 11:50:46 +04:00
2001-09-04 23:10:30 +04:00
total + = ( size_t ) read_ret ;
}
1996-05-04 11:50:46 +04:00
2002-01-04 00:48:17 +03:00
SAFE_FREE ( buf ) ;
2001-09-04 23:10:30 +04:00
return ( ssize_t ) total ;
1996-05-04 11:50:46 +04:00
}
2001-09-04 23:10:30 +04:00
SMB_OFF_T transfer_file ( int infd , int outfd , SMB_OFF_T n )
{
2002-07-15 14:35:28 +04:00
return ( SMB_OFF_T ) transfer_file_internal ( infd , outfd , ( size_t ) n , sys_read , sys_write ) ;
2001-09-04 23:10:30 +04:00
}
1996-05-04 11:50:46 +04:00
/*******************************************************************
2001-11-16 00:50:29 +03:00
Sleep for a specified number of milliseconds .
1996-05-04 11:50:46 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2001-11-16 00:50:29 +03:00
2004-02-23 05:54:03 +03:00
void smb_msleep ( unsigned int t )
1996-05-04 11:50:46 +04:00
{
2005-01-07 02:45:53 +03:00
# if defined(HAVE_NANOSLEEP)
struct timespec tval ;
int ret ;
tval . tv_sec = t / 1000 ;
tval . tv_nsec = 1000000 * ( t % 1000 ) ;
do {
errno = 0 ;
ret = nanosleep ( & tval , & tval ) ;
} while ( ret < 0 & & errno = = EINTR & & ( tval . tv_sec > 0 | | tval . tv_nsec > 0 ) ) ;
# else
2002-03-27 03:39:26 +03:00
unsigned int tdiff = 0 ;
struct timeval tval , t1 , t2 ;
fd_set fds ;
1996-05-04 11:50:46 +04:00
2002-03-27 03:39:26 +03:00
GetTimeOfDay ( & t1 ) ;
2005-01-07 02:45:53 +03:00
t2 = t1 ;
1996-05-04 11:50:46 +04:00
2002-03-27 03:39:26 +03:00
while ( tdiff < t ) {
tval . tv_sec = ( t - tdiff ) / 1000 ;
tval . tv_usec = 1000 * ( ( t - tdiff ) % 1000 ) ;
/* Never wait for more than 1 sec. */
if ( tval . tv_sec > 1 ) {
tval . tv_sec = 1 ;
tval . tv_usec = 0 ;
}
1996-05-04 11:50:46 +04:00
2002-03-27 03:39:26 +03:00
FD_ZERO ( & fds ) ;
errno = 0 ;
sys_select_intr ( 0 , & fds , NULL , NULL , & tval ) ;
GetTimeOfDay ( & t2 ) ;
if ( t2 . tv_sec < t1 . tv_sec ) {
/* Someone adjusted time... */
t1 = t2 ;
}
tdiff = TvalDiff ( & t1 , & t2 ) ;
}
2005-01-07 02:45:53 +03:00
# endif
1996-05-04 11:50:46 +04:00
}
/****************************************************************************
2001-11-16 00:50:29 +03:00
Become a daemon , discarding the controlling terminal .
1996-05-04 11:50:46 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2001-11-16 00:50:29 +03:00
2006-03-21 16:16:50 +03:00
void become_daemon ( BOOL Fork , BOOL no_process_group )
1996-05-04 11:50:46 +04:00
{
2003-01-03 20:39:30 +03:00
if ( Fork ) {
if ( sys_fork ( ) ) {
_exit ( 0 ) ;
}
}
1996-05-04 11:50:46 +04:00
/* detach from the terminal */
1998-07-29 07:08:05 +04:00
# ifdef HAVE_SETSID
2006-03-21 16:16:50 +03:00
if ( ! no_process_group ) setsid ( ) ;
1998-07-29 07:08:05 +04:00
# elif defined(TIOCNOTTY)
2006-03-21 16:16:50 +03:00
if ( ! no_process_group ) {
1998-11-17 23:50:07 +03:00
int i = sys_open ( " /dev/tty " , O_RDWR , 0 ) ;
1998-07-29 07:08:05 +04:00
if ( i ! = - 1 ) {
ioctl ( i , ( int ) TIOCNOTTY , ( char * ) 0 ) ;
close ( i ) ;
}
}
# endif /* HAVE_SETSID */
/* Close fd's 0,1,2. Needed if started by rsh */
2002-08-17 21:00:51 +04:00
close_low_fds ( False ) ; /* Don't close stderr, let the debug system
attach it to the logfile */
1996-05-04 11:50:46 +04:00
}
/****************************************************************************
2002-11-13 02:20:50 +03:00
Put up a yes / no prompt .
1996-05-04 11:50:46 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2002-11-13 02:20:50 +03:00
1996-05-04 11:50:46 +04:00
BOOL yesno ( char * p )
{
2002-11-13 02:20:50 +03:00
pstring ans ;
printf ( " %s " , p ) ;
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
if ( ! fgets ( ans , sizeof ( ans ) - 1 , stdin ) )
return ( False ) ;
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
if ( * ans = = ' y ' | | * ans = = ' Y ' )
return ( True ) ;
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
return ( False ) ;
1996-05-04 11:50:46 +04:00
}
2004-12-07 21:25:53 +03:00
# if defined(PARANOID_MALLOC_CHECKER)
/****************************************************************************
Internal malloc wrapper . Externally visible .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
void * malloc_ ( size_t size )
{
# undef malloc
2004-12-10 00:42:00 +03:00
return malloc ( size ) ;
2004-12-07 21:25:53 +03:00
# define malloc(s) __ERROR_DONT_USE_MALLOC_DIRECTLY
}
/****************************************************************************
Internal calloc wrapper . Not externally visible .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
static void * calloc_ ( size_t count , size_t size )
{
# undef calloc
2004-12-10 00:42:00 +03:00
return calloc ( count , size ) ;
2004-12-07 21:25:53 +03:00
# define calloc(n,s) __ERROR_DONT_USE_CALLOC_DIRECTLY
}
/****************************************************************************
Internal realloc wrapper . Not externally visible .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
static void * realloc_ ( void * ptr , size_t size )
{
# undef realloc
2004-12-10 00:42:00 +03:00
return realloc ( ptr , size ) ;
2004-12-07 21:25:53 +03:00
# define realloc(p,s) __ERROR_DONT_USE_RELLOC_DIRECTLY
}
# endif /* PARANOID_MALLOC_CHECKER */
/****************************************************************************
Type - safe malloc .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
void * malloc_array ( size_t el_size , unsigned int count )
{
if ( count > = MAX_ALLOC_SIZE / el_size ) {
return NULL ;
}
# if defined(PARANOID_MALLOC_CHECKER)
return malloc_ ( el_size * count ) ;
# else
return malloc ( el_size * count ) ;
# endif
}
/****************************************************************************
Type - safe calloc .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
void * calloc_array ( size_t size , size_t nmemb )
{
if ( nmemb > = MAX_ALLOC_SIZE / size ) {
return NULL ;
}
# if defined(PARANOID_MALLOC_CHECKER)
return calloc_ ( nmemb , size ) ;
# else
return calloc ( nmemb , size ) ;
# endif
}
1996-05-04 11:50:46 +04:00
/****************************************************************************
2001-11-16 00:50:29 +03:00
Expand a pointer to be a particular size .
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
Note that this version of Realloc has an extra parameter that decides
whether to free the passed in storage on allocation failure or if the
new size is zero .
This is designed for use in the typical idiom of :
p = SMB_REALLOC ( p , size )
if ( ! p ) {
return error ;
}
and not to have to keep track of the old ' p ' contents to free later , nor
to worry if the size parameter was zero . In the case where NULL is returned
we guarentee that p has been freed .
If free later semantics are desired , then pass ' free_old_on_error ' as False which
guarentees that the old contents are not freed on error , even if size = = 0. To use
this idiom use :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR ( p , size ) ;
if ( ! tmp ) {
SAFE_FREE ( p ) ;
return error ;
} else {
p = tmp ;
}
Changes were instigated by Coverity error checking . JRA .
1996-05-04 11:50:46 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2001-11-16 00:50:29 +03:00
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
void * Realloc ( void * p , size_t size , BOOL free_old_on_error )
1996-05-04 11:50:46 +04:00
{
2002-11-13 02:20:50 +03:00
void * ret = NULL ;
1996-05-31 19:13:29 +04:00
2002-11-13 02:20:50 +03:00
if ( size = = 0 ) {
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
if ( free_old_on_error ) {
SAFE_FREE ( p ) ;
}
DEBUG ( 2 , ( " Realloc asked for 0 bytes \n " ) ) ;
2002-11-13 02:20:50 +03:00
return NULL ;
}
1996-05-31 19:13:29 +04:00
2004-12-07 21:25:53 +03:00
# if defined(PARANOID_MALLOC_CHECKER)
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
if ( ! p ) {
2004-12-07 21:25:53 +03:00
ret = ( void * ) malloc_ ( size ) ;
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
} else {
2004-12-07 21:25:53 +03:00
ret = ( void * ) realloc_ ( p , size ) ;
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
}
2004-12-07 21:25:53 +03:00
# else
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
if ( ! p ) {
2002-11-13 02:20:50 +03:00
ret = ( void * ) malloc ( size ) ;
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
} else {
2002-11-13 02:20:50 +03:00
ret = ( void * ) realloc ( p , size ) ;
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
}
2004-12-07 21:25:53 +03:00
# endif
1996-05-04 11:50:46 +04:00
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
if ( ! ret ) {
if ( free_old_on_error & & p ) {
SAFE_FREE ( p ) ;
}
2002-11-13 02:20:50 +03:00
DEBUG ( 0 , ( " Memory allocation error: failed to expand to %d bytes \n " , ( int ) size ) ) ;
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
}
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
return ( ret ) ;
1996-05-04 11:50:46 +04:00
}
2004-12-07 21:25:53 +03:00
/****************************************************************************
Type - safe realloc .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2006-03-07 21:52:48 +03:00
void * realloc_array ( void * p , size_t el_size , unsigned int count , BOOL free_old_on_error )
2003-05-12 05:20:17 +04:00
{
2004-12-07 21:25:53 +03:00
if ( count > = MAX_ALLOC_SIZE / el_size ) {
2006-03-07 21:52:48 +03:00
if ( free_old_on_error ) {
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
SAFE_FREE ( p ) ;
}
2003-05-12 05:20:17 +04:00
return NULL ;
2004-12-07 21:25:53 +03:00
}
2006-03-07 21:52:48 +03:00
return Realloc ( p , el_size * count , free_old_on_error ) ;
2003-05-12 05:20:17 +04:00
}
2005-04-15 17:41:49 +04:00
/****************************************************************************
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
( Hopefully ) efficient array append .
2005-04-15 17:41:49 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
2005-04-15 17:41:49 +04:00
void add_to_large_array ( TALLOC_CTX * mem_ctx , size_t element_size ,
void * element , void * * array , uint32 * num_elements ,
ssize_t * array_size )
{
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
if ( * array_size < 0 ) {
2005-04-15 17:41:49 +04:00
return ;
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
}
2005-04-15 17:41:49 +04:00
if ( * array = = NULL ) {
2005-04-23 22:07:01 +04:00
if ( * array_size = = 0 ) {
2005-04-15 17:41:49 +04:00
* array_size = 128 ;
2005-04-23 22:07:01 +04:00
}
if ( * array_size > = MAX_ALLOC_SIZE / element_size ) {
goto error ;
}
2005-04-15 17:41:49 +04:00
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
if ( mem_ctx ! = NULL ) {
2005-04-23 22:07:01 +04:00
* array = TALLOC ( mem_ctx , element_size * ( * array_size ) ) ;
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
} else {
2005-04-23 22:07:01 +04:00
* array = SMB_MALLOC ( element_size * ( * array_size ) ) ;
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
}
2005-04-15 17:41:49 +04:00
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
if ( * array = = NULL ) {
2005-04-15 17:41:49 +04:00
goto error ;
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
}
2005-04-15 17:41:49 +04:00
}
if ( * num_elements = = * array_size ) {
* array_size * = 2 ;
2005-04-23 22:07:01 +04:00
if ( * array_size > = MAX_ALLOC_SIZE / element_size ) {
goto error ;
}
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
if ( mem_ctx ! = NULL ) {
2005-04-23 22:07:01 +04:00
* array = TALLOC_REALLOC ( mem_ctx , * array ,
element_size * ( * array_size ) ) ;
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
} else {
2005-04-23 22:07:01 +04:00
* array = SMB_REALLOC ( * array ,
element_size * ( * array_size ) ) ;
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
}
2005-04-15 17:41:49 +04:00
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
if ( * array = = NULL ) {
2005-04-15 17:41:49 +04:00
goto error ;
r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2006-03-07 09:31:04 +03:00
}
2005-04-15 17:41:49 +04:00
}
memcpy ( ( char * ) ( * array ) + element_size * ( * num_elements ) ,
element , element_size ) ;
* num_elements + = 1 ;
return ;
error :
* num_elements = 0 ;
* array_size = - 1 ;
}
2000-02-07 19:22:16 +03:00
/****************************************************************************
2001-11-16 00:50:29 +03:00
Free memory , checks for NULL .
2002-11-13 02:20:50 +03:00
Use directly SAFE_FREE ( )
Exists only because we need to pass a function pointer somewhere - - SSS
2000-02-07 19:22:16 +03:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2001-11-16 00:50:29 +03:00
2000-02-07 19:22:16 +03:00
void safe_free ( void * p )
{
2001-09-17 06:19:44 +04:00
SAFE_FREE ( p ) ;
2000-02-07 19:22:16 +03:00
}
1996-05-04 11:50:46 +04:00
/****************************************************************************
2001-11-16 00:50:29 +03:00
Get my own name and IP .
1996-05-04 11:50:46 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2001-11-16 00:50:29 +03:00
1999-12-13 16:27:58 +03:00
BOOL get_myname ( char * my_name )
1996-05-04 11:50:46 +04:00
{
1999-12-13 16:27:58 +03:00
pstring hostname ;
1996-05-04 11:50:46 +04:00
1999-12-13 16:27:58 +03:00
* hostname = 0 ;
1996-05-04 11:50:46 +04:00
1999-12-13 16:27:58 +03:00
/* get my host name */
if ( gethostname ( hostname , sizeof ( hostname ) ) = = - 1 ) {
DEBUG ( 0 , ( " gethostname failed \n " ) ) ;
return False ;
}
1996-05-04 11:50:46 +04:00
1999-12-13 16:27:58 +03:00
/* Ensure null termination. */
hostname [ sizeof ( hostname ) - 1 ] = ' \0 ' ;
1996-05-04 11:50:46 +04:00
1999-12-13 16:27:58 +03:00
if ( my_name ) {
/* split off any parts after an initial . */
2001-07-04 11:36:09 +04:00
char * p = strchr_m ( hostname , ' . ' ) ;
2001-11-16 00:50:29 +03:00
if ( p )
* p = 0 ;
1999-12-13 16:27:58 +03:00
fstrcpy ( my_name , hostname ) ;
}
return ( True ) ;
1996-05-04 11:50:46 +04:00
}
2002-12-03 22:36:53 +03:00
/****************************************************************************
2004-01-30 21:38:48 +03:00
Get my own canonical name , including domain .
2002-12-03 22:36:53 +03:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2004-01-30 21:38:48 +03:00
BOOL get_mydnsfullname ( fstring my_dnsname )
2002-12-03 22:36:53 +03:00
{
2004-01-30 21:38:48 +03:00
static fstring dnshostname ;
struct hostent * hp ;
2002-12-03 22:36:53 +03:00
2004-01-30 21:38:48 +03:00
if ( ! * dnshostname ) {
/* get my host name */
if ( gethostname ( dnshostname , sizeof ( dnshostname ) ) = = - 1 ) {
* dnshostname = ' \0 ' ;
DEBUG ( 0 , ( " gethostname failed \n " ) ) ;
return False ;
}
2002-12-03 22:36:53 +03:00
2004-01-30 21:38:48 +03:00
/* Ensure null termination. */
dnshostname [ sizeof ( dnshostname ) - 1 ] = ' \0 ' ;
2002-12-03 22:36:53 +03:00
2004-01-30 21:38:48 +03:00
/* Ensure we get the cannonical name. */
if ( ! ( hp = sys_gethostbyname ( dnshostname ) ) ) {
* dnshostname = ' \0 ' ;
return False ;
}
fstrcpy ( dnshostname , hp - > h_name ) ;
}
fstrcpy ( my_dnsname , dnshostname ) ;
2002-12-03 22:36:53 +03:00
return True ;
}
/****************************************************************************
Get my own domain name .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2004-01-30 21:38:48 +03:00
BOOL get_mydnsdomname ( fstring my_domname )
2002-12-03 22:36:53 +03:00
{
2004-01-30 21:38:48 +03:00
fstring domname ;
2002-12-03 22:36:53 +03:00
char * p ;
2004-01-30 21:38:48 +03:00
* my_domname = ' \0 ' ;
if ( ! get_mydnsfullname ( domname ) ) {
2003-04-22 11:28:41 +04:00
return False ;
2004-01-30 21:38:48 +03:00
}
p = strchr_m ( domname , ' . ' ) ;
2003-04-22 11:28:41 +04:00
if ( p ) {
p + + ;
2004-01-30 21:38:48 +03:00
fstrcpy ( my_domname , p ) ;
2003-04-22 11:28:41 +04:00
}
return False ;
2002-12-03 22:36:53 +03:00
}
1996-05-04 11:50:46 +04:00
/****************************************************************************
2001-11-16 00:50:29 +03:00
Interpret a protocol description string , with a default .
1996-05-04 11:50:46 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2001-11-16 00:50:29 +03:00
2003-04-21 17:05:51 +04:00
int interpret_protocol ( const char * str , int def )
1996-05-04 11:50:46 +04:00
{
2002-11-13 02:20:50 +03:00
if ( strequal ( str , " NT1 " ) )
return ( PROTOCOL_NT1 ) ;
if ( strequal ( str , " LANMAN2 " ) )
return ( PROTOCOL_LANMAN2 ) ;
if ( strequal ( str , " LANMAN1 " ) )
return ( PROTOCOL_LANMAN1 ) ;
if ( strequal ( str , " CORE " ) )
return ( PROTOCOL_CORE ) ;
if ( strequal ( str , " COREPLUS " ) )
return ( PROTOCOL_COREPLUS ) ;
if ( strequal ( str , " CORE+ " ) )
return ( PROTOCOL_COREPLUS ) ;
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
DEBUG ( 0 , ( " Unrecognised protocol level %s \n " , str ) ) ;
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
return ( def ) ;
1996-05-04 11:50:46 +04:00
}
1999-12-13 16:27:58 +03:00
/****************************************************************************
Return true if a string could be a pure IP address .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
BOOL is_ipaddress ( const char * str )
{
2002-11-13 02:20:50 +03:00
BOOL pure_address = True ;
int i ;
1999-12-13 16:27:58 +03:00
2002-11-13 02:20:50 +03:00
for ( i = 0 ; pure_address & & str [ i ] ; i + + )
if ( ! ( isdigit ( ( int ) str [ i ] ) | | str [ i ] = = ' . ' ) )
pure_address = False ;
1999-12-13 16:27:58 +03:00
2002-11-13 02:20:50 +03:00
/* Check that a pure number is not misinterpreted as an IP */
pure_address = pure_address & & ( strchr_m ( str , ' . ' ) ! = NULL ) ;
1999-12-13 16:27:58 +03:00
2002-11-13 02:20:50 +03:00
return pure_address ;
1999-12-13 16:27:58 +03:00
}
1996-05-04 11:50:46 +04:00
/****************************************************************************
2002-11-13 02:20:50 +03:00
Interpret an internet address or name into an IP address in 4 byte form .
1996-05-04 11:50:46 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
1999-12-13 16:27:58 +03:00
2001-07-04 11:15:53 +04:00
uint32 interpret_addr ( const char * str )
1996-05-04 11:50:46 +04:00
{
2002-11-13 02:20:50 +03:00
struct hostent * hp ;
uint32 res ;
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
if ( strcmp ( str , " 0.0.0.0 " ) = = 0 )
return ( 0 ) ;
if ( strcmp ( str , " 255.255.255.255 " ) = = 0 )
return ( 0xFFFFFFFF ) ;
1996-05-04 11:50:46 +04:00
/* if it's in the form of an IP address then get the lib to interpret it */
2002-11-13 02:20:50 +03:00
if ( is_ipaddress ( str ) ) {
res = inet_addr ( str ) ;
} else {
/* otherwise assume it's a network name of some sort and use
sys_gethostbyname */
if ( ( hp = sys_gethostbyname ( str ) ) = = 0 ) {
DEBUG ( 3 , ( " sys_gethostbyname: Unknown host. %s \n " , str ) ) ;
return 0 ;
}
if ( hp - > h_addr = = NULL ) {
DEBUG ( 3 , ( " sys_gethostbyname: host address is invalid for host %s \n " , str ) ) ;
return 0 ;
}
putip ( ( char * ) & res , ( char * ) hp - > h_addr ) ;
}
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
if ( res = = ( uint32 ) - 1 )
return ( 0 ) ;
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
return ( res ) ;
1996-05-04 11:50:46 +04:00
}
/*******************************************************************
2002-11-13 02:20:50 +03:00
A convenient addition to interpret_addr ( ) .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2001-07-04 11:15:53 +04:00
struct in_addr * interpret_addr2 ( const char * str )
1996-05-04 11:50:46 +04:00
{
2002-11-13 02:20:50 +03:00
static struct in_addr ret ;
uint32 a = interpret_addr ( str ) ;
ret . s_addr = a ;
return ( & ret ) ;
1996-05-04 11:50:46 +04:00
}
/*******************************************************************
2002-11-13 02:20:50 +03:00
Check if an IP is the 0.0 .0 .0 .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2001-11-26 06:11:44 +03:00
BOOL is_zero_ip ( struct in_addr ip )
1996-05-04 11:50:46 +04:00
{
2002-11-13 02:20:50 +03:00
uint32 a ;
putip ( ( char * ) & a , ( char * ) & ip ) ;
return ( a = = 0 ) ;
1996-05-04 11:50:46 +04:00
}
2002-07-15 14:35:28 +04:00
/*******************************************************************
2002-11-13 02:20:50 +03:00
Set an IP to 0.0 .0 .0 .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2001-11-26 06:11:44 +03:00
void zero_ip ( struct in_addr * ip )
{
static BOOL init ;
static struct in_addr ipzero ;
if ( ! init ) {
ipzero = * interpret_addr2 ( " 0.0.0.0 " ) ;
init = True ;
}
* ip = ipzero ;
}
1996-10-05 14:41:13 +04:00
1998-07-29 07:08:05 +04:00
# if (defined(HAVE_NETGROUP) && defined(WITH_AUTOMOUNT))
1998-07-16 04:06:29 +04:00
/******************************************************************
Remove any mount options such as - rsize = 2048 , wsize = 2048 etc .
Based on a fix from < Thomas . Hepper @ icem . de > .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
static void strip_mount_options ( pstring * str )
{
2002-11-13 02:20:50 +03:00
if ( * * str = = ' - ' ) {
char * p = * str ;
while ( * p & & ! isspace ( * p ) )
p + + ;
while ( * p & & isspace ( * p ) )
p + + ;
if ( * p ) {
pstring tmp_str ;
pstrcpy ( tmp_str , p ) ;
pstrcpy ( * str , tmp_str ) ;
}
}
1998-07-16 04:06:29 +04:00
}
1998-02-20 22:48:01 +03:00
/*******************************************************************
Patch from jkf @ soton . ac . uk
Split Luke ' s automount_server into YP lookup and string splitter
so can easily implement automount_path ( ) .
As we may end up doing both , cache the last YP result .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
1998-08-08 05:15:14 +04:00
# ifdef WITH_NISPLUS_HOME
2005-10-18 22:17:45 +04:00
char * automount_lookup ( const char * user_name )
1998-04-10 00:48:48 +04:00
{
2002-11-13 02:20:50 +03:00
static fstring last_key = " " ;
static pstring last_value = " " ;
1998-04-10 00:48:48 +04:00
2002-11-13 02:20:50 +03:00
char * nis_map = ( char * ) lp_nis_home_map_name ( ) ;
1998-04-10 00:48:48 +04:00
2002-11-13 02:20:50 +03:00
char buffer [ NIS_MAXATTRVAL + 1 ] ;
nis_result * result ;
nis_object * object ;
entry_obj * entry ;
1998-04-10 00:48:48 +04:00
2002-11-13 02:20:50 +03:00
if ( strcmp ( user_name , last_key ) ) {
slprintf ( buffer , sizeof ( buffer ) - 1 , " [key=%s],%s " , user_name , nis_map ) ;
DEBUG ( 5 , ( " NIS+ querystring: %s \n " , buffer ) ) ;
1998-04-10 00:48:48 +04:00
2002-11-13 02:20:50 +03:00
if ( result = nis_list ( buffer , FOLLOW_PATH | EXPAND_NAME | HARD_LOOKUP , NULL , NULL ) ) {
if ( result - > status ! = NIS_SUCCESS ) {
DEBUG ( 3 , ( " NIS+ query failed: %s \n " , nis_sperrno ( result - > status ) ) ) ;
fstrcpy ( last_key , " " ) ; pstrcpy ( last_value , " " ) ;
} else {
object = result - > objects . objects_val ;
if ( object - > zo_data . zo_type = = ENTRY_OBJ ) {
entry = & object - > zo_data . objdata_u . en_data ;
DEBUG ( 5 , ( " NIS+ entry type: %s \n " , entry - > en_type ) ) ;
DEBUG ( 3 , ( " NIS+ result: %s \n " , entry - > en_cols . en_cols_val [ 1 ] . ec_value . ec_value_val ) ) ;
1998-04-10 00:48:48 +04:00
2002-11-13 02:20:50 +03:00
pstrcpy ( last_value , entry - > en_cols . en_cols_val [ 1 ] . ec_value . ec_value_val ) ;
pstring_sub ( last_value , " & " , user_name ) ;
fstrcpy ( last_key , user_name ) ;
}
}
}
nis_freeresult ( result ) ;
}
1998-07-16 04:06:29 +04:00
2002-11-13 02:20:50 +03:00
strip_mount_options ( & last_value ) ;
1998-07-16 04:06:29 +04:00
2002-11-13 02:20:50 +03:00
DEBUG ( 4 , ( " NIS+ Lookup: %s resulted in %s \n " , user_name , last_value ) ) ;
return last_value ;
1998-04-10 00:48:48 +04:00
}
1998-08-08 05:15:14 +04:00
# else /* WITH_NISPLUS_HOME */
2002-11-13 02:20:50 +03:00
2005-10-18 22:17:45 +04:00
char * automount_lookup ( const char * user_name )
1998-02-20 22:48:01 +03:00
{
2002-11-13 02:20:50 +03:00
static fstring last_key = " " ;
static pstring last_value = " " ;
1998-02-20 22:48:01 +03:00
2002-11-13 02:20:50 +03:00
int nis_error ; /* returned by yp all functions */
char * nis_result ; /* yp_match inits this */
int nis_result_len ; /* and set this */
char * nis_domain ; /* yp_get_default_domain inits this */
char * nis_map = ( char * ) lp_nis_home_map_name ( ) ;
if ( ( nis_error = yp_get_default_domain ( & nis_domain ) ) ! = 0 ) {
DEBUG ( 3 , ( " YP Error: %s \n " , yperr_string ( nis_error ) ) ) ;
return last_value ;
}
DEBUG ( 5 , ( " NIS Domain: %s \n " , nis_domain ) ) ;
if ( ! strcmp ( user_name , last_key ) ) {
nis_result = last_value ;
nis_result_len = strlen ( last_value ) ;
nis_error = 0 ;
} else {
if ( ( nis_error = yp_match ( nis_domain , nis_map , user_name , strlen ( user_name ) ,
& nis_result , & nis_result_len ) ) = = 0 ) {
fstrcpy ( last_key , user_name ) ;
2005-11-02 02:29:02 +03:00
pstrcpy ( last_value , nis_result ) ;
2002-11-13 02:20:50 +03:00
strip_mount_options ( & last_value ) ;
} else if ( nis_error = = YPERR_KEY ) {
/* If Key lookup fails user home server is not in nis_map
use default information for server , and home directory */
last_value [ 0 ] = 0 ;
DEBUG ( 3 , ( " YP Key not found: while looking up \" %s \" in map \" %s \" \n " ,
user_name , nis_map ) ) ;
DEBUG ( 3 , ( " using defaults for server and home directory \n " ) ) ;
} else {
DEBUG ( 3 , ( " YP Error: \" %s \" while looking up \" %s \" in map \" %s \" \n " ,
yperr_string ( nis_error ) , user_name , nis_map ) ) ;
}
}
1998-07-16 04:06:29 +04:00
2002-11-13 02:20:50 +03:00
DEBUG ( 4 , ( " YP Lookup: %s resulted in %s \n " , user_name , last_value ) ) ;
return last_value ;
1998-02-20 22:48:01 +03:00
}
1998-08-08 05:15:14 +04:00
# endif /* WITH_NISPLUS_HOME */
1998-02-20 22:48:01 +03:00
# endif
1996-06-04 10:42:03 +04:00
/*******************************************************************
2002-11-13 02:20:50 +03:00
Are two IPs on the same subnet ?
1996-06-04 10:42:03 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2002-11-13 02:20:50 +03:00
1996-06-04 10:42:03 +04:00
BOOL same_net ( struct in_addr ip1 , struct in_addr ip2 , struct in_addr mask )
{
2002-11-13 02:20:50 +03:00
uint32 net1 , net2 , nmask ;
1996-06-04 10:42:03 +04:00
2002-11-13 02:20:50 +03:00
nmask = ntohl ( mask . s_addr ) ;
net1 = ntohl ( ip1 . s_addr ) ;
net2 = ntohl ( ip2 . s_addr ) ;
1996-06-04 10:42:03 +04:00
2002-11-13 02:20:50 +03:00
return ( ( net1 & nmask ) = = ( net2 & nmask ) ) ;
1996-06-04 10:42:03 +04:00
}
1996-05-04 11:50:46 +04:00
/****************************************************************************
2002-11-13 02:20:50 +03:00
Check if a process exists . Does this work on all unixes ?
1996-05-04 11:50:46 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
1998-09-30 00:24:17 +04:00
2005-09-30 21:13:37 +04:00
BOOL process_exists ( const struct process_id pid )
1996-05-04 11:50:46 +04:00
{
2005-09-30 21:13:37 +04:00
if ( ! procid_is_local ( & pid ) ) {
/* This *SEVERELY* needs fixing. */
return True ;
}
2002-03-20 09:57:03 +03:00
/* Doing kill with a non-positive pid causes messages to be
* sent to places we don ' t want . */
2005-09-30 21:13:37 +04:00
SMB_ASSERT ( pid . pid > 0 ) ;
return ( kill ( pid . pid , 0 ) = = 0 | | errno ! = ESRCH ) ;
}
BOOL process_exists_by_pid ( pid_t pid )
{
return process_exists ( pid_to_procid ( pid ) ) ;
1996-05-04 11:50:46 +04:00
}
1999-12-13 16:27:58 +03:00
/*******************************************************************
2000-10-13 05:59:14 +04:00
Convert a uid into a user name .
1999-12-13 16:27:58 +03:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2000-10-13 05:59:14 +04:00
2002-07-15 14:35:28 +04:00
const char * uidtoname ( uid_t uid )
1998-12-03 20:41:14 +03:00
{
2000-10-13 05:59:14 +04:00
static fstring name ;
struct passwd * pass ;
2006-02-04 01:19:41 +03:00
pass = getpwuid_alloc ( NULL , uid ) ;
2002-07-15 14:35:28 +04:00
if ( pass ) {
fstrcpy ( name , pass - > pw_name ) ;
2006-02-20 20:59:58 +03:00
TALLOC_FREE ( pass ) ;
2002-07-15 14:35:28 +04:00
} else {
slprintf ( name , sizeof ( name ) - 1 , " %ld " , ( long int ) uid ) ;
}
return name ;
1999-12-13 16:27:58 +03:00
}
1998-12-03 20:41:14 +03:00
1999-02-03 03:49:24 +03:00
1996-05-04 11:50:46 +04:00
/*******************************************************************
2000-10-13 05:59:14 +04:00
Convert a gid into a group name .
1996-05-04 11:50:46 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
1998-09-30 00:24:17 +04:00
char * gidtoname ( gid_t gid )
1996-05-04 11:50:46 +04:00
{
2000-10-13 05:59:14 +04:00
static fstring name ;
struct group * grp ;
grp = getgrgid ( gid ) ;
2002-07-15 14:35:28 +04:00
if ( grp )
return ( grp - > gr_name ) ;
1998-09-30 00:24:17 +04:00
slprintf ( name , sizeof ( name ) - 1 , " %d " , ( int ) gid ) ;
1998-07-29 07:08:05 +04:00
return ( name ) ;
1996-05-04 11:50:46 +04:00
}
1998-11-29 23:03:33 +03:00
/*******************************************************************
2002-07-15 14:35:28 +04:00
Convert a user name into a uid .
1998-11-29 23:03:33 +03:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2000-10-13 05:59:14 +04:00
2003-07-10 18:12:37 +04:00
uid_t nametouid ( const char * name )
1998-11-29 23:03:33 +03:00
{
1999-12-13 16:27:58 +03:00
struct passwd * pass ;
char * p ;
uid_t u ;
2006-02-04 01:19:41 +03:00
pass = getpwnam_alloc ( NULL , name ) ;
2002-01-23 15:59:24 +03:00
if ( pass ) {
2002-07-15 14:35:28 +04:00
u = pass - > pw_uid ;
2006-02-20 20:59:58 +03:00
TALLOC_FREE ( pass ) ;
2002-07-15 14:35:28 +04:00
return u ;
2002-01-23 15:59:24 +03:00
}
2002-07-15 14:35:28 +04:00
u = ( uid_t ) strtol ( name , & p , 0 ) ;
if ( ( p ! = name ) & & ( * p = = ' \0 ' ) )
return u ;
1999-12-13 16:27:58 +03:00
return ( uid_t ) - 1 ;
1998-11-29 23:03:33 +03:00
}
1998-10-04 13:42:51 +04:00
/*******************************************************************
2002-07-15 14:35:28 +04:00
Convert a name to a gid_t if possible . Return - 1 if not a group .
1998-10-04 13:42:51 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2000-10-13 05:59:14 +04:00
This commit is number 4 of 4.
In particular this commit focuses on:
Actually adding the 'const' to the passdb interface, and the flow-on changes.
Also kill off the 'disp_info' stuff, as its no longer used.
While these changes have been mildly tested, and are pretty small, any
assistance in this is appreciated.
----
These changes introduces a large dose of 'const' to the Samba tree.
There are a number of good reasons to do this:
- I want to allow the SAM_ACCOUNT structure to move from wasteful
pstrings and fstrings to allocated strings. We can't do that if
people are modifying these outputs, as they may well make
assumptions about getting pstrings and fstrings
- I want --with-pam_smbpass to compile with a slightly sane
volume of warnings, currently its pretty bad, even in 2.2
where is compiles at all.
- Tridge assures me that he no longer opposes 'const religion'
based on the ability to #define const the problem away.
- Changed Get_Pwnam(x,y) into two variants (so that the const
parameter can work correctly): - Get_Pwnam(const x) and
Get_Pwnam_Modify(x).
- Reworked smbd/chgpasswd.c to work with these mods, passing
around a 'struct passwd' rather than the modified username
---
This finishes this line of commits off, your tree should now compile again :-)
Andrew Bartlett
(This used to be commit c95f5aeb9327347674589ae313b75bee3bf8e317)
2001-10-29 10:35:11 +03:00
gid_t nametogid ( const char * name )
1998-10-04 13:42:51 +04:00
{
1999-12-13 16:27:58 +03:00
struct group * grp ;
char * p ;
gid_t g ;
2000-10-13 05:59:14 +04:00
g = ( gid_t ) strtol ( name , & p , 0 ) ;
2001-06-26 01:29:33 +04:00
if ( ( p ! = name ) & & ( * p = = ' \0 ' ) )
return g ;
1999-12-13 16:27:58 +03:00
2002-07-15 14:35:28 +04:00
grp = sys_getgrnam ( name ) ;
2001-06-26 01:29:33 +04:00
if ( grp )
return ( grp - > gr_gid ) ;
1999-12-13 16:27:58 +03:00
return ( gid_t ) - 1 ;
1998-10-04 13:42:51 +04:00
}
1996-05-04 11:50:46 +04:00
/*******************************************************************
2002-11-13 02:20:50 +03:00
Something really nasty happened - panic !
1996-05-04 11:50:46 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2002-11-13 02:20:50 +03:00
2006-04-04 04:27:50 +04:00
void smb_panic ( const char * const why )
1996-05-04 11:50:46 +04:00
{
2003-03-18 04:48:11 +03:00
char * cmd ;
2002-09-25 19:19:00 +04:00
int result ;
2003-03-18 04:48:11 +03:00
# ifdef DEVELOPER
{
2003-04-21 17:05:51 +04:00
2003-03-18 04:48:11 +03:00
if ( global_clobber_region_function ) {
DEBUG ( 0 , ( " smb_panic: clobber_region() last called from [%s(%u)] \n " ,
2003-04-21 17:05:51 +04:00
global_clobber_region_function ,
global_clobber_region_line ) ) ;
2003-03-18 04:48:11 +03:00
}
}
# endif
2003-04-21 17:05:51 +04:00
2006-04-04 04:27:50 +04:00
DEBUG ( 0 , ( " PANIC (pid %llu): %s \n " ,
( unsigned long long ) sys_getpid ( ) , why ) ) ;
log_stack_trace ( ) ;
2004-02-12 08:24:02 +03:00
/* only smbd needs to decrement the smbd counter in connections.tdb */
2006-04-04 04:27:50 +04:00
decrement_smbd_process_count ( ) ;
2004-02-12 08:24:02 +03:00
2003-03-18 04:48:11 +03:00
cmd = lp_panic_action ( ) ;
1998-08-21 15:37:40 +04:00
if ( cmd & & * cmd ) {
2002-09-25 19:19:00 +04:00
DEBUG ( 0 , ( " smb_panic(): calling panic action [%s] \n " , cmd ) ) ;
result = system ( cmd ) ;
if ( result = = - 1 )
DEBUG ( 0 , ( " smb_panic(): fork failed in panic action: %s \n " ,
2003-04-21 17:05:51 +04:00
strerror ( errno ) ) ) ;
2002-09-25 19:19:00 +04:00
else
DEBUG ( 0 , ( " smb_panic(): action returned status %d \n " ,
2003-04-21 17:05:51 +04:00
WEXITSTATUS ( result ) ) ) ;
1998-08-21 15:37:40 +04:00
}
2003-04-15 01:49:49 +04:00
2006-04-04 04:27:50 +04:00
dump_core ( ) ;
}
/*******************************************************************
Print a backtrace of the stack to the debug log . This function
DELIBERATELY LEAKS MEMORY . The expectation is that you should
exit shortly after calling it .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
# ifdef HAVE_LIBEXC_H
# include <libexc.h>
# endif
void log_stack_trace ( void )
{
2003-04-15 01:49:49 +04:00
# ifdef HAVE_BACKTRACE_SYMBOLS
2006-04-04 04:27:50 +04:00
void * backtrace_stack [ BACKTRACE_STACK_SIZE ] ;
size_t backtrace_size ;
char * * backtrace_strings ;
2003-04-15 01:49:49 +04:00
/* get the backtrace (stack frames) */
backtrace_size = backtrace ( backtrace_stack , BACKTRACE_STACK_SIZE ) ;
backtrace_strings = backtrace_symbols ( backtrace_stack , backtrace_size ) ;
2003-11-03 17:34:25 +03:00
DEBUG ( 0 , ( " BACKTRACE: %lu stack frames: \n " ,
( unsigned long ) backtrace_size ) ) ;
2003-04-15 01:49:49 +04:00
if ( backtrace_strings ) {
2003-05-27 11:26:04 +04:00
int i ;
2003-04-15 01:49:49 +04:00
for ( i = 0 ; i < backtrace_size ; i + + )
DEBUGADD ( 0 , ( " #%u %s \n " , i , backtrace_strings [ i ] ) ) ;
2004-03-21 11:43:41 +03:00
/* Leak the backtrace_strings, rather than risk what free() might do */
2003-04-15 01:49:49 +04:00
}
2004-02-11 22:07:02 +03:00
# elif HAVE_LIBEXC
/* The IRIX libexc library provides an API for unwinding the stack. See
* libexc ( 3 ) for details . Apparantly trace_back_stack leaks memory , but
* since we are about to abort anyway , it hardly matters .
*/
{
2006-04-04 04:27:50 +04:00
# define NAMESIZE 32 /* Arbitrary */
2004-02-11 22:07:02 +03:00
__uint64_t addrs [ BACKTRACE_STACK_SIZE ] ;
char * names [ BACKTRACE_STACK_SIZE ] ;
char namebuf [ BACKTRACE_STACK_SIZE * NAMESIZE ] ;
int i ;
int levels ;
ZERO_ARRAY ( addrs ) ;
ZERO_ARRAY ( names ) ;
ZERO_ARRAY ( namebuf ) ;
2005-01-29 00:55:45 +03:00
/* We need to be root so we can open our /proc entry to walk
* our stack . It also helps when we want to dump core .
*/
become_root ( ) ;
2004-02-11 22:07:02 +03:00
for ( i = 0 ; i < BACKTRACE_STACK_SIZE ; i + + ) {
names [ i ] = namebuf + ( i * NAMESIZE ) ;
}
levels = trace_back_stack ( 0 , addrs , names ,
2005-04-27 00:07:28 +04:00
BACKTRACE_STACK_SIZE , NAMESIZE - 1 ) ;
2004-02-11 22:07:02 +03:00
DEBUG ( 0 , ( " BACKTRACE: %d stack frames: \n " , levels ) ) ;
for ( i = 0 ; i < levels ; i + + ) {
DEBUGADD ( 0 , ( " #%d 0x%llx %s \n " , i , addrs [ i ] , names [ i ] ) ) ;
}
}
# undef NAMESIZE
2006-04-04 04:27:50 +04:00
# else
DEBUG ( 0 , ( " unable to produce a stack trace on this platform \n " ) ) ;
2003-04-15 01:49:49 +04:00
# endif
2006-03-28 19:50:13 +04:00
}
1996-05-04 11:50:46 +04:00
/*******************************************************************
2003-04-21 17:05:51 +04:00
A readdir wrapper which just returns the file name .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2002-11-13 02:20:50 +03:00
2005-08-23 23:05:39 +04:00
const char * readdirname ( SMB_STRUCT_DIR * p )
1996-05-04 11:50:46 +04:00
{
1999-12-13 16:27:58 +03:00
SMB_STRUCT_DIRENT * ptr ;
1998-07-29 07:08:05 +04:00
char * dname ;
1996-05-04 11:50:46 +04:00
2002-11-13 02:20:50 +03:00
if ( ! p )
return ( NULL ) ;
1996-05-04 11:50:46 +04:00
1999-12-13 16:27:58 +03:00
ptr = ( SMB_STRUCT_DIRENT * ) sys_readdir ( p ) ;
2002-11-13 02:20:50 +03:00
if ( ! ptr )
return ( NULL ) ;
1996-05-04 11:50:46 +04:00
1998-07-29 07:08:05 +04:00
dname = ptr - > d_name ;
1996-05-04 11:50:46 +04:00
# ifdef NEXT2
2002-11-13 02:20:50 +03:00
if ( telldir ( p ) < 0 )
return ( NULL ) ;
1996-05-04 11:50:46 +04:00
# endif
2006-03-27 23:50:45 +04:00
# ifdef HAVE_BROKEN_READDIR_NAME
1998-07-29 07:08:05 +04:00
/* using /usr/ucb/cc is BAD */
dname = dname - 2 ;
1996-05-04 11:50:46 +04:00
# endif
1998-07-29 07:08:05 +04:00
{
static pstring buf ;
2001-05-07 09:19:52 +04:00
int len = NAMLEN ( ptr ) ;
memcpy ( buf , dname , len ) ;
buf [ len ] = 0 ;
1998-07-29 07:08:05 +04:00
dname = buf ;
}
1997-07-04 00:45:06 +04:00
1998-07-29 07:08:05 +04:00
return ( dname ) ;
1996-05-04 11:50:46 +04:00
}
1997-09-30 06:38:19 +04:00
/*******************************************************************
Utility function used to decide if the last component
of a path matches a ( possibly wildcarded ) entry in a namelist .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
1996-05-04 11:50:46 +04:00
2004-05-07 22:37:47 +04:00
BOOL is_in_path ( const char * name , name_compare_entry * namelist , BOOL case_sensitive )
1996-12-10 21:03:44 +03:00
{
2002-11-13 02:20:50 +03:00
pstring last_component ;
char * p ;
/* if we have no list it's obviously not in the path */
if ( ( namelist = = NULL ) | | ( ( namelist ! = NULL ) & & ( namelist [ 0 ] . name = = NULL ) ) ) {
return False ;
}
2004-08-18 21:55:50 +04:00
DEBUG ( 8 , ( " is_in_path: %s \n " , name ) ) ;
2002-11-13 02:20:50 +03:00
/* Get the last component of the unix name. */
p = strrchr_m ( name , ' / ' ) ;
2005-11-02 02:29:02 +03:00
pstrcpy ( last_component , p ? + + p : name ) ;
2002-11-13 02:20:50 +03:00
for ( ; namelist - > name ! = NULL ; namelist + + ) {
if ( namelist - > is_wild ) {
if ( mask_match ( last_component , namelist - > name , case_sensitive ) ) {
DEBUG ( 8 , ( " is_in_path: mask match succeeded \n " ) ) ;
return True ;
}
} else {
if ( ( case_sensitive & & ( strcmp ( last_component , namelist - > name ) = = 0 ) ) | |
( ! case_sensitive & & ( StrCaseCmp ( last_component , namelist - > name ) = = 0 ) ) ) {
DEBUG ( 8 , ( " is_in_path: match succeeded \n " ) ) ;
return True ;
}
}
}
DEBUG ( 8 , ( " is_in_path: match not found \n " ) ) ;
1997-08-26 02:18:31 +04:00
2002-11-13 02:20:50 +03:00
return False ;
1997-07-24 21:25:11 +04:00
}
1997-07-06 17:48:10 +04:00
1997-09-30 06:38:19 +04:00
/*******************************************************************
Strip a ' / ' separated list into an array of
name_compare_enties structures suitable for
passing to is_in_path ( ) . We do this for
speed so we can pre - parse all the names in the list
and don ' t do it for each call to is_in_path ( ) .
namelist is modified here and is assumed to be
a copy owned by the caller .
We also check if the entry contains a wildcard to
remove a potentially expensive call to mask_match
if possible .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
1997-07-24 21:25:11 +04:00
void set_namearray ( name_compare_entry * * ppname_array , char * namelist )
{
2002-11-13 02:20:50 +03:00
char * name_end ;
char * nameptr = namelist ;
int num_entries = 0 ;
int i ;
1997-07-24 21:25:11 +04:00
2002-11-13 02:20:50 +03:00
( * ppname_array ) = NULL ;
1997-07-24 21:25:11 +04:00
2002-11-13 02:20:50 +03:00
if ( ( nameptr = = NULL ) | | ( ( nameptr ! = NULL ) & & ( * nameptr = = ' \0 ' ) ) )
return ;
1997-07-24 21:25:11 +04:00
2002-11-13 02:20:50 +03:00
/* We need to make two passes over the string. The
first to count the number of elements , the second
to split it .
*/
1997-07-24 21:25:11 +04:00
2002-11-13 02:20:50 +03:00
while ( * nameptr ) {
if ( * nameptr = = ' / ' ) {
/* cope with multiple (useless) /s) */
nameptr + + ;
continue ;
}
/* find the next / */
name_end = strchr_m ( nameptr , ' / ' ) ;
1997-07-24 21:25:11 +04:00
2002-11-13 02:20:50 +03:00
/* oops - the last check for a / didn't find one. */
if ( name_end = = NULL )
break ;
/* next segment please */
nameptr = name_end + 1 ;
num_entries + + ;
}
if ( num_entries = = 0 )
return ;
2004-12-07 21:25:53 +03:00
if ( ( ( * ppname_array ) = SMB_MALLOC_ARRAY ( name_compare_entry , num_entries + 1 ) ) = = NULL ) {
2002-11-13 02:20:50 +03:00
DEBUG ( 0 , ( " set_namearray: malloc fail \n " ) ) ;
return ;
}
/* Now copy out the names */
nameptr = namelist ;
i = 0 ;
while ( * nameptr ) {
if ( * nameptr = = ' / ' ) {
/* cope with multiple (useless) /s) */
nameptr + + ;
continue ;
}
/* find the next / */
if ( ( name_end = strchr_m ( nameptr , ' / ' ) ) ! = NULL )
* name_end = 0 ;
/* oops - the last check for a / didn't find one. */
if ( name_end = = NULL )
break ;
( * ppname_array ) [ i ] . is_wild = ms_has_wild ( nameptr ) ;
2004-12-07 21:25:53 +03:00
if ( ( ( * ppname_array ) [ i ] . name = SMB_STRDUP ( nameptr ) ) = = NULL ) {
2002-11-13 02:20:50 +03:00
DEBUG ( 0 , ( " set_namearray: malloc fail (1) \n " ) ) ;
return ;
}
/* next segment please */
nameptr = name_end + 1 ;
i + + ;
}
1997-08-26 02:18:31 +04:00
2002-11-13 02:20:50 +03:00
( * ppname_array ) [ i ] . name = NULL ;
1996-12-10 21:03:44 +03:00
2002-11-13 02:20:50 +03:00
return ;
1997-07-08 20:54:44 +04:00
}
1997-07-24 21:25:11 +04:00
/****************************************************************************
2002-11-13 02:20:50 +03:00
Routine to free a namearray .
1997-07-24 21:25:11 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
void free_namearray ( name_compare_entry * name_array )
1997-07-08 20:54:44 +04:00
{
2003-01-24 22:19:25 +03:00
int i ;
2002-11-13 02:20:50 +03:00
if ( name_array = = NULL )
return ;
1997-07-24 21:25:11 +04:00
2003-01-24 22:19:25 +03:00
for ( i = 0 ; name_array [ i ] . name ! = NULL ; i + + )
SAFE_FREE ( name_array [ i ] . name ) ;
2002-11-13 02:20:50 +03:00
SAFE_FREE ( name_array ) ;
1997-07-08 20:54:44 +04:00
}
2005-04-27 22:32:37 +04:00
# undef DBGC_CLASS
# define DBGC_CLASS DBGC_LOCKING
1999-12-13 16:27:58 +03:00
/****************************************************************************
2000-05-02 07:20:47 +04:00
Simple routine to do POSIX file locking . Cruft in NFS and 64 - > 32 bit mapping
is dealt with in posix . c
2006-04-10 19:33:04 +04:00
Returns True if the lock was granted , False otherwise .
1996-12-10 21:03:44 +03:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
1999-12-13 16:27:58 +03:00
1998-09-04 04:23:28 +04:00
BOOL fcntl_lock ( int fd , int op , SMB_OFF_T offset , SMB_OFF_T count , int type )
1996-12-10 21:03:44 +03:00
{
2002-11-13 02:20:50 +03:00
SMB_STRUCT_FLOCK lock ;
int ret ;
2000-04-13 03:01:11 +04:00
2002-11-13 02:20:50 +03:00
DEBUG ( 8 , ( " fcntl_lock %d %d %.0f %.0f %d \n " , fd , op , ( double ) offset , ( double ) count , type ) ) ;
1996-12-10 21:03:44 +03:00
2002-11-13 02:20:50 +03:00
lock . l_type = type ;
lock . l_whence = SEEK_SET ;
lock . l_start = offset ;
lock . l_len = count ;
lock . l_pid = 0 ;
1996-12-10 21:03:44 +03:00
2002-11-13 02:20:50 +03:00
ret = sys_fcntl_ptr ( fd , op , & lock ) ;
1996-12-10 21:03:44 +03:00
2002-11-13 02:20:50 +03:00
if ( ret = = - 1 ) {
DEBUG ( 3 , ( " fcntl_lock: lock failed at offset %.0f count %.0f op %d type %d (%s) \n " ,
( double ) offset , ( double ) count , op , type , strerror ( errno ) ) ) ;
2006-04-10 19:33:04 +04:00
return False ;
2002-11-13 02:20:50 +03:00
}
1998-09-04 04:23:28 +04:00
2002-11-13 02:20:50 +03:00
/* everything went OK */
DEBUG ( 8 , ( " fcntl_lock: Lock call successful \n " ) ) ;
1996-12-10 21:03:44 +03:00
2006-04-10 19:33:04 +04:00
return True ;
}
/****************************************************************************
Simple routine to query existing file locks . Cruft in NFS and 64 - > 32 bit mapping
is dealt with in posix . c
Returns True if we have information regarding this lock region ( and returns
F_UNLCK in * ptype if the region is unlocked ) . False if the call failed .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
BOOL fcntl_getlock ( int fd , SMB_OFF_T * poffset , SMB_OFF_T * pcount , int * ptype , pid_t * ppid )
{
SMB_STRUCT_FLOCK lock ;
int ret ;
DEBUG ( 8 , ( " fcntl_getlock %d %.0f %.0f %d \n " , fd , ( double ) * poffset , ( double ) * pcount , * ptype ) ) ;
lock . l_type = * ptype ;
lock . l_whence = SEEK_SET ;
lock . l_start = * poffset ;
lock . l_len = * pcount ;
lock . l_pid = 0 ;
ret = sys_fcntl_ptr ( fd , SMB_F_GETLK , & lock ) ;
if ( ret = = - 1 ) {
DEBUG ( 3 , ( " fcntl_getlock: lock request failed at offset %.0f count %.0f type %d (%s) \n " ,
( double ) * poffset , ( double ) * pcount , * ptype , strerror ( errno ) ) ) ;
return False ;
}
* ptype = lock . l_type ;
* poffset = lock . l_start ;
* pcount = lock . l_len ;
* ppid = lock . l_pid ;
DEBUG ( 3 , ( " fcntl_getlock: fd %d is returned info %d pid %u \n " ,
fd , ( int ) lock . l_type , ( unsigned int ) lock . l_pid ) ) ;
return True ;
1996-12-10 21:03:44 +03:00
}
2005-04-27 22:32:37 +04:00
# undef DBGC_CLASS
# define DBGC_CLASS DBGC_ALL
1997-07-31 22:47:26 +04:00
/*******************************************************************
2002-07-15 14:35:28 +04:00
Is the name specified one of my netbios names .
Returns true if it is equal , false otherwise .
1997-07-31 22:47:26 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2002-07-15 14:35:28 +04:00
2002-11-13 02:20:50 +03:00
BOOL is_myname ( const char * s )
1997-07-31 22:47:26 +04:00
{
2002-07-15 14:35:28 +04:00
int n ;
BOOL ret = False ;
1997-07-31 22:47:26 +04:00
2002-11-13 02:20:50 +03:00
for ( n = 0 ; my_netbios_names ( n ) ; n + + ) {
if ( strequal ( my_netbios_names ( n ) , s ) ) {
2002-07-15 14:35:28 +04:00
ret = True ;
2002-11-13 02:20:50 +03:00
break ;
}
2002-07-15 14:35:28 +04:00
}
DEBUG ( 8 , ( " is_myname( \" %s \" ) returns %d \n " , s , ret ) ) ;
return ( ret ) ;
}
2002-11-13 02:20:50 +03:00
BOOL is_myname_or_ipaddr ( const char * s )
2001-11-29 00:51:11 +03:00
{
2004-10-02 00:34:12 +04:00
fstring name , dnsname ;
char * servername ;
if ( ! s )
return False ;
/* santize the string from '\\name' */
fstrcpy ( name , s ) ;
servername = strrchr_m ( name , ' \\ ' ) ;
if ( ! servername )
servername = name ;
else
servername + + ;
2001-11-29 00:51:11 +03:00
/* optimize for the common case */
2004-10-02 00:34:12 +04:00
if ( strequal ( servername , global_myname ( ) ) )
2001-11-29 00:51:11 +03:00
return True ;
2004-10-02 00:34:12 +04:00
/* check for an alias */
if ( is_myname ( servername ) )
return True ;
2004-11-10 05:13:36 +03:00
/* check for loopback */
if ( strequal ( servername , " localhost " ) )
return True ;
2004-10-02 00:34:12 +04:00
/* maybe it's my dns name */
if ( get_mydnsfullname ( dnsname ) )
if ( strequal ( servername , dnsname ) )
return True ;
/* handle possible CNAME records */
if ( ! is_ipaddress ( servername ) ) {
/* use DNS to resolve the name, but only the first address */
struct hostent * hp ;
if ( ( ( hp = sys_gethostbyname ( name ) ) ! = NULL ) & & ( hp - > h_addr ! = NULL ) ) {
struct in_addr return_ip ;
putip ( ( char * ) & return_ip , ( char * ) hp - > h_addr ) ;
fstrcpy ( name , inet_ntoa ( return_ip ) ) ;
servername = name ;
}
}
2001-11-29 00:51:11 +03:00
/* maybe its an IP address? */
2004-10-02 00:34:12 +04:00
if ( is_ipaddress ( servername ) ) {
2001-11-29 00:51:11 +03:00
struct iface_struct nics [ MAX_INTERFACES ] ;
int i , n ;
uint32 ip ;
2004-10-02 00:34:12 +04:00
ip = interpret_addr ( servername ) ;
2001-11-29 00:51:11 +03:00
if ( ( ip = = 0 ) | | ( ip = = 0xffffffff ) )
return False ;
n = get_interfaces ( nics , MAX_INTERFACES ) ;
for ( i = 0 ; i < n ; i + + ) {
if ( ip = = nics [ i ] . ip . s_addr )
return True ;
}
}
/* no match */
return False ;
}
2003-02-24 06:09:08 +03:00
/*******************************************************************
Is the name specified our workgroup / domain .
Returns true if it is equal , false otherwise .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
BOOL is_myworkgroup ( const char * s )
{
BOOL ret = False ;
if ( strequal ( s , lp_workgroup ( ) ) ) {
ret = True ;
}
DEBUG ( 8 , ( " is_myworkgroup( \" %s \" ) returns %d \n " , s , ret ) ) ;
return ( ret ) ;
}
2003-03-15 02:06:06 +03:00
/*******************************************************************
we distinguish between 2 K and XP by the " Native Lan Manager " string
WinXP = > " Windows 2002 5.1 "
Win2k = > " Windows 2000 5.0 "
NT4 = > " Windows NT 4.0 "
Win9x = > " Windows 4.0 "
2003-12-06 00:51:51 +03:00
Windows 2003 doesn ' t set the native lan manager string but
they do set the domain to " Windows 2003 5.2 " ( probably a bug ) .
2003-03-15 02:06:06 +03:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
void ra_lanman_string ( const char * native_lanman )
{
2003-12-06 00:51:51 +03:00
if ( strcmp ( native_lanman , " Windows 2002 5.1 " ) = = 0 )
2003-03-15 02:06:06 +03:00
set_remote_arch ( RA_WINXP ) ;
2003-12-06 00:51:51 +03:00
else if ( strcmp ( native_lanman , " Windows Server 2003 5.2 " ) = = 0 )
2003-03-15 02:06:06 +03:00
set_remote_arch ( RA_WIN2K3 ) ;
}
1997-09-05 00:26:07 +04:00
/*******************************************************************
2002-07-15 14:35:28 +04:00
Set the horrid remote_arch string based on an enum .
1997-09-05 00:26:07 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2002-07-15 14:35:28 +04:00
1997-09-05 00:26:07 +04:00
void set_remote_arch ( enum remote_arch_types type )
{
2002-07-15 14:35:28 +04:00
ra_type = type ;
switch ( type ) {
case RA_WFWG :
fstrcpy ( remote_arch , " WfWg " ) ;
2003-12-06 00:51:51 +03:00
break ;
2002-07-15 14:35:28 +04:00
case RA_OS2 :
fstrcpy ( remote_arch , " OS2 " ) ;
2003-12-06 00:51:51 +03:00
break ;
2002-07-15 14:35:28 +04:00
case RA_WIN95 :
fstrcpy ( remote_arch , " Win95 " ) ;
2003-12-06 00:51:51 +03:00
break ;
2002-07-15 14:35:28 +04:00
case RA_WINNT :
fstrcpy ( remote_arch , " WinNT " ) ;
2003-12-06 00:51:51 +03:00
break ;
2002-07-15 14:35:28 +04:00
case RA_WIN2K :
fstrcpy ( remote_arch , " Win2K " ) ;
2003-12-06 00:51:51 +03:00
break ;
2003-02-28 00:22:36 +03:00
case RA_WINXP :
fstrcpy ( remote_arch , " WinXP " ) ;
2003-12-06 00:51:51 +03:00
break ;
2003-03-12 18:41:39 +03:00
case RA_WIN2K3 :
fstrcpy ( remote_arch , " Win2K3 " ) ;
2003-12-06 00:51:51 +03:00
break ;
2002-07-15 14:35:28 +04:00
case RA_SAMBA :
fstrcpy ( remote_arch , " Samba " ) ;
2003-12-06 00:51:51 +03:00
break ;
2004-06-16 03:46:58 +04:00
case RA_CIFSFS :
fstrcpy ( remote_arch , " CIFSFS " ) ;
break ;
2002-07-15 14:35:28 +04:00
default :
ra_type = RA_UNKNOWN ;
fstrcpy ( remote_arch , " UNKNOWN " ) ;
break ;
}
2003-12-06 00:51:51 +03:00
DEBUG ( 10 , ( " set_remote_arch: Client arch is \' %s \' \n " , remote_arch ) ) ;
1997-09-05 00:26:07 +04:00
}
/*******************************************************************
Get the remote_arch type .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2002-07-15 14:35:28 +04:00
1998-04-13 23:24:06 +04:00
enum remote_arch_types get_remote_arch ( void )
1997-09-05 00:26:07 +04:00
{
2002-07-15 14:35:28 +04:00
return ra_type ;
1997-09-05 00:26:07 +04:00
}
1997-09-26 22:55:29 +04:00
2001-07-07 11:00:15 +04:00
void print_asc ( int level , const unsigned char * buf , int len )
1997-10-11 19:10:57 +04:00
{
int i ;
for ( i = 0 ; i < len ; i + + )
1999-12-13 16:27:58 +03:00
DEBUG ( level , ( " %c " , isprint ( buf [ i ] ) ? buf [ i ] : ' . ' ) ) ;
1997-10-11 19:10:57 +04:00
}
2001-07-07 11:00:15 +04:00
void dump_data ( int level , const char * buf1 , int len )
1997-10-11 19:10:57 +04:00
{
2002-09-25 19:19:00 +04:00
const unsigned char * buf = ( const unsigned char * ) buf1 ;
int i = 0 ;
if ( len < = 0 ) return ;
if ( ! DEBUGLVL ( level ) ) return ;
DEBUGADD ( level , ( " [%03X] " , i ) ) ;
for ( i = 0 ; i < len ; ) {
DEBUGADD ( level , ( " %02X " , ( int ) buf [ i ] ) ) ;
i + + ;
if ( i % 8 = = 0 ) DEBUGADD ( level , ( " " ) ) ;
if ( i % 16 = = 0 ) {
print_asc ( level , & buf [ i - 16 ] , 8 ) ; DEBUGADD ( level , ( " " ) ) ;
print_asc ( level , & buf [ i - 8 ] , 8 ) ; DEBUGADD ( level , ( " \n " ) ) ;
if ( i < len ) DEBUGADD ( level , ( " [%03X] " , i ) ) ;
}
}
if ( i % 16 ) {
int n ;
n = 16 - ( i % 16 ) ;
DEBUGADD ( level , ( " " ) ) ;
if ( n > 8 ) DEBUGADD ( level , ( " " ) ) ;
while ( n - - ) DEBUGADD ( level , ( " " ) ) ;
n = MIN ( 8 , i % 16 ) ;
print_asc ( level , & buf [ i - ( i % 16 ) ] , n ) ; DEBUGADD ( level , ( " " ) ) ;
n = ( i % 16 ) - n ;
if ( n > 0 ) print_asc ( level , & buf [ i - n ] , n ) ;
DEBUGADD ( level , ( " \n " ) ) ;
}
1997-10-11 19:10:57 +04:00
}
1997-10-12 15:46:42 +04:00
Jeremy requested that I get my NTLMSSP patch into CVS. He didn't request
the schannel code, but I've included that anyway. :-)
This patch revives the client-side NTLMSSP support for RPC named pipes
in Samba, and cleans up the client and server schannel code. The use of the
new code is enabled by the 'sign', 'seal' and 'schannel' commands in
rpcclient.
The aim was to prove that our separate NTLMSSP client library actually
implements NTLMSSP signing and sealing as per Microsoft's NTLMv1 implementation,
in the hope that knowing this will assist us in correctly implementing
NTLMSSP signing for SMB packets. (Still not yet functional)
This patch replaces the NTLMSSP implementation in rpc_client/cli_pipe.c with
calls to libsmb/ntlmssp.c. In the process, we have gained the ability to
use the more secure NT password, and the ability to sign-only, instead of
having to seal the pipe connection. (Previously we were limited to sealing,
and could only use the LM-password derived key).
Our new client-side NTLMSSP code also needed alteration to cope with our
comparatively simple server-side implementation. A future step is to replace
it with calls to the same NTLMSSP library.
Also included in this patch is the schannel 'sign only' patch I submitted to
the team earlier. While not enabled (and not functional, at this stage) the
work in this patch makes the code paths *much* easier to follow. I have also
included similar hooks in rpccleint to allow the use of schannel on *any* pipe.
rpcclient now defaults to not using schannel (or any other extra per-pipe
authenticiation) for any connection. The 'schannel' command enables schannel
for all pipes until disabled.
This code is also much more secure than the previous code, as changes to our
cli_pipe routines ensure that the authentication footer cannot be removed
by an attacker, and more error states are correctly handled.
(The same needs to be done to our server)
Andrew Bartlett
(This used to be commit 5472ddc9eaf4e79c5b2e1c8ee8c7f190dc285f19)
2003-07-14 12:46:32 +04:00
void dump_data_pw ( const char * msg , const uchar * data , size_t len )
{
# ifdef DEBUG_PASSWORD
DEBUG ( 11 , ( " %s " , msg ) ) ;
if ( data ! = NULL & & len > 0 )
{
2005-10-18 07:24:00 +04:00
dump_data ( 11 , ( const char * ) data , len ) ;
Jeremy requested that I get my NTLMSSP patch into CVS. He didn't request
the schannel code, but I've included that anyway. :-)
This patch revives the client-side NTLMSSP support for RPC named pipes
in Samba, and cleans up the client and server schannel code. The use of the
new code is enabled by the 'sign', 'seal' and 'schannel' commands in
rpcclient.
The aim was to prove that our separate NTLMSSP client library actually
implements NTLMSSP signing and sealing as per Microsoft's NTLMv1 implementation,
in the hope that knowing this will assist us in correctly implementing
NTLMSSP signing for SMB packets. (Still not yet functional)
This patch replaces the NTLMSSP implementation in rpc_client/cli_pipe.c with
calls to libsmb/ntlmssp.c. In the process, we have gained the ability to
use the more secure NT password, and the ability to sign-only, instead of
having to seal the pipe connection. (Previously we were limited to sealing,
and could only use the LM-password derived key).
Our new client-side NTLMSSP code also needed alteration to cope with our
comparatively simple server-side implementation. A future step is to replace
it with calls to the same NTLMSSP library.
Also included in this patch is the schannel 'sign only' patch I submitted to
the team earlier. While not enabled (and not functional, at this stage) the
work in this patch makes the code paths *much* easier to follow. I have also
included similar hooks in rpccleint to allow the use of schannel on *any* pipe.
rpcclient now defaults to not using schannel (or any other extra per-pipe
authenticiation) for any connection. The 'schannel' command enables schannel
for all pipes until disabled.
This code is also much more secure than the previous code, as changes to our
cli_pipe routines ensure that the authentication footer cannot be removed
by an attacker, and more error states are correctly handled.
(The same needs to be done to our server)
Andrew Bartlett
(This used to be commit 5472ddc9eaf4e79c5b2e1c8ee8c7f190dc285f19)
2003-07-14 12:46:32 +04:00
}
# endif
}
1997-10-12 15:46:42 +04:00
char * tab_depth ( int depth )
{
static pstring spaces ;
memset ( spaces , ' ' , depth * 4 ) ;
spaces [ depth * 4 ] = 0 ;
return spaces ;
}
1997-10-20 20:25:19 +04:00
1998-08-14 21:38:29 +04:00
/*****************************************************************************
2002-11-13 02:20:50 +03:00
Provide a checksum on a string
Input : s - the null - terminated character string for which the checksum
will be calculated .
Output : The checksum value calculated for s .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
1998-10-03 17:12:08 +04:00
int str_checksum ( const char * s )
1998-08-14 21:38:29 +04:00
{
int res = 0 ;
int c ;
int i = 0 ;
while ( * s ) {
c = * s ;
res ^ = ( c < < ( i % 15 ) ) ^ ( c > > ( 15 - ( i % 15 ) ) ) ;
s + + ;
i + + ;
}
return ( res ) ;
2002-11-13 02:20:50 +03:00
}
1998-08-30 08:31:55 +04:00
/*****************************************************************
2002-11-13 02:20:50 +03:00
Zero a memory area then free it . Used to catch bugs faster .
1998-08-30 08:31:55 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2002-11-13 02:20:50 +03:00
1998-09-11 05:24:30 +04:00
void zero_free ( void * p , size_t size )
1998-08-30 08:31:55 +04:00
{
memset ( p , 0 , size ) ;
2001-09-17 06:19:44 +04:00
SAFE_FREE ( p ) ;
1998-08-30 08:31:55 +04:00
}
1998-10-04 19:54:04 +04:00
1998-10-05 05:57:03 +04:00
/*****************************************************************
2002-11-13 02:20:50 +03:00
Set our open file limit to a requested max and return the limit .
1998-10-05 05:57:03 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2002-11-13 02:20:50 +03:00
1998-10-16 10:16:10 +04:00
int set_maxfiles ( int requested_max )
1998-10-05 05:57:03 +04:00
{
# if (defined(HAVE_GETRLIMIT) && defined(RLIMIT_NOFILE))
struct rlimit rlp ;
1999-12-13 16:27:58 +03:00
int saved_current_limit ;
if ( getrlimit ( RLIMIT_NOFILE , & rlp ) ) {
DEBUG ( 0 , ( " set_maxfiles: getrlimit (1) for RLIMIT_NOFILE failed with error %s \n " ,
strerror ( errno ) ) ) ;
/* just guess... */
return requested_max ;
}
/*
2002-11-13 02:20:50 +03:00
* Set the fd limit to be real_max_open_files + MAX_OPEN_FUDGEFACTOR to
1998-10-19 21:32:10 +04:00
* account for the extra fd we need
* as well as the log files and standard
1999-12-13 16:27:58 +03:00
* handles etc . Save the limit we want to set in case
* we are running on an OS that doesn ' t support this limit ( AIX )
* which always returns RLIM_INFINITY for rlp . rlim_max .
*/
2001-04-13 23:33:26 +04:00
/* Try raising the hard (max) limit to the requested amount. */
# if defined(RLIM_INFINITY)
if ( rlp . rlim_max ! = RLIM_INFINITY ) {
int orig_max = rlp . rlim_max ;
if ( rlp . rlim_max < requested_max )
rlp . rlim_max = requested_max ;
/* This failing is not an error - many systems (Linux) don't
support our default request of 10 , 000 open files . JRA . */
if ( setrlimit ( RLIMIT_NOFILE , & rlp ) ) {
DEBUG ( 3 , ( " set_maxfiles: setrlimit for RLIMIT_NOFILE for %d max files failed with error %s \n " ,
( int ) rlp . rlim_max , strerror ( errno ) ) ) ;
/* Set failed - restore original value from get. */
rlp . rlim_max = orig_max ;
}
}
# endif
/* Now try setting the soft (current) limit. */
1999-12-13 16:27:58 +03:00
saved_current_limit = rlp . rlim_cur = MIN ( requested_max , rlp . rlim_max ) ;
if ( setrlimit ( RLIMIT_NOFILE , & rlp ) ) {
DEBUG ( 0 , ( " set_maxfiles: setrlimit for RLIMIT_NOFILE for %d files failed with error %s \n " ,
( int ) rlp . rlim_cur , strerror ( errno ) ) ) ;
/* just guess... */
return saved_current_limit ;
}
if ( getrlimit ( RLIMIT_NOFILE , & rlp ) ) {
DEBUG ( 0 , ( " set_maxfiles: getrlimit (2) for RLIMIT_NOFILE failed with error %s \n " ,
strerror ( errno ) ) ) ;
/* just guess... */
return saved_current_limit ;
}
# if defined(RLIM_INFINITY)
if ( rlp . rlim_cur = = RLIM_INFINITY )
return saved_current_limit ;
# endif
2002-11-13 02:20:50 +03:00
if ( ( int ) rlp . rlim_cur > saved_current_limit )
1999-12-13 16:27:58 +03:00
return saved_current_limit ;
1998-10-05 05:57:03 +04:00
return rlp . rlim_cur ;
1999-12-13 16:27:58 +03:00
# else /* !defined(HAVE_GETRLIMIT) || !defined(RLIMIT_NOFILE) */
1998-10-16 10:16:10 +04:00
/*
* No way to know - just guess . . .
*/
return requested_max ;
1998-10-05 05:57:03 +04:00
# endif
}
1998-11-11 17:23:55 +03:00
2001-04-12 03:19:08 +04:00
/*****************************************************************
2002-11-13 02:20:50 +03:00
Possibly replace mkstemp if it is broken .
2001-04-12 03:19:08 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2002-11-13 02:20:50 +03:00
2005-06-25 00:25:18 +04:00
int smb_mkstemp ( char * name_template )
2001-04-12 03:19:08 +04:00
{
# if HAVE_SECURE_MKSTEMP
2005-06-25 00:25:18 +04:00
return mkstemp ( name_template ) ;
2001-04-12 03:19:08 +04:00
# else
/* have a reasonable go at emulating it. Hope that
2001-04-18 09:12:46 +04:00
the system mktemp ( ) isn ' t completly hopeless */
2005-06-25 00:25:18 +04:00
char * p = mktemp ( name_template ) ;
2002-11-13 02:20:50 +03:00
if ( ! p )
return - 1 ;
2001-04-13 04:37:00 +04:00
return open ( p , O_CREAT | O_EXCL | O_RDWR , 0600 ) ;
2001-04-12 03:19:08 +04:00
# endif
}
1999-12-12 23:03:42 +03:00
2002-07-15 14:35:28 +04:00
/*****************************************************************
2001-10-22 06:34:41 +04:00
malloc that aborts with smb_panic on fail or zero size .
2002-07-15 14:35:28 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2004-12-07 21:25:53 +03:00
void * smb_xmalloc_array ( size_t size , unsigned int count )
2001-10-22 06:34:41 +04:00
{
void * p ;
if ( size = = 0 )
2004-12-07 21:25:53 +03:00
smb_panic ( " smb_xmalloc_array: called with zero size. \n " ) ;
if ( count > = MAX_ALLOC_SIZE / size ) {
smb_panic ( " smb_xmalloc: alloc size too large. \n " ) ;
}
if ( ( p = SMB_MALLOC ( size * count ) ) = = NULL ) {
DEBUG ( 0 , ( " smb_xmalloc_array failed to allocate %lu * %lu bytes \n " ,
( unsigned long ) size , ( unsigned long ) count ) ) ;
smb_panic ( " smb_xmalloc_array: malloc fail. \n " ) ;
2003-03-22 16:47:42 +03:00
}
2001-10-22 06:34:41 +04:00
return p ;
}
2001-11-20 09:38:09 +03:00
/**
2001-10-22 06:34:41 +04:00
Memdup with smb_panic on fail .
2001-11-20 09:38:09 +03:00
* */
2002-11-13 02:20:50 +03:00
2001-11-20 09:38:09 +03:00
void * smb_xmemdup ( const void * p , size_t size )
2001-10-22 06:34:41 +04:00
{
void * p2 ;
2004-12-07 21:25:53 +03:00
p2 = SMB_XMALLOC_ARRAY ( unsigned char , size ) ;
2001-10-22 06:34:41 +04:00
memcpy ( p2 , p , size ) ;
return p2 ;
}
2001-11-20 09:38:09 +03:00
/**
2001-10-22 06:38:45 +04:00
strdup that aborts on malloc fail .
2001-11-20 09:38:09 +03:00
* */
2002-11-13 02:20:50 +03:00
2001-11-20 09:38:09 +03:00
char * smb_xstrdup ( const char * s )
2001-10-22 06:38:45 +04:00
{
2004-12-07 21:25:53 +03:00
# if defined(PARANOID_MALLOC_CHECKER)
# ifdef strdup
# undef strdup
# endif
# endif
2001-10-22 06:38:45 +04:00
char * s1 = strdup ( s ) ;
2004-12-07 21:25:53 +03:00
# if defined(PARANOID_MALLOC_CHECKER)
# define strdup(s) __ERROR_DONT_USE_STRDUP_DIRECTLY
# endif
2001-10-22 06:38:45 +04:00
if ( ! s1 )
2001-11-20 09:38:09 +03:00
smb_panic ( " smb_xstrdup: malloc fail \n " ) ;
2001-10-22 06:38:45 +04:00
return s1 ;
2004-12-07 21:25:53 +03:00
2001-10-22 06:38:45 +04:00
}
2002-09-25 19:19:00 +04:00
/**
strndup that aborts on malloc fail .
* */
2002-11-13 02:20:50 +03:00
2002-09-25 19:19:00 +04:00
char * smb_xstrndup ( const char * s , size_t n )
{
2004-12-07 21:25:53 +03:00
# if defined(PARANOID_MALLOC_CHECKER)
# ifdef strndup
# undef strndup
# endif
# endif
2002-09-25 19:19:00 +04:00
char * s1 = strndup ( s , n ) ;
2004-12-07 21:25:53 +03:00
# if defined(PARANOID_MALLOC_CHECKER)
# define strndup(s,n) __ERROR_DONT_USE_STRNDUP_DIRECTLY
# endif
2002-09-25 19:19:00 +04:00
if ( ! s1 )
smb_panic ( " smb_xstrndup: malloc fail \n " ) ;
return s1 ;
}
2001-12-10 02:56:07 +03:00
/*
vasprintf that aborts on malloc fail
*/
2002-11-13 02:20:50 +03:00
2003-01-03 06:24:23 +03:00
int smb_xvasprintf ( char * * ptr , const char * format , va_list ap )
2001-12-10 02:56:07 +03:00
{
int n ;
2002-07-15 14:35:28 +04:00
va_list ap2 ;
VA_COPY ( ap2 , ap ) ;
n = vasprintf ( ptr , format , ap2 ) ;
2002-11-13 02:20:50 +03:00
if ( n = = - 1 | | ! * ptr )
2001-12-10 02:56:07 +03:00
smb_panic ( " smb_xvasprintf: out of memory " ) ;
return n ;
}
1999-12-13 16:27:58 +03:00
/*****************************************************************
2002-11-13 02:20:50 +03:00
Like strdup but for memory .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2001-10-30 01:14:17 +03:00
void * memdup ( const void * p , size_t size )
1999-12-12 23:03:42 +03:00
{
1999-12-13 16:27:58 +03:00
void * p2 ;
2002-11-13 02:20:50 +03:00
if ( size = = 0 )
return NULL ;
2004-12-07 21:25:53 +03:00
p2 = SMB_MALLOC ( size ) ;
2002-11-13 02:20:50 +03:00
if ( ! p2 )
return NULL ;
1999-12-13 16:27:58 +03:00
memcpy ( p2 , p , size ) ;
return p2 ;
1999-12-12 23:03:42 +03:00
}
1999-12-13 16:27:58 +03:00
/*****************************************************************
2002-11-13 02:20:50 +03:00
Get local hostname and cache result .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
1999-12-13 16:27:58 +03:00
char * myhostname ( void )
1999-12-12 23:03:42 +03:00
{
1999-12-13 16:27:58 +03:00
static pstring ret ;
2002-11-13 02:20:50 +03:00
if ( ret [ 0 ] = = 0 )
1999-12-13 16:27:58 +03:00
get_myname ( ret ) ;
return ret ;
1999-12-12 23:03:42 +03:00
}
1999-12-21 12:25:59 +03:00
/*****************************************************************
2002-11-13 02:20:50 +03:00
A useful function for returning a path in the Samba lock directory .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2002-07-15 14:35:28 +04:00
char * lock_path ( const char * name )
1999-12-21 12:25:59 +03:00
{
static pstring fname ;
pstrcpy ( fname , lp_lockdir ( ) ) ;
2003-09-05 23:59:55 +04:00
trim_char ( fname , ' \0 ' , ' / ' ) ;
1999-12-21 12:25:59 +03:00
2002-11-13 02:20:50 +03:00
if ( ! directory_exist ( fname , NULL ) )
1999-12-21 12:25:59 +03:00
mkdir ( fname , 0755 ) ;
pstrcat ( fname , " / " ) ;
pstrcat ( fname , name ) ;
return fname ;
}
2000-01-14 04:41:04 +03:00
2002-07-15 14:35:28 +04:00
/*****************************************************************
2002-11-13 02:20:50 +03:00
A useful function for returning a path in the Samba pid directory .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2002-07-15 14:35:28 +04:00
char * pid_path ( const char * name )
{
static pstring fname ;
pstrcpy ( fname , lp_piddir ( ) ) ;
2003-09-05 23:59:55 +04:00
trim_char ( fname , ' \0 ' , ' / ' ) ;
2002-07-15 14:35:28 +04:00
2002-11-13 02:20:50 +03:00
if ( ! directory_exist ( fname , NULL ) )
2002-07-15 14:35:28 +04:00
mkdir ( fname , 0755 ) ;
pstrcat ( fname , " / " ) ;
pstrcat ( fname , name ) ;
return fname ;
}
2001-11-19 06:35:27 +03:00
/**
* @ brief Returns an absolute path to a file in the Samba lib directory .
*
* @ param name File to find , relative to LIBDIR .
*
* @ retval Pointer to a static # pstring containing the full path .
* */
2002-11-13 02:20:50 +03:00
2002-07-15 14:35:28 +04:00
char * lib_path ( const char * name )
2001-10-03 16:18:20 +04:00
{
static pstring fname ;
2003-07-23 16:33:59 +04:00
fstr_sprintf ( fname , " %s/%s " , dyn_LIBDIR , name ) ;
2001-10-03 16:18:20 +04:00
return fname ;
}
2003-02-14 03:48:28 +03:00
/**
* @ brief Returns the platform specific shared library extension .
*
* @ retval Pointer to a static # fstring containing the extension .
* */
const char * shlib_ext ( void )
{
return dyn_SHLIBEXT ;
}
2000-01-14 04:41:04 +03:00
/*******************************************************************
Given a filename - get its directory name
NB : Returned in static storage . Caveats :
o Not safe in thread environment .
o Caller must not free .
o If caller wishes to preserve , they should copy .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
char * parent_dirname ( const char * path )
{
static pstring dirpath ;
char * p ;
if ( ! path )
return ( NULL ) ;
pstrcpy ( dirpath , path ) ;
2001-07-04 11:36:09 +04:00
p = strrchr_m ( dirpath , ' / ' ) ; /* Find final '/', if any */
2000-01-14 04:41:04 +03:00
if ( ! p ) {
pstrcpy ( dirpath , " . " ) ; /* No final "/", so dir is "." */
} else {
if ( p = = dirpath )
+ + p ; /* For root "/", leave "/" in place */
* p = ' \0 ' ;
}
return dirpath ;
}
2000-04-24 15:30:24 +04:00
2000-04-30 15:04:28 +04:00
/*******************************************************************
2002-11-13 02:20:50 +03:00
Determine if a pattern contains any Microsoft wildcard characters .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2003-11-18 05:06:41 +03:00
BOOL ms_has_wild ( const char * s )
2000-04-30 15:04:28 +04:00
{
char c ;
2005-06-23 01:20:41 +04:00
if ( lp_posix_pathnames ( ) ) {
/* With posix pathnames no characters are wild. */
return False ;
}
2000-04-30 15:04:28 +04:00
while ( ( c = * s + + ) ) {
switch ( c ) {
case ' * ' :
case ' ? ' :
case ' < ' :
case ' > ' :
case ' " ' :
return True ;
}
}
return False ;
}
2001-11-04 21:26:53 +03:00
BOOL ms_has_wild_w ( const smb_ucs2_t * s )
{
smb_ucs2_t c ;
2002-01-27 19:37:12 +03:00
if ( ! s ) return False ;
2001-11-04 21:26:53 +03:00
while ( ( c = * s + + ) ) {
switch ( c ) {
case UCS2_CHAR ( ' * ' ) :
case UCS2_CHAR ( ' ? ' ) :
case UCS2_CHAR ( ' < ' ) :
case UCS2_CHAR ( ' > ' ) :
case UCS2_CHAR ( ' " ' ) :
return True ;
}
}
return False ;
}
2000-04-30 15:04:28 +04:00
/*******************************************************************
2002-11-13 02:20:50 +03:00
A wrapper that handles case sensitivity and the special handling
of the " .. " name .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2003-01-03 11:28:12 +03:00
BOOL mask_match ( const char * string , char * pattern , BOOL is_case_sensitive )
2000-04-30 15:04:28 +04:00
{
2002-11-13 02:20:50 +03:00
if ( strcmp ( string , " .. " ) = = 0 )
string = " . " ;
if ( strcmp ( pattern , " . " ) = = 0 )
return False ;
2000-04-30 15:04:28 +04:00
2005-03-24 22:33:02 +03:00
return ms_fnmatch ( pattern , string , Protocol < = PROTOCOL_LANMAN2 , is_case_sensitive ) = = 0 ;
}
/*******************************************************************
A wrapper that handles case sensitivity and the special handling
of the " .. " name . Varient that is only called by old search code which requires
pattern translation .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
BOOL mask_match_search ( const char * string , char * pattern , BOOL is_case_sensitive )
{
if ( strcmp ( string , " .. " ) = = 0 )
string = " . " ;
if ( strcmp ( pattern , " . " ) = = 0 )
return False ;
return ms_fnmatch ( pattern , string , True , is_case_sensitive ) = = 0 ;
2000-04-30 15:04:28 +04:00
}
2004-03-19 02:45:15 +03:00
/*******************************************************************
A wrapper that handles a list of patters and calls mask_match ( )
on each . Returns True if any of the patterns match .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
BOOL mask_match_list ( const char * string , char * * list , int listLen , BOOL is_case_sensitive )
{
while ( listLen - - > 0 ) {
if ( mask_match ( string , * list + + , is_case_sensitive ) )
return True ;
}
return False ;
}
2001-10-03 01:58:09 +04:00
/*********************************************************
Recursive routine that is called by unix_wild_match .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2003-06-17 13:40:35 +04:00
static BOOL unix_do_match ( const char * regexp , const char * str )
2001-10-03 01:58:09 +04:00
{
2003-06-17 13:40:35 +04:00
const char * p ;
2001-10-03 01:58:09 +04:00
for ( p = regexp ; * p & & * str ; ) {
switch ( * p ) {
case ' ? ' :
str + + ;
p + + ;
break ;
case ' * ' :
/*
* Look for a character matching
* the one after the ' * ' .
*/
p + + ;
if ( ! * p )
return True ; /* Automatic match */
while ( * str ) {
while ( * str & & ( * p ! = * str ) )
str + + ;
/*
* Patch from weidel @ multichart . de . In the case of the regexp
* ' * XX * ' we want to ensure there are at least 2 ' X ' characters
* in the string after the ' * ' for a match to be made .
*/
{
int matchcount = 0 ;
/*
* Eat all the characters that match , but count how many there were .
*/
while ( * str & & ( * p = = * str ) ) {
str + + ;
matchcount + + ;
}
/*
* Now check that if the regexp had n identical characters that
* matchcount had at least that many matches .
*/
while ( * ( p + 1 ) & & ( * ( p + 1 ) = = * p ) ) {
p + + ;
matchcount - - ;
}
if ( matchcount < = 0 )
return False ;
}
str - - ; /* We've eaten the match char after the '*' */
if ( unix_do_match ( p , str ) )
return True ;
if ( ! * str )
return False ;
else
str + + ;
}
return False ;
default :
if ( * str ! = * p )
return False ;
str + + ;
p + + ;
break ;
}
}
if ( ! * p & & ! * str )
return True ;
if ( ! * p & & str [ 0 ] = = ' . ' & & str [ 1 ] = = 0 )
return ( True ) ;
if ( ! * str & & * p = = ' ? ' ) {
while ( * p = = ' ? ' )
p + + ;
return ( ! * p ) ;
}
if ( ! * str & & ( * p = = ' * ' & & p [ 1 ] = = ' \0 ' ) )
return True ;
return False ;
}
2001-07-24 02:06:05 +04:00
/*******************************************************************
2001-10-03 01:58:09 +04:00
Simple case insensitive interface to a UNIX wildcard matcher .
2005-12-16 04:41:12 +03:00
Returns True if match , False if not .
2001-07-24 02:06:05 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2001-10-03 01:58:09 +04:00
2003-02-24 06:09:08 +03:00
BOOL unix_wild_match ( const char * pattern , const char * string )
2001-07-24 02:06:05 +04:00
{
pstring p2 , s2 ;
2001-10-03 01:58:09 +04:00
char * p ;
2000-04-30 15:04:28 +04:00
2001-07-24 02:06:05 +04:00
pstrcpy ( p2 , pattern ) ;
pstrcpy ( s2 , string ) ;
2003-07-03 23:11:31 +04:00
strlower_m ( p2 ) ;
strlower_m ( s2 ) ;
2001-10-03 01:58:09 +04:00
/* Remove any *? and ** from the pattern as they are meaningless */
for ( p = p2 ; * p ; p + + )
while ( * p = = ' * ' & & ( p [ 1 ] = = ' ? ' | | p [ 1 ] = = ' * ' ) )
pstrcpy ( & p [ 1 ] , & p [ 2 ] ) ;
if ( strequal ( p2 , " * " ) )
return True ;
2005-12-16 04:41:12 +03:00
return unix_do_match ( p2 , s2 ) ;
2001-07-24 02:06:05 +04:00
}
2000-04-30 15:04:28 +04:00
2004-06-22 04:48:59 +04:00
/**********************************************************************
Converts a name to a fully qalified domain name .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
void name_to_fqdn ( fstring fqdn , const char * name )
{
struct hostent * hp = sys_gethostbyname ( name ) ;
if ( hp & & hp - > h_name & & * hp - > h_name ) {
DEBUG ( 10 , ( " name_to_fqdn: lookup for %s -> %s. \n " , name , hp - > h_name ) ) ;
fstrcpy ( fqdn , hp - > h_name ) ;
} else {
DEBUG ( 10 , ( " name_to_fqdn: lookup for %s failed. \n " , name ) ) ;
fstrcpy ( fqdn , name ) ;
}
}
2003-06-25 21:41:05 +04:00
2005-06-09 02:10:34 +04:00
/**********************************************************************
Extension to talloc_get_type : Abort on type mismatch
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
void * talloc_check_name_abort ( const void * ptr , const char * name )
{
void * result ;
if ( ptr = = NULL )
return NULL ;
result = talloc_check_name ( ptr , name ) ;
if ( result ! = NULL )
return result ;
DEBUG ( 0 , ( " Talloc type mismatch, expected %s, got %s \n " ,
name , talloc_get_name ( ptr ) ) ) ;
smb_panic ( " aborting " ) ;
/* Keep the compiler happy */
return NULL ;
}
2001-12-03 03:21:51 +03:00
# ifdef __INSURE__
2000-04-30 15:04:28 +04:00
/*******************************************************************
This routine is a trick to immediately catch errors when debugging
with insure . A xterm with a gdb is popped up when insure catches
a error . It is Linux specific .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2002-11-13 02:20:50 +03:00
2000-04-24 15:30:24 +04:00
int _Insure_trap_error ( int a1 , int a2 , int a3 , int a4 , int a5 , int a6 )
{
static int ( * fn ) ( ) ;
int ret ;
char pidstr [ 10 ] ;
2001-12-03 03:21:51 +03:00
/* you can get /usr/bin/backtrace from
http : //samba.org/ftp/unpacked/junkcode/backtrace */
pstring cmd = " /usr/bin/backtrace %d " ;
2000-04-24 15:30:24 +04:00
2001-04-09 00:22:39 +04:00
slprintf ( pidstr , sizeof ( pidstr ) - 1 , " %d " , sys_getpid ( ) ) ;
2000-04-24 15:30:24 +04:00
pstring_sub ( cmd , " %d " , pidstr ) ;
if ( ! fn ) {
static void * h ;
h = dlopen ( " /usr/local/parasoft/insure++lite/lib.linux2/libinsure.so " , RTLD_LAZY ) ;
fn = dlsym ( h , " _Insure_trap_error " ) ;
2002-04-04 08:54:44 +04:00
if ( ! h | | h = = _Insure_trap_error ) {
h = dlopen ( " /usr/local/parasoft/lib.linux2/libinsure.so " , RTLD_LAZY ) ;
fn = dlsym ( h , " _Insure_trap_error " ) ;
}
2000-04-24 15:30:24 +04:00
}
ret = fn ( a1 , a2 , a3 , a4 , a5 , a6 ) ;
system ( cmd ) ;
return ret ;
}
# endif
2005-07-08 08:51:27 +04:00
uint32 map_share_mode_to_deny_mode ( uint32 share_access , uint32 private_options )
{
2005-08-16 23:40:13 +04:00
switch ( share_access & ~ FILE_SHARE_DELETE ) {
2005-07-08 08:51:27 +04:00
case FILE_SHARE_NONE :
return DENY_ALL ;
case FILE_SHARE_READ :
return DENY_WRITE ;
case FILE_SHARE_WRITE :
return DENY_READ ;
case FILE_SHARE_READ | FILE_SHARE_WRITE :
return DENY_NONE ;
}
if ( private_options & NTCREATEX_OPTIONS_PRIVATE_DENY_DOS ) {
return DENY_DOS ;
} else if ( private_options & NTCREATEX_OPTIONS_PRIVATE_DENY_FCB ) {
return DENY_FCB ;
}
return ( uint32 ) - 1 ;
}
2005-09-30 21:13:37 +04:00
pid_t procid_to_pid ( const struct process_id * proc )
{
return proc - > pid ;
}
struct process_id pid_to_procid ( pid_t pid )
{
struct process_id result ;
result . pid = pid ;
return result ;
}
struct process_id procid_self ( void )
{
return pid_to_procid ( sys_getpid ( ) ) ;
}
BOOL procid_equal ( const struct process_id * p1 , const struct process_id * p2 )
{
return ( p1 - > pid = = p2 - > pid ) ;
}
BOOL procid_is_me ( const struct process_id * pid )
{
return ( pid - > pid = = sys_getpid ( ) ) ;
}
struct process_id interpret_pid ( const char * pid_string )
{
return pid_to_procid ( atoi ( pid_string ) ) ;
}
char * procid_str_static ( const struct process_id * pid )
{
static fstring str ;
fstr_sprintf ( str , " %d " , pid - > pid ) ;
return str ;
}
char * procid_str ( TALLOC_CTX * mem_ctx , const struct process_id * pid )
{
return talloc_strdup ( mem_ctx , procid_str_static ( pid ) ) ;
}
BOOL procid_valid ( const struct process_id * pid )
{
return ( pid - > pid ! = - 1 ) ;
}
BOOL procid_is_local ( const struct process_id * pid )
{
return True ;
}