2009-06-30 00:31:13 +04:00
/*
Unix SMB / CIFS implementation .
Core SMB2 server
Copyright ( C ) Stefan Metzmacher 2009
2010-04-29 01:56:12 +04:00
Copyright ( C ) Jeremy Allison 2010
2009-06-30 00:31:13 +04:00
This program is free software ; you can redistribute it and / or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation ; either version 3 of the License , or
( at your option ) any later version .
This program is distributed in the hope that it will be useful ,
but WITHOUT ANY WARRANTY ; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE . See the
GNU General Public License for more details .
You should have received a copy of the GNU General Public License
along with this program . If not , see < http : //www.gnu.org/licenses/>.
*/
# include "includes.h"
2011-03-22 18:57:01 +03:00
# include "smbd/smbd.h"
2009-06-30 00:31:13 +04:00
# include "smbd/globals.h"
2009-08-12 19:52:55 +04:00
# include "../libcli/smb/smb_common.h"
2011-04-28 19:38:09 +04:00
# include "../lib/util/tevent_ntstatus.h"
2009-06-30 00:31:13 +04:00
2010-04-24 02:34:58 +04:00
struct smbd_smb2_notify_state {
struct smbd_smb2_request * smb2req ;
struct smb_request * smbreq ;
s3:smb2_notify: fix use after free on long living notify requests
This is a hack, but it should fix the bug:
change_notify_add_request() talloc moves smb_request away,
which is not expected by the smb2_notify.c code...
smbd_smb2_notify_reply() uses tevent_req_defer_callback()
(in older versions an immediate event) to defer the response.
This is needed as change_notify_reply() will do more things
after calling reply_fn() (smbd_smb2_notify_reply is this case)
and often change_notify_remove_request() is called after
change_notify_reply().
change_notify_remove_request() implicitly free's the smb_request
that was passed to change_notify_add_request().
smbd_smb2_fake_smb_request() added the smb_request as smb2req->smb1req,
which is expected to be available after smbd_smb2_notify_recv() returned.
The long term solution would be the following interface:
struct tevent_req *change_notify_request_send(TALLOC_CTX *mem_ctx,
struct tevent_context *ev,
struct files_struct *fsp,
uint32_t max_length,
uint32_t filter,
bool recursive);
NTSTATUS change_notify_request_recv(struct tevent_req *req,
TALLOC_CTX *mem_ctx,
DATA_BLOB *buffer);
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10442
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Feb 14 11:18:15 CET 2014 on sn-devel-104
2014-01-30 19:12:44 +04:00
bool has_request ;
bool skip_reply ;
2010-04-24 02:34:58 +04:00
NTSTATUS status ;
DATA_BLOB out_output_buffer ;
} ;
2009-06-30 00:31:13 +04:00
static struct tevent_req * smbd_smb2_notify_send ( TALLOC_CTX * mem_ctx ,
struct tevent_context * ev ,
struct smbd_smb2_request * smb2req ,
2012-06-08 13:05:58 +04:00
struct files_struct * in_fsp ,
2009-06-30 00:31:13 +04:00
uint16_t in_flags ,
uint32_t in_output_buffer_length ,
uint64_t in_completion_filter ) ;
static NTSTATUS smbd_smb2_notify_recv ( struct tevent_req * req ,
TALLOC_CTX * mem_ctx ,
DATA_BLOB * out_output_buffer ) ;
static void smbd_smb2_request_notify_done ( struct tevent_req * subreq ) ;
NTSTATUS smbd_smb2_request_process_notify ( struct smbd_smb2_request * req )
{
2011-09-06 16:01:43 +04:00
NTSTATUS status ;
2009-06-30 00:31:13 +04:00
const uint8_t * inbody ;
uint16_t in_flags ;
uint32_t in_output_buffer_length ;
uint64_t in_file_id_persistent ;
uint64_t in_file_id_volatile ;
2012-06-08 13:05:58 +04:00
struct files_struct * in_fsp ;
2009-06-30 00:31:13 +04:00
uint64_t in_completion_filter ;
struct tevent_req * subreq ;
2011-09-06 16:01:43 +04:00
status = smbd_smb2_request_verify_sizes ( req , 0x20 ) ;
if ( ! NT_STATUS_IS_OK ( status ) ) {
return smbd_smb2_request_error ( req , status ) ;
2009-06-30 00:31:13 +04:00
}
2012-08-05 16:57:35 +04:00
inbody = SMBD_SMB2_IN_BODY_PTR ( req ) ;
2009-06-30 00:31:13 +04:00
in_flags = SVAL ( inbody , 0x02 ) ;
in_output_buffer_length = IVAL ( inbody , 0x04 ) ;
in_file_id_persistent = BVAL ( inbody , 0x08 ) ;
in_file_id_volatile = BVAL ( inbody , 0x10 ) ;
in_completion_filter = IVAL ( inbody , 0x18 ) ;
/*
* 0x00010000 is what Windows 7 uses ,
* Windows 2008 uses 0x00080000
*/
2011-09-23 19:18:14 +04:00
if ( in_output_buffer_length > req - > sconn - > smb2 . max_trans ) {
2009-06-30 00:31:13 +04:00
return smbd_smb2_request_error ( req , NT_STATUS_INVALID_PARAMETER ) ;
}
2012-02-28 05:51:40 +04:00
status = smbd_smb2_request_verify_creditcharge ( req ,
in_output_buffer_length ) ;
if ( ! NT_STATUS_IS_OK ( status ) ) {
return smbd_smb2_request_error ( req , status ) ;
}
2012-06-08 13:05:58 +04:00
in_fsp = file_fsp_smb2 ( req , in_file_id_persistent , in_file_id_volatile ) ;
if ( in_fsp = = NULL ) {
2009-06-30 00:31:13 +04:00
return smbd_smb2_request_error ( req , NT_STATUS_FILE_CLOSED ) ;
}
2012-06-08 13:05:58 +04:00
subreq = smbd_smb2_notify_send ( req , req - > sconn - > ev_ctx ,
req , in_fsp ,
2009-06-30 00:31:13 +04:00
in_flags ,
in_output_buffer_length ,
in_completion_filter ) ;
if ( subreq = = NULL ) {
return smbd_smb2_request_error ( req , NT_STATUS_NO_MEMORY ) ;
}
tevent_req_set_callback ( subreq , smbd_smb2_request_notify_done , req ) ;
2011-11-14 18:42:55 +04:00
return smbd_smb2_request_pending_queue ( req , subreq , 500 ) ;
2009-06-30 00:31:13 +04:00
}
static void smbd_smb2_request_notify_done ( struct tevent_req * subreq )
{
struct smbd_smb2_request * req = tevent_req_callback_data ( subreq ,
struct smbd_smb2_request ) ;
DATA_BLOB outbody ;
DATA_BLOB outdyn ;
uint16_t out_output_buffer_offset ;
2009-07-24 18:21:07 +04:00
DATA_BLOB out_output_buffer = data_blob_null ;
2009-06-30 00:31:13 +04:00
NTSTATUS status ;
NTSTATUS error ; /* transport error */
status = smbd_smb2_notify_recv ( subreq ,
req ,
& out_output_buffer ) ;
TALLOC_FREE ( subreq ) ;
if ( ! NT_STATUS_IS_OK ( status ) ) {
error = smbd_smb2_request_error ( req , status ) ;
if ( ! NT_STATUS_IS_OK ( error ) ) {
2009-08-07 17:21:07 +04:00
smbd_server_connection_terminate ( req - > sconn ,
2009-06-30 00:31:13 +04:00
nt_errstr ( error ) ) ;
return ;
}
return ;
}
out_output_buffer_offset = SMB2_HDR_BODY + 0x08 ;
2013-12-04 17:59:07 +04:00
outbody = smbd_smb2_generate_outbody ( req , 0x08 ) ;
2009-06-30 00:31:13 +04:00
if ( outbody . data = = NULL ) {
error = smbd_smb2_request_error ( req , NT_STATUS_NO_MEMORY ) ;
if ( ! NT_STATUS_IS_OK ( error ) ) {
2009-08-07 17:21:07 +04:00
smbd_server_connection_terminate ( req - > sconn ,
2009-06-30 00:31:13 +04:00
nt_errstr ( error ) ) ;
return ;
}
return ;
}
SSVAL ( outbody . data , 0x00 , 0x08 + 1 ) ; /* struct size */
SSVAL ( outbody . data , 0x02 ,
out_output_buffer_offset ) ; /* output buffer offset */
SIVAL ( outbody . data , 0x04 ,
out_output_buffer . length ) ; /* output buffer length */
outdyn = out_output_buffer ;
error = smbd_smb2_request_done ( req , outbody , & outdyn ) ;
if ( ! NT_STATUS_IS_OK ( error ) ) {
2009-08-07 17:21:07 +04:00
smbd_server_connection_terminate ( req - > sconn ,
2009-06-30 00:31:13 +04:00
nt_errstr ( error ) ) ;
return ;
}
}
static void smbd_smb2_notify_reply ( struct smb_request * smbreq ,
NTSTATUS error_code ,
uint8_t * buf , size_t len ) ;
2009-08-15 12:11:16 +04:00
static bool smbd_smb2_notify_cancel ( struct tevent_req * req ) ;
2009-06-30 00:31:13 +04:00
s3:smb2_notify: fix use after free on long living notify requests
This is a hack, but it should fix the bug:
change_notify_add_request() talloc moves smb_request away,
which is not expected by the smb2_notify.c code...
smbd_smb2_notify_reply() uses tevent_req_defer_callback()
(in older versions an immediate event) to defer the response.
This is needed as change_notify_reply() will do more things
after calling reply_fn() (smbd_smb2_notify_reply is this case)
and often change_notify_remove_request() is called after
change_notify_reply().
change_notify_remove_request() implicitly free's the smb_request
that was passed to change_notify_add_request().
smbd_smb2_fake_smb_request() added the smb_request as smb2req->smb1req,
which is expected to be available after smbd_smb2_notify_recv() returned.
The long term solution would be the following interface:
struct tevent_req *change_notify_request_send(TALLOC_CTX *mem_ctx,
struct tevent_context *ev,
struct files_struct *fsp,
uint32_t max_length,
uint32_t filter,
bool recursive);
NTSTATUS change_notify_request_recv(struct tevent_req *req,
TALLOC_CTX *mem_ctx,
DATA_BLOB *buffer);
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10442
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Feb 14 11:18:15 CET 2014 on sn-devel-104
2014-01-30 19:12:44 +04:00
static int smbd_smb2_notify_state_destructor ( struct smbd_smb2_notify_state * state )
{
if ( ! state - > has_request ) {
return 0 ;
}
state - > skip_reply = true ;
smbd_notify_cancel_by_smbreq ( state - > smbreq ) ;
return 0 ;
}
static int smbd_smb2_notify_smbreq_destructor ( struct smb_request * smbreq )
{
struct tevent_req * req = talloc_get_type_abort ( smbreq - > async_priv ,
struct tevent_req ) ;
struct smbd_smb2_notify_state * state = tevent_req_data ( req ,
struct smbd_smb2_notify_state ) ;
/*
* Our temporary parent from change_notify_add_request ( )
* goes away .
*/
state - > has_request = false ;
/*
* move it back to its original parent ,
* which means we no longer need the destructor
* to protect it .
*/
talloc_steal ( smbreq - > smb2req , smbreq ) ;
talloc_set_destructor ( smbreq , NULL ) ;
/*
* We want to keep smbreq !
*/
return - 1 ;
}
2009-06-30 00:31:13 +04:00
static struct tevent_req * smbd_smb2_notify_send ( TALLOC_CTX * mem_ctx ,
struct tevent_context * ev ,
struct smbd_smb2_request * smb2req ,
2012-06-08 13:05:58 +04:00
struct files_struct * fsp ,
2009-06-30 00:31:13 +04:00
uint16_t in_flags ,
uint32_t in_output_buffer_length ,
uint64_t in_completion_filter )
{
struct tevent_req * req ;
struct smbd_smb2_notify_state * state ;
struct smb_request * smbreq ;
2012-03-27 13:09:05 +04:00
connection_struct * conn = smb2req - > tcon - > compat ;
2012-03-03 09:34:32 +04:00
bool recursive = ( in_flags & SMB2_WATCH_TREE ) ? true : false ;
2009-06-30 00:31:13 +04:00
NTSTATUS status ;
req = tevent_req_create ( mem_ctx , & state ,
struct smbd_smb2_notify_state ) ;
if ( req = = NULL ) {
return NULL ;
}
state - > smb2req = smb2req ;
state - > status = NT_STATUS_INTERNAL_ERROR ;
state - > out_output_buffer = data_blob_null ;
s3:smb2_notify: fix use after free on long living notify requests
This is a hack, but it should fix the bug:
change_notify_add_request() talloc moves smb_request away,
which is not expected by the smb2_notify.c code...
smbd_smb2_notify_reply() uses tevent_req_defer_callback()
(in older versions an immediate event) to defer the response.
This is needed as change_notify_reply() will do more things
after calling reply_fn() (smbd_smb2_notify_reply is this case)
and often change_notify_remove_request() is called after
change_notify_reply().
change_notify_remove_request() implicitly free's the smb_request
that was passed to change_notify_add_request().
smbd_smb2_fake_smb_request() added the smb_request as smb2req->smb1req,
which is expected to be available after smbd_smb2_notify_recv() returned.
The long term solution would be the following interface:
struct tevent_req *change_notify_request_send(TALLOC_CTX *mem_ctx,
struct tevent_context *ev,
struct files_struct *fsp,
uint32_t max_length,
uint32_t filter,
bool recursive);
NTSTATUS change_notify_request_recv(struct tevent_req *req,
TALLOC_CTX *mem_ctx,
DATA_BLOB *buffer);
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10442
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Feb 14 11:18:15 CET 2014 on sn-devel-104
2014-01-30 19:12:44 +04:00
talloc_set_destructor ( state , smbd_smb2_notify_state_destructor ) ;
2009-06-30 00:31:13 +04:00
2012-06-14 15:23:11 +04:00
DEBUG ( 10 , ( " smbd_smb2_notify_send: %s - %s \n " ,
fsp_str_dbg ( fsp ) , fsp_fnum_dbg ( fsp ) ) ) ;
2009-06-30 00:31:13 +04:00
smbreq = smbd_smb2_fake_smb_request ( smb2req ) ;
if ( tevent_req_nomem ( smbreq , req ) ) {
return tevent_req_post ( req , ev ) ;
}
2009-08-15 12:11:16 +04:00
state - > smbreq = smbreq ;
2009-06-30 00:31:13 +04:00
smbreq - > async_priv = ( void * ) req ;
2013-12-03 00:32:47 +04:00
if ( DEBUGLEVEL > = 3 ) {
2009-06-30 00:31:13 +04:00
char * filter_string ;
filter_string = notify_filter_string ( NULL , in_completion_filter ) ;
if ( tevent_req_nomem ( filter_string , req ) ) {
return tevent_req_post ( req , ev ) ;
}
DEBUG ( 3 , ( " smbd_smb2_notify_send: notify change "
" called on %s, filter = %s, recursive = %d \n " ,
2009-07-11 01:50:37 +04:00
fsp_str_dbg ( fsp ) , filter_string , recursive ) ) ;
2009-06-30 00:31:13 +04:00
TALLOC_FREE ( filter_string ) ;
}
if ( ( ! fsp - > is_directory ) | | ( conn ! = fsp - > conn ) ) {
tevent_req_nterror ( req , NT_STATUS_INVALID_PARAMETER ) ;
return tevent_req_post ( req , ev ) ;
}
if ( fsp - > notify = = NULL ) {
status = change_notify_create ( fsp ,
in_completion_filter ,
recursive ) ;
if ( ! NT_STATUS_IS_OK ( status ) ) {
DEBUG ( 10 , ( " change_notify_create returned %s \n " ,
nt_errstr ( status ) ) ) ;
tevent_req_nterror ( req , status ) ;
return tevent_req_post ( req , ev ) ;
}
}
2012-06-05 11:37:39 +04:00
if ( change_notify_fsp_has_changes ( fsp ) ) {
2009-06-30 00:31:13 +04:00
/*
* We ' ve got changes pending , respond immediately
*/
/*
* TODO : write a torture test to check the filtering behaviour
* here .
*/
2010-06-12 15:17:51 +04:00
change_notify_reply ( smbreq ,
2009-06-30 00:31:13 +04:00
NT_STATUS_OK ,
in_output_buffer_length ,
fsp - > notify ,
smbd_smb2_notify_reply ) ;
/*
* change_notify_reply ( ) above has independently
* called tevent_req_done ( ) .
*/
return tevent_req_post ( req , ev ) ;
}
/*
* No changes pending , queue the request
*/
status = change_notify_add_request ( smbreq ,
in_output_buffer_length ,
in_completion_filter ,
recursive , fsp ,
smbd_smb2_notify_reply ) ;
if ( ! NT_STATUS_IS_OK ( status ) ) {
tevent_req_nterror ( req , status ) ;
return tevent_req_post ( req , ev ) ;
}
s3:smb2_notify: fix use after free on long living notify requests
This is a hack, but it should fix the bug:
change_notify_add_request() talloc moves smb_request away,
which is not expected by the smb2_notify.c code...
smbd_smb2_notify_reply() uses tevent_req_defer_callback()
(in older versions an immediate event) to defer the response.
This is needed as change_notify_reply() will do more things
after calling reply_fn() (smbd_smb2_notify_reply is this case)
and often change_notify_remove_request() is called after
change_notify_reply().
change_notify_remove_request() implicitly free's the smb_request
that was passed to change_notify_add_request().
smbd_smb2_fake_smb_request() added the smb_request as smb2req->smb1req,
which is expected to be available after smbd_smb2_notify_recv() returned.
The long term solution would be the following interface:
struct tevent_req *change_notify_request_send(TALLOC_CTX *mem_ctx,
struct tevent_context *ev,
struct files_struct *fsp,
uint32_t max_length,
uint32_t filter,
bool recursive);
NTSTATUS change_notify_request_recv(struct tevent_req *req,
TALLOC_CTX *mem_ctx,
DATA_BLOB *buffer);
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10442
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Feb 14 11:18:15 CET 2014 on sn-devel-104
2014-01-30 19:12:44 +04:00
/*
* This is a HACK !
*
* change_notify_add_request ( ) talloc_moves ( )
* smbreq away from us , so we need a destructor
* which moves it back at the end .
*/
state - > has_request = true ;
talloc_set_destructor ( smbreq , smbd_smb2_notify_smbreq_destructor ) ;
2009-08-15 12:11:16 +04:00
/* allow this request to be canceled */
tevent_req_set_cancel_fn ( req , smbd_smb2_notify_cancel ) ;
2009-06-30 00:31:13 +04:00
return req ;
}
static void smbd_smb2_notify_reply ( struct smb_request * smbreq ,
NTSTATUS error_code ,
uint8_t * buf , size_t len )
{
struct tevent_req * req = talloc_get_type_abort ( smbreq - > async_priv ,
struct tevent_req ) ;
struct smbd_smb2_notify_state * state = tevent_req_data ( req ,
struct smbd_smb2_notify_state ) ;
s3:smb2_notify: fix use after free on long living notify requests
This is a hack, but it should fix the bug:
change_notify_add_request() talloc moves smb_request away,
which is not expected by the smb2_notify.c code...
smbd_smb2_notify_reply() uses tevent_req_defer_callback()
(in older versions an immediate event) to defer the response.
This is needed as change_notify_reply() will do more things
after calling reply_fn() (smbd_smb2_notify_reply is this case)
and often change_notify_remove_request() is called after
change_notify_reply().
change_notify_remove_request() implicitly free's the smb_request
that was passed to change_notify_add_request().
smbd_smb2_fake_smb_request() added the smb_request as smb2req->smb1req,
which is expected to be available after smbd_smb2_notify_recv() returned.
The long term solution would be the following interface:
struct tevent_req *change_notify_request_send(TALLOC_CTX *mem_ctx,
struct tevent_context *ev,
struct files_struct *fsp,
uint32_t max_length,
uint32_t filter,
bool recursive);
NTSTATUS change_notify_request_recv(struct tevent_req *req,
TALLOC_CTX *mem_ctx,
DATA_BLOB *buffer);
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10442
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Feb 14 11:18:15 CET 2014 on sn-devel-104
2014-01-30 19:12:44 +04:00
if ( state - > skip_reply ) {
return ;
}
2009-06-30 00:31:13 +04:00
state - > status = error_code ;
if ( ! NT_STATUS_IS_OK ( error_code ) ) {
/* nothing */
} else if ( len = = 0 ) {
state - > status = STATUS_NOTIFY_ENUM_DIR ;
} else {
state - > out_output_buffer = data_blob_talloc ( state , buf , len ) ;
if ( state - > out_output_buffer . data = = NULL ) {
state - > status = NT_STATUS_NO_MEMORY ;
}
}
2012-09-20 18:25:58 +04:00
tevent_req_defer_callback ( req , state - > smb2req - > sconn - > ev_ctx ) ;
2009-06-30 00:31:13 +04:00
if ( ! NT_STATUS_IS_OK ( state - > status ) ) {
tevent_req_nterror ( req , state - > status ) ;
return ;
}
tevent_req_done ( req ) ;
}
2009-08-15 12:11:16 +04:00
static bool smbd_smb2_notify_cancel ( struct tevent_req * req )
{
struct smbd_smb2_notify_state * state = tevent_req_data ( req ,
struct smbd_smb2_notify_state ) ;
2010-06-12 15:08:31 +04:00
smbd_notify_cancel_by_smbreq ( state - > smbreq ) ;
2009-08-15 12:11:16 +04:00
return true ;
}
2009-06-30 00:31:13 +04:00
static NTSTATUS smbd_smb2_notify_recv ( struct tevent_req * req ,
TALLOC_CTX * mem_ctx ,
DATA_BLOB * out_output_buffer )
{
NTSTATUS status ;
struct smbd_smb2_notify_state * state = tevent_req_data ( req ,
struct smbd_smb2_notify_state ) ;
if ( tevent_req_is_nterror ( req , & status ) ) {
tevent_req_received ( req ) ;
return status ;
}
* out_output_buffer = state - > out_output_buffer ;
talloc_steal ( mem_ctx , out_output_buffer - > data ) ;
tevent_req_received ( req ) ;
return NT_STATUS_OK ;
}