1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-06 13:18:07 +03:00
samba-mirror/source4/dns_server/dns_update.c

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

891 lines
22 KiB
C
Raw Normal View History

/*
Unix SMB/CIFS implementation.
DNS server handler for update requests
Copyright (C) 2010 Kai Blin <kai@samba.org>
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#include "includes.h"
#include "libcli/util/ntstatus.h"
#include "librpc/ndr/libndr.h"
#include "librpc/gen_ndr/ndr_dns.h"
#include "librpc/gen_ndr/ndr_dnsp.h"
#include <ldb.h>
#include "param/param.h"
#include "param/loadparm.h"
#include "dsdb/samdb/samdb.h"
#include "dsdb/common/util.h"
#include "samba/service_task.h"
#include "dns_server/dns_server.h"
#include "auth/auth.h"
#undef DBGC_CLASS
#define DBGC_CLASS DBGC_DNS
static WERROR dns_rr_to_dnsp(TALLOC_CTX *mem_ctx,
const struct dns_res_rec *rrec,
struct dnsp_DnssrvRpcRecord *r,
bool name_is_static);
static WERROR check_one_prerequisite(struct dns_server *dns,
TALLOC_CTX *mem_ctx,
const struct dns_name_question *zone,
const struct dns_res_rec *pr,
bool *final_result)
{
bool match;
WERROR werror;
struct ldb_dn *dn;
uint16_t i;
bool found = false;
struct dnsp_DnssrvRpcRecord *rec = NULL;
struct dnsp_DnssrvRpcRecord *ans;
uint16_t a_count;
size_t host_part_len = 0;
*final_result = true;
if (pr->ttl != 0) {
return DNS_ERR(FORMAT_ERROR);
}
match = dns_name_match(zone->name, pr->name, &host_part_len);
if (!match) {
return DNS_ERR(NOTZONE);
}
werror = dns_name2dn(dns, mem_ctx, pr->name, &dn);
W_ERROR_NOT_OK_RETURN(werror);
if (pr->rr_class == DNS_QCLASS_ANY) {
if (pr->length != 0) {
return DNS_ERR(FORMAT_ERROR);
}
if (pr->rr_type == DNS_QTYPE_ALL) {
/*
*/
werror = dns_lookup_records(dns, mem_ctx, dn, &ans, &a_count);
if (W_ERROR_EQUAL(werror, WERR_DNS_ERROR_NAME_DOES_NOT_EXIST)) {
return DNS_ERR(NAME_ERROR);
}
W_ERROR_NOT_OK_RETURN(werror);
if (a_count == 0) {
return DNS_ERR(NAME_ERROR);
}
} else {
/*
*/
werror = dns_lookup_records(dns, mem_ctx, dn, &ans, &a_count);
if (W_ERROR_EQUAL(werror, WERR_DNS_ERROR_NAME_DOES_NOT_EXIST)) {
return DNS_ERR(NXRRSET);
}
if (W_ERROR_EQUAL(werror, DNS_ERR(NAME_ERROR))) {
return DNS_ERR(NXRRSET);
}
W_ERROR_NOT_OK_RETURN(werror);
for (i = 0; i < a_count; i++) {
if (ans[i].wType == (enum dns_record_type) pr->rr_type) {
found = true;
break;
}
}
if (!found) {
return DNS_ERR(NXRRSET);
}
}
/*
* RFC2136 3.2.5 doesn't actually mention the need to return
* OK here, but otherwise we'd always return a FORMAT_ERROR
* later on. This also matches Microsoft DNS behavior.
*/
return WERR_OK;
}
if (pr->rr_class == DNS_QCLASS_NONE) {
if (pr->length != 0) {
return DNS_ERR(FORMAT_ERROR);
}
if (pr->rr_type == DNS_QTYPE_ALL) {
/*
*/
werror = dns_lookup_records(dns, mem_ctx, dn, &ans, &a_count);
if (W_ERROR_EQUAL(werror, WERR_OK)) {
return DNS_ERR(YXDOMAIN);
}
} else {
/*
*/
werror = dns_lookup_records(dns, mem_ctx, dn, &ans, &a_count);
if (W_ERROR_EQUAL(werror, WERR_DNS_ERROR_NAME_DOES_NOT_EXIST)) {
werror = WERR_OK;
}
if (W_ERROR_EQUAL(werror, DNS_ERR(NAME_ERROR))) {
werror = WERR_OK;
}
for (i = 0; i < a_count; i++) {
if (ans[i].wType == (enum dns_record_type) pr->rr_type) {
found = true;
break;
}
}
if (found) {
return DNS_ERR(YXRRSET);
}
}
/*
* RFC2136 3.2.5 doesn't actually mention the need to return
* OK here, but otherwise we'd always return a FORMAT_ERROR
* later on. This also matches Microsoft DNS behavior.
*/
return WERR_OK;
}
if (pr->rr_class != zone->question_class) {
return DNS_ERR(FORMAT_ERROR);
}
*final_result = false;
werror = dns_lookup_records(dns, mem_ctx, dn, &ans, &a_count);
if (W_ERROR_EQUAL(werror, WERR_DNS_ERROR_NAME_DOES_NOT_EXIST)) {
return DNS_ERR(NXRRSET);
}
if (W_ERROR_EQUAL(werror, DNS_ERR(NAME_ERROR))) {
return DNS_ERR(NXRRSET);
}
W_ERROR_NOT_OK_RETURN(werror);
rec = talloc_zero(mem_ctx, struct dnsp_DnssrvRpcRecord);
W_ERROR_HAVE_NO_MEMORY(rec);
werror = dns_rr_to_dnsp(rec, pr, rec, dns_name_is_static(ans, a_count));
W_ERROR_NOT_OK_RETURN(werror);
for (i = 0; i < a_count; i++) {
if (dns_record_match(rec, &ans[i])) {
found = true;
break;
}
}
if (!found) {
return DNS_ERR(NXRRSET);
}
return WERR_OK;
}
static WERROR check_prerequisites(struct dns_server *dns,
TALLOC_CTX *mem_ctx,
const struct dns_name_question *zone,
const struct dns_res_rec *prereqs, uint16_t count)
{
uint16_t i;
WERROR final_error = WERR_OK;
for (i = 0; i < count; i++) {
bool final;
WERROR werror;
werror = check_one_prerequisite(dns, mem_ctx, zone,
&prereqs[i], &final);
if (!W_ERROR_IS_OK(werror)) {
if (final) {
return werror;
}
if (W_ERROR_IS_OK(final_error)) {
final_error = werror;
}
}
}
if (!W_ERROR_IS_OK(final_error)) {
return final_error;
}
return WERR_OK;
}
2010-10-12 01:39:44 +04:00
static WERROR update_prescan(const struct dns_name_question *zone,
const struct dns_res_rec *updates, uint16_t count)
{
const struct dns_res_rec *r;
uint16_t i;
size_t host_part_len;
bool match;
for (i = 0; i < count; i++) {
r = &updates[i];
match = dns_name_match(zone->name, r->name, &host_part_len);
if (!match) {
return DNS_ERR(NOTZONE);
}
if (zone->question_class == r->rr_class) {
if (r->rr_type == DNS_QTYPE_ALL) {
return DNS_ERR(FORMAT_ERROR);
}
if (r->rr_type == DNS_QTYPE_AXFR) {
return DNS_ERR(FORMAT_ERROR);
}
if (r->rr_type == DNS_QTYPE_MAILB) {
return DNS_ERR(FORMAT_ERROR);
}
if (r->rr_type == DNS_QTYPE_MAILA) {
return DNS_ERR(FORMAT_ERROR);
}
} else if (r->rr_class == DNS_QCLASS_ANY) {
if (r->ttl != 0) {
return DNS_ERR(FORMAT_ERROR);
}
if (r->length != 0) {
return DNS_ERR(FORMAT_ERROR);
}
if (r->rr_type == DNS_QTYPE_AXFR) {
return DNS_ERR(FORMAT_ERROR);
}
if (r->rr_type == DNS_QTYPE_MAILB) {
return DNS_ERR(FORMAT_ERROR);
}
if (r->rr_type == DNS_QTYPE_MAILA) {
return DNS_ERR(FORMAT_ERROR);
}
} else if (r->rr_class == DNS_QCLASS_NONE) {
if (r->ttl != 0) {
return DNS_ERR(FORMAT_ERROR);
}
if (r->rr_type == DNS_QTYPE_ALL) {
return DNS_ERR(FORMAT_ERROR);
}
if (r->rr_type == DNS_QTYPE_AXFR) {
return DNS_ERR(FORMAT_ERROR);
}
if (r->rr_type == DNS_QTYPE_MAILB) {
return DNS_ERR(FORMAT_ERROR);
}
if (r->rr_type == DNS_QTYPE_MAILA) {
return DNS_ERR(FORMAT_ERROR);
}
} else {
return DNS_ERR(FORMAT_ERROR);
}
}
return WERR_OK;
}
static WERROR dns_rr_to_dnsp(TALLOC_CTX *mem_ctx,
const struct dns_res_rec *rrec,
struct dnsp_DnssrvRpcRecord *r,
bool name_is_static)
{
enum ndr_err_code ndr_err;
2012-03-11 02:48:44 +04:00
if (rrec->rr_type == DNS_QTYPE_ALL) {
return DNS_ERR(FORMAT_ERROR);
}
ZERO_STRUCTP(r);
r->wType = (enum dns_record_type) rrec->rr_type;
r->dwTtlSeconds = rrec->ttl;
r->rank = DNS_RANK_ZONE;
if (name_is_static) {
r->dwTimeStamp = 0;
} else {
r->dwTimeStamp = unix_to_dns_timestamp(time(NULL));
}
/* If we get QCLASS_ANY, we're done here */
if (rrec->rr_class == DNS_QCLASS_ANY) {
goto done;
}
switch(rrec->rr_type) {
case DNS_QTYPE_A:
r->data.ipv4 = talloc_strdup(mem_ctx, rrec->rdata.ipv4_record);
W_ERROR_HAVE_NO_MEMORY(r->data.ipv4);
break;
case DNS_QTYPE_AAAA:
r->data.ipv6 = talloc_strdup(mem_ctx, rrec->rdata.ipv6_record);
W_ERROR_HAVE_NO_MEMORY(r->data.ipv6);
break;
case DNS_QTYPE_NS:
r->data.ns = talloc_strdup(mem_ctx, rrec->rdata.ns_record);
W_ERROR_HAVE_NO_MEMORY(r->data.ns);
break;
case DNS_QTYPE_CNAME:
r->data.cname = talloc_strdup(mem_ctx, rrec->rdata.cname_record);
W_ERROR_HAVE_NO_MEMORY(r->data.cname);
break;
case DNS_QTYPE_SRV:
r->data.srv.wPriority = rrec->rdata.srv_record.priority;
r->data.srv.wWeight = rrec->rdata.srv_record.weight;
r->data.srv.wPort = rrec->rdata.srv_record.port;
r->data.srv.nameTarget = talloc_strdup(mem_ctx,
rrec->rdata.srv_record.target);
W_ERROR_HAVE_NO_MEMORY(r->data.srv.nameTarget);
break;
case DNS_QTYPE_PTR:
r->data.ptr = talloc_strdup(mem_ctx, rrec->rdata.ptr_record);
W_ERROR_HAVE_NO_MEMORY(r->data.ptr);
break;
case DNS_QTYPE_MX:
r->data.mx.wPriority = rrec->rdata.mx_record.preference;
r->data.mx.nameTarget = talloc_strdup(mem_ctx,
rrec->rdata.mx_record.exchange);
W_ERROR_HAVE_NO_MEMORY(r->data.mx.nameTarget);
break;
case DNS_QTYPE_TXT:
ndr_err = ndr_dnsp_string_list_copy(mem_ctx,
&rrec->rdata.txt_record.txt,
&r->data.txt);
if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
return WERR_NOT_ENOUGH_MEMORY;
2012-03-11 02:48:44 +04:00
}
break;
default:
DEBUG(0, ("Got a qytpe of %d\n", rrec->rr_type));
return DNS_ERR(NOT_IMPLEMENTED);
}
done:
return WERR_OK;
}
static WERROR handle_one_update(struct dns_server *dns,
TALLOC_CTX *mem_ctx,
const struct dns_name_question *zone,
const struct dns_res_rec *update,
const struct dns_server_tkey *tkey)
{
struct dnsp_DnssrvRpcRecord *recs = NULL;
uint16_t rcount = 0;
struct ldb_dn *dn;
uint16_t i;
uint16_t first = 0;
WERROR werror;
bool tombstoned = false;
bool needs_add = false;
bool name_is_static;
DBG_NOTICE("Looking at record: \n");
if (DEBUGLVL(DBGLVL_NOTICE)) {
2012-03-11 03:25:05 +04:00
NDR_PRINT_DEBUG(dns_res_rec, discard_const(update));
}
switch (update->rr_type) {
case DNS_QTYPE_A:
case DNS_QTYPE_NS:
case DNS_QTYPE_CNAME:
case DNS_QTYPE_SOA:
case DNS_QTYPE_PTR:
case DNS_QTYPE_MX:
case DNS_QTYPE_AAAA:
case DNS_QTYPE_SRV:
case DNS_QTYPE_TXT:
case DNS_QTYPE_ALL:
break;
default:
2012-03-11 02:48:44 +04:00
DEBUG(0, ("Can't handle updates of type %u yet\n",
update->rr_type));
return DNS_ERR(NOT_IMPLEMENTED);
}
werror = dns_name2dn(dns, mem_ctx, update->name, &dn);
DBG_DEBUG("dns_name2dn(): %s\n", win_errstr(werror));
W_ERROR_NOT_OK_RETURN(werror);
werror = dns_common_lookup(dns->samdb, mem_ctx, dn,
&recs, &rcount, &tombstoned);
DBG_DEBUG("dns_common_lookup(): %s\n", win_errstr(werror));
if (W_ERROR_EQUAL(werror, WERR_DNS_ERROR_NAME_DOES_NOT_EXIST)) {
needs_add = true;
werror = WERR_OK;
}
W_ERROR_NOT_OK_RETURN(werror);
if (tombstoned) {
/*
* we need to keep the existing tombstone record
* and ignore it.
*
* There *should* only be a single record of type TOMBSTONE,
* but we don't insist.
*/
if (rcount != 1) {
DBG_WARNING("Tombstoned dnsNode has %u records, "
"expected 1\n", rcount);
if (DEBUGLVL(DBGLVL_WARNING)) {
NDR_PRINT_DEBUG(dns_res_rec, discard_const(update));
}
}
first = rcount;
}
name_is_static = dns_name_is_static(recs, rcount);
if (update->rr_class == zone->question_class) {
if (update->rr_type == DNS_QTYPE_CNAME) {
/*
* If there is a record in the directory
* that's not a CNAME, ignore update
*/
for (i = first; i < rcount; i++) {
if (recs[i].wType != DNS_TYPE_CNAME) {
DEBUG(5, ("Skipping update\n"));
return WERR_OK;
}
}
/*
* There should be no entries besides one CNAME record
* per name, so replace everything with the new CNAME
*/
rcount = first;
recs = talloc_realloc(mem_ctx, recs,
struct dnsp_DnssrvRpcRecord, rcount + 1);
W_ERROR_HAVE_NO_MEMORY(recs);
werror = dns_rr_to_dnsp(
recs, update, &recs[rcount], name_is_static);
DBG_DEBUG("dns_rr_to_dnsp(CNAME): %s\n", win_errstr(werror));
W_ERROR_NOT_OK_RETURN(werror);
rcount += 1;
werror = dns_replace_records(dns, mem_ctx, dn,
needs_add, recs, rcount);
DBG_DEBUG("dns_replace_records(CNAME): %s\n", win_errstr(werror));
W_ERROR_NOT_OK_RETURN(werror);
return WERR_OK;
} else {
/*
* If there is a CNAME record for this name,
* ignore update
*/
for (i = first; i < rcount; i++) {
if (recs[i].wType == DNS_TYPE_CNAME) {
DEBUG(5, ("Skipping update\n"));
return WERR_OK;
}
}
}
if (update->rr_type == DNS_QTYPE_SOA) {
bool found = false;
/*
* If the zone has no SOA record?? or update's
* serial number is smaller than existing SOA's,
* ignore update
*/
for (i = first; i < rcount; i++) {
if (recs[i].wType == DNS_TYPE_SOA) {
uint16_t n, o;
n = update->rdata.soa_record.serial;
o = recs[i].data.soa.serial;
/*
* TODO: Implement RFC 1982 comparison
* logic for RFC2136
*/
if (n <= o) {
DEBUG(5, ("Skipping update\n"));
return WERR_OK;
}
found = true;
break;
}
}
if (!found) {
DEBUG(5, ("Skipping update\n"));
return WERR_OK;
}
werror = dns_rr_to_dnsp(
mem_ctx, update, &recs[i], name_is_static);
DBG_DEBUG("dns_rr_to_dnsp(SOA): %s\n", win_errstr(werror));
W_ERROR_NOT_OK_RETURN(werror);
/*
* There should only be one SOA, which we have already
* found and replaced. We now check for and tombstone
* any others.
*/
for (i++; i < rcount; i++) {
if (recs[i].wType != DNS_TYPE_SOA) {
continue;
}
DBG_ERR("Duplicate SOA records found.\n");
if (DEBUGLVL(DBGLVL_ERR)) {
NDR_PRINT_DEBUG(dns_res_rec,
discard_const(update));
}
recs[i] = (struct dnsp_DnssrvRpcRecord) {
.wType = DNS_TYPE_TOMBSTONE,
};
}
werror = dns_replace_records(dns, mem_ctx, dn,
needs_add, recs, rcount);
DBG_DEBUG("dns_replace_records(SOA): %s\n", win_errstr(werror));
W_ERROR_NOT_OK_RETURN(werror);
return WERR_OK;
}
/* All but CNAME, SOA */
recs = talloc_realloc(mem_ctx, recs,
struct dnsp_DnssrvRpcRecord, rcount+1);
W_ERROR_HAVE_NO_MEMORY(recs);
werror =
dns_rr_to_dnsp(recs, update, &recs[rcount], name_is_static);
DBG_DEBUG("dns_rr_to_dnsp(GENERIC): %s\n", win_errstr(werror));
W_ERROR_NOT_OK_RETURN(werror);
for (i = first; i < rcount; i++) {
struct dnsp_DnssrvRpcRecord orig_rec = recs[i];
if (!dns_record_match(&recs[i], &recs[rcount])) {
continue;
}
recs[i].data = recs[rcount].data;
recs[i].wType = recs[rcount].wType;
recs[i].dwTtlSeconds = recs[rcount].dwTtlSeconds;
recs[i].rank = recs[rcount].rank;
recs[i].dwReserved = 0;
recs[i].flags = 0;
werror = dns_replace_records(dns, mem_ctx, dn,
needs_add, recs, rcount);
DBG_DEBUG("dns_replace_records(REPLACE): %s\n", win_errstr(werror));
if (W_ERROR_EQUAL(werror, WERR_ACCESS_DENIED) &&
!needs_add &&
orig_rec.dwTtlSeconds == recs[i].dwTtlSeconds)
{
DBG_NOTICE("dns_replace_records(REPLACE): %s "
"=> skip no-op\n",
win_errstr(werror));
werror = WERR_OK;
}
W_ERROR_NOT_OK_RETURN(werror);
return WERR_OK;
}
/* we did not find a matching record. This is new. */
werror = dns_replace_records(dns, mem_ctx, dn,
needs_add, recs, rcount+1);
DBG_DEBUG("dns_replace_records(ADD): %s\n", win_errstr(werror));
W_ERROR_NOT_OK_RETURN(werror);
return WERR_OK;
} else if (update->rr_class == DNS_QCLASS_ANY) {
/*
* Mass-deleting records by type, which we do by adding a
* tombstone with zero timestamp. dns_replace_records() will
* work out if the node as a whole needs tombstoning.
*/
if (update->rr_type == DNS_QTYPE_ALL) {
s4:dnsserver: Rename dns_name_equal() to samba_dns_name_equal() This function already exists in bind9 but takes different arguments, so when the DLZ is loaded and this function is called bind crashes: named[1523]: samba_dlz: allowing update of signer=DESKTOP-8BUKMBK\$\@AFOREST.AD name=118.101.168.192.in-addr.arpa tcpaddr=192.168.101.118 type=PTR key=1264-ms-7.1-2ac9.9ef238e1-9747-11ed-9f95-525400dc6981/159/0 named[1523]: samba_dlz: allowing update of signer=DESKTOP-8BUKMBK\$\@AFOREST.AD name=118.101.168.192.in-addr.arpa tcpaddr=192.168.101.118 type=PTR key=1264-ms-7.1-2ac9.9ef238e1-9747-11ed-9f95-525400dc6981/159/0 named[1523]: client @0x7f26caa90f68 192.168.101.118#58223/key DESKTOP-8BUKMBK\$\@AFOREST.AD: updating zone '101.168.192.in-addr.arpa/NONE': deleting rrset at '118.101.168.192.in-addr.ar named[1523]: name.c:664: REQUIRE(((name1) != ((void *)0) && ((const isc__magic_t *)(name1))->magic == ((('D') << 24 | ('N') << 16 | ('S') << 8 | ('n'))))) failed, back trace Backtrace: #0 0x00007f2716c957ec in __pthread_kill_implementation () from /lib64/libc.so.6 #1 0x00007f2716c42816 in raise () from /lib64/libc.so.6 #2 0x00007f2716c2b81c in abort () from /lib64/libc.so.6 #3 0x000055d4de847995 in assertion_failed (file=<optimized out>, line=<optimized out>, type=<optimized out>, cond=<optimized out>) at /usr/src/debug/bind-9.18.10/bin/named/main.c:237 #4 0x00007f27176388fc in isc_assertion_failed (file=file@entry=0x7f27173b0df6 "name.c", line=line@entry=664, type=type@entry=isc_assertiontype_require, cond=cond@entry=0x7f27173b0268 "((name1) != ((void *)0) && ((const isc__magic_t *)(name1))->magic == ((('D') << 24 | ('N') << 16 | ('S') << 8 | ('n'))))") at /usr/src/debug/bind-9.18.10/lib/isc/assertions.c:48 #5 0x00007f27172946f9 in dns_name_equal (name1=<optimized out>, name2=<optimized out>) at /usr/src/debug/bind-9.18.10/lib/dns/name.c:664 **** Here bind's dns_name_equal() is called instead of samba's dns_name_equal() **** #6 0x00007f27077ad6f2 in dns_record_match (rec1=0x7f26f8042d70, rec2=0x7f26f8044d10) at ../../source4/dns_server/dnsserver_common.c:1346 #7 0x00007f271404732c in b9_record_match (rec1=0x7f26f8042d70, rec2=0x7f26f8044d10) at ../../source4/dns_server/dlz_bind9.c:1830 #8 0x00007f2714047daa in dlz_subrdataset (name=0x7f2706ff82f0 "118.101.168.192.in-addr.arpa", rdatastr=0x7f26c9c10000 "118.101.168.192.in-addr.arpa.\t1200\tIN\tPTR\tDESKTOP-8BUKMBK.aforest.ad.", dbdata=0x7f271003d300, version=0x7f26f8044b20) at ../../source4/dns_server/dlz_bind9.c:2077 #9 0x000055d4de84afb4 in dlopen_dlz_subrdataset (name=0x7f2706ff82f0 "118.101.168.192.in-addr.arpa", rdatastr=<optimized out>, driverarg=<optimized out>, dbdata=0x7f270430f680, version=<optimized out>) at /usr/src/debug/bind-9.18.10/bin/named/dlz_dlopen_driver.c:483 #10 0x00007f271738e734 in modrdataset.constprop.0 (db=0x7f2704291740, node=0x7f26c9c006e0, version=0x7f26f8044b20, rdataset=0x7f2706ff8830, mod_function=0x55d4de84af80 <dlopen_dlz_subrdataset>, options=<optimized out>) at /usr/src/debug/bind-9.18.10/lib/dns/sdlz.c:1107 #11 0x00007f2717251855 in diff_apply (diff=diff@entry=0x7f2706ff8df0, db=db@entry=0x7f2704291740, ver=ver@entry=0x7f26f8044b20, warn=warn@entry=true) at /usr/src/debug/bind-9.18.10/lib/dns/diff.c:370 #12 0x00007f2717251c8a in dns_diff_apply (diff=diff@entry=0x7f2706ff8df0, db=db@entry=0x7f2704291740, ver=ver@entry=0x7f26f8044b20) at /usr/src/debug/bind-9.18.10/lib/dns/diff.c:465 #13 0x00007f2717d105aa in do_one_tuple (tuple=tuple@entry=0x7f2706ff8e50, db=db@entry=0x7f2704291740, ver=ver@entry=0x7f26f8044b20, diff=diff@entry=0x7f2706ff9400) at /usr/src/debug/bind-9.18.10/lib/ns/update.c:454 #14 0x00007f2717d10fff in update_one_rr (rdata=0x7f2706ff8ee8, ttl=<optimized out>, name=<optimized out>, op=DNS_DIFFOP_DEL, diff=0x7f2706ff9400, ver=0x7f26f8044b20, db=0x7f2704291740) at /usr/src/debug/bind-9.18.10/lib/ns/update.c:505 #15 delete_if_action (data=<optimized out>, rr=0x7f2706ff8ee0) at /usr/src/debug/bind-9.18.10/lib/ns/update.c:1427 #16 0x00007f2717d10ccd in foreach_rr (db=0x7f2704291740, ver=<optimized out>, name=0x7f26caa61d00, type=<optimized out>, covers=<optimized out>, rr_action=rr_action@entry=0x7f2717d10f60 <delete_if_action>, rr_action_data=0x7f2706ff9280) at /usr/src/debug/bind-9.18.10/lib/ns/update.c:736 #17 0x00007f2717d10e76 in delete_if (predicate=predicate@entry=0x7f2717d0fb10 <true_p>, db=<optimized out>, ver=<optimized out>, name=<optimized out>, type=<optimized out>, covers=<optimized out>, update_rr=0x7f2706ff94b0, diff=0x7f2706ff9400) at /usr/src/debug/bind-9.18.10/lib/ns/update.c:1454 #18 0x00007f2717d1bccd in update_action (task=<optimized out>, event=<optimized out>) at /usr/src/debug/bind-9.18.10/lib/ns/update.c:3299 #19 0x00007f271765eb4c in task_run (task=0x7f27155ccf00) at /usr/src/debug/bind-9.18.10/lib/isc/task.c:823 #20 isc_task_run (task=0x7f27155ccf00) at /usr/src/debug/bind-9.18.10/lib/isc/task.c:904 #21 0x00007f271762cb12 in isc__nm_async_task (worker=0x7f2716236560, ev0=0x7f26caa07000) at netmgr/netmgr.c:840 #22 process_netievent (worker=worker@entry=0x7f2716236560, ievent=0x7f26caa07000) at netmgr/netmgr.c:918 #23 0x00007f271762d197 in process_queue (worker=worker@entry=0x7f2716236560, type=type@entry=NETIEVENT_TASK) at netmgr/netmgr.c:1011 #24 0x00007f271762d3b3 in process_all_queues (worker=0x7f2716236560) at netmgr/netmgr.c:765 #25 async_cb (handle=0x7f27162368c0) at netmgr/netmgr.c:794 #26 0x00007f2717c4cb0d in uv__async_io (loop=0x7f2716236570, w=<optimized out>, events=<optimized out>) at src/unix/async.c:163 #27 0x00007f2717c6825d in uv__io_poll (loop=0x7f2716236570, timeout=<optimized out>) at src/unix/epoll.c:374 #28 0x00007f2717c5247a in uv__io_poll (timeout=<optimized out>, loop=0x7f2716236570) at src/unix/udp.c:122 #29 uv_run (loop=loop@entry=0x7f2716236570, mode=mode@entry=UV_RUN_DEFAULT) at src/unix/core.c:406 #30 0x00007f271762d834 in nm_thread (worker0=0x7f2716236560) at netmgr/netmgr.c:696 #31 0x00007f27176627f5 in isc__trampoline_run (arg=0x55d4dfe3ad70) at /usr/src/debug/bind-9.18.10/lib/isc/trampoline.c:189 #32 0x00007f2716c9398d in start_thread () from /lib64/libc.so.6 #33 0x00007f2716d19344 in clone () from /lib64/libc.so.6 BUG: https://bugzilla.samba.org/show_bug.cgi?id=14030 Signed-off-by: Samuel Cabrero <scabrero@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Autobuild-User(master): Samuel Cabrero <scabrero@samba.org> Autobuild-Date(master): Thu Jan 19 10:20:27 UTC 2023 on atb-devel-224
2023-01-18 19:25:29 +03:00
if (samba_dns_name_equal(update->name, zone->name)) {
for (i = first; i < rcount; i++) {
if (recs[i].wType == DNS_TYPE_SOA) {
continue;
}
if (recs[i].wType == DNS_TYPE_NS) {
continue;
}
recs[i] = (struct dnsp_DnssrvRpcRecord) {
.wType = DNS_TYPE_TOMBSTONE,
};
}
} else {
for (i = first; i < rcount; i++) {
recs[i] = (struct dnsp_DnssrvRpcRecord) {
.wType = DNS_TYPE_TOMBSTONE,
};
}
}
s4:dnsserver: Rename dns_name_equal() to samba_dns_name_equal() This function already exists in bind9 but takes different arguments, so when the DLZ is loaded and this function is called bind crashes: named[1523]: samba_dlz: allowing update of signer=DESKTOP-8BUKMBK\$\@AFOREST.AD name=118.101.168.192.in-addr.arpa tcpaddr=192.168.101.118 type=PTR key=1264-ms-7.1-2ac9.9ef238e1-9747-11ed-9f95-525400dc6981/159/0 named[1523]: samba_dlz: allowing update of signer=DESKTOP-8BUKMBK\$\@AFOREST.AD name=118.101.168.192.in-addr.arpa tcpaddr=192.168.101.118 type=PTR key=1264-ms-7.1-2ac9.9ef238e1-9747-11ed-9f95-525400dc6981/159/0 named[1523]: client @0x7f26caa90f68 192.168.101.118#58223/key DESKTOP-8BUKMBK\$\@AFOREST.AD: updating zone '101.168.192.in-addr.arpa/NONE': deleting rrset at '118.101.168.192.in-addr.ar named[1523]: name.c:664: REQUIRE(((name1) != ((void *)0) && ((const isc__magic_t *)(name1))->magic == ((('D') << 24 | ('N') << 16 | ('S') << 8 | ('n'))))) failed, back trace Backtrace: #0 0x00007f2716c957ec in __pthread_kill_implementation () from /lib64/libc.so.6 #1 0x00007f2716c42816 in raise () from /lib64/libc.so.6 #2 0x00007f2716c2b81c in abort () from /lib64/libc.so.6 #3 0x000055d4de847995 in assertion_failed (file=<optimized out>, line=<optimized out>, type=<optimized out>, cond=<optimized out>) at /usr/src/debug/bind-9.18.10/bin/named/main.c:237 #4 0x00007f27176388fc in isc_assertion_failed (file=file@entry=0x7f27173b0df6 "name.c", line=line@entry=664, type=type@entry=isc_assertiontype_require, cond=cond@entry=0x7f27173b0268 "((name1) != ((void *)0) && ((const isc__magic_t *)(name1))->magic == ((('D') << 24 | ('N') << 16 | ('S') << 8 | ('n'))))") at /usr/src/debug/bind-9.18.10/lib/isc/assertions.c:48 #5 0x00007f27172946f9 in dns_name_equal (name1=<optimized out>, name2=<optimized out>) at /usr/src/debug/bind-9.18.10/lib/dns/name.c:664 **** Here bind's dns_name_equal() is called instead of samba's dns_name_equal() **** #6 0x00007f27077ad6f2 in dns_record_match (rec1=0x7f26f8042d70, rec2=0x7f26f8044d10) at ../../source4/dns_server/dnsserver_common.c:1346 #7 0x00007f271404732c in b9_record_match (rec1=0x7f26f8042d70, rec2=0x7f26f8044d10) at ../../source4/dns_server/dlz_bind9.c:1830 #8 0x00007f2714047daa in dlz_subrdataset (name=0x7f2706ff82f0 "118.101.168.192.in-addr.arpa", rdatastr=0x7f26c9c10000 "118.101.168.192.in-addr.arpa.\t1200\tIN\tPTR\tDESKTOP-8BUKMBK.aforest.ad.", dbdata=0x7f271003d300, version=0x7f26f8044b20) at ../../source4/dns_server/dlz_bind9.c:2077 #9 0x000055d4de84afb4 in dlopen_dlz_subrdataset (name=0x7f2706ff82f0 "118.101.168.192.in-addr.arpa", rdatastr=<optimized out>, driverarg=<optimized out>, dbdata=0x7f270430f680, version=<optimized out>) at /usr/src/debug/bind-9.18.10/bin/named/dlz_dlopen_driver.c:483 #10 0x00007f271738e734 in modrdataset.constprop.0 (db=0x7f2704291740, node=0x7f26c9c006e0, version=0x7f26f8044b20, rdataset=0x7f2706ff8830, mod_function=0x55d4de84af80 <dlopen_dlz_subrdataset>, options=<optimized out>) at /usr/src/debug/bind-9.18.10/lib/dns/sdlz.c:1107 #11 0x00007f2717251855 in diff_apply (diff=diff@entry=0x7f2706ff8df0, db=db@entry=0x7f2704291740, ver=ver@entry=0x7f26f8044b20, warn=warn@entry=true) at /usr/src/debug/bind-9.18.10/lib/dns/diff.c:370 #12 0x00007f2717251c8a in dns_diff_apply (diff=diff@entry=0x7f2706ff8df0, db=db@entry=0x7f2704291740, ver=ver@entry=0x7f26f8044b20) at /usr/src/debug/bind-9.18.10/lib/dns/diff.c:465 #13 0x00007f2717d105aa in do_one_tuple (tuple=tuple@entry=0x7f2706ff8e50, db=db@entry=0x7f2704291740, ver=ver@entry=0x7f26f8044b20, diff=diff@entry=0x7f2706ff9400) at /usr/src/debug/bind-9.18.10/lib/ns/update.c:454 #14 0x00007f2717d10fff in update_one_rr (rdata=0x7f2706ff8ee8, ttl=<optimized out>, name=<optimized out>, op=DNS_DIFFOP_DEL, diff=0x7f2706ff9400, ver=0x7f26f8044b20, db=0x7f2704291740) at /usr/src/debug/bind-9.18.10/lib/ns/update.c:505 #15 delete_if_action (data=<optimized out>, rr=0x7f2706ff8ee0) at /usr/src/debug/bind-9.18.10/lib/ns/update.c:1427 #16 0x00007f2717d10ccd in foreach_rr (db=0x7f2704291740, ver=<optimized out>, name=0x7f26caa61d00, type=<optimized out>, covers=<optimized out>, rr_action=rr_action@entry=0x7f2717d10f60 <delete_if_action>, rr_action_data=0x7f2706ff9280) at /usr/src/debug/bind-9.18.10/lib/ns/update.c:736 #17 0x00007f2717d10e76 in delete_if (predicate=predicate@entry=0x7f2717d0fb10 <true_p>, db=<optimized out>, ver=<optimized out>, name=<optimized out>, type=<optimized out>, covers=<optimized out>, update_rr=0x7f2706ff94b0, diff=0x7f2706ff9400) at /usr/src/debug/bind-9.18.10/lib/ns/update.c:1454 #18 0x00007f2717d1bccd in update_action (task=<optimized out>, event=<optimized out>) at /usr/src/debug/bind-9.18.10/lib/ns/update.c:3299 #19 0x00007f271765eb4c in task_run (task=0x7f27155ccf00) at /usr/src/debug/bind-9.18.10/lib/isc/task.c:823 #20 isc_task_run (task=0x7f27155ccf00) at /usr/src/debug/bind-9.18.10/lib/isc/task.c:904 #21 0x00007f271762cb12 in isc__nm_async_task (worker=0x7f2716236560, ev0=0x7f26caa07000) at netmgr/netmgr.c:840 #22 process_netievent (worker=worker@entry=0x7f2716236560, ievent=0x7f26caa07000) at netmgr/netmgr.c:918 #23 0x00007f271762d197 in process_queue (worker=worker@entry=0x7f2716236560, type=type@entry=NETIEVENT_TASK) at netmgr/netmgr.c:1011 #24 0x00007f271762d3b3 in process_all_queues (worker=0x7f2716236560) at netmgr/netmgr.c:765 #25 async_cb (handle=0x7f27162368c0) at netmgr/netmgr.c:794 #26 0x00007f2717c4cb0d in uv__async_io (loop=0x7f2716236570, w=<optimized out>, events=<optimized out>) at src/unix/async.c:163 #27 0x00007f2717c6825d in uv__io_poll (loop=0x7f2716236570, timeout=<optimized out>) at src/unix/epoll.c:374 #28 0x00007f2717c5247a in uv__io_poll (timeout=<optimized out>, loop=0x7f2716236570) at src/unix/udp.c:122 #29 uv_run (loop=loop@entry=0x7f2716236570, mode=mode@entry=UV_RUN_DEFAULT) at src/unix/core.c:406 #30 0x00007f271762d834 in nm_thread (worker0=0x7f2716236560) at netmgr/netmgr.c:696 #31 0x00007f27176627f5 in isc__trampoline_run (arg=0x55d4dfe3ad70) at /usr/src/debug/bind-9.18.10/lib/isc/trampoline.c:189 #32 0x00007f2716c9398d in start_thread () from /lib64/libc.so.6 #33 0x00007f2716d19344 in clone () from /lib64/libc.so.6 BUG: https://bugzilla.samba.org/show_bug.cgi?id=14030 Signed-off-by: Samuel Cabrero <scabrero@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Autobuild-User(master): Samuel Cabrero <scabrero@samba.org> Autobuild-Date(master): Thu Jan 19 10:20:27 UTC 2023 on atb-devel-224
2023-01-18 19:25:29 +03:00
} else if (samba_dns_name_equal(update->name, zone->name)) {
if (update->rr_type == DNS_QTYPE_SOA) {
return WERR_OK;
}
if (update->rr_type == DNS_QTYPE_NS) {
return WERR_OK;
}
}
for (i = first; i < rcount; i++) {
if (recs[i].wType == (enum dns_record_type) update->rr_type) {
recs[i] = (struct dnsp_DnssrvRpcRecord) {
.wType = DNS_TYPE_TOMBSTONE,
};
}
}
werror = dns_replace_records(dns, mem_ctx, dn,
needs_add, recs, rcount);
DBG_DEBUG("dns_replace_records(DELETE-ANY): %s\n", win_errstr(werror));
W_ERROR_NOT_OK_RETURN(werror);
return WERR_OK;
} else if (update->rr_class == DNS_QCLASS_NONE) {
/* deleting individual records */
struct dnsp_DnssrvRpcRecord *del_rec;
if (update->rr_type == DNS_QTYPE_SOA) {
return WERR_OK;
}
if (update->rr_type == DNS_QTYPE_NS) {
bool found = false;
struct dnsp_DnssrvRpcRecord *ns_rec = talloc(mem_ctx,
struct dnsp_DnssrvRpcRecord);
W_ERROR_HAVE_NO_MEMORY(ns_rec);
werror = dns_rr_to_dnsp(
ns_rec, update, ns_rec, name_is_static);
DBG_DEBUG("dns_rr_to_dnsp(NS): %s\n", win_errstr(werror));
W_ERROR_NOT_OK_RETURN(werror);
for (i = first; i < rcount; i++) {
if (dns_record_match(ns_rec, &recs[i])) {
found = true;
break;
}
}
if (found) {
return WERR_OK;
}
}
del_rec = talloc(mem_ctx, struct dnsp_DnssrvRpcRecord);
W_ERROR_HAVE_NO_MEMORY(del_rec);
werror =
dns_rr_to_dnsp(del_rec, update, del_rec, name_is_static);
DBG_DEBUG("dns_rr_to_dnsp(DELETE-NONE): %s\n", win_errstr(werror));
W_ERROR_NOT_OK_RETURN(werror);
for (i = first; i < rcount; i++) {
if (dns_record_match(del_rec, &recs[i])) {
recs[i] = (struct dnsp_DnssrvRpcRecord) {
.wType = DNS_TYPE_TOMBSTONE,
};
}
}
werror = dns_replace_records(dns, mem_ctx, dn,
needs_add, recs, rcount);
DBG_DEBUG("dns_replace_records(DELETE-NONE): %s\n", win_errstr(werror));
W_ERROR_NOT_OK_RETURN(werror);
}
return WERR_OK;
}
static WERROR handle_updates(struct dns_server *dns,
TALLOC_CTX *mem_ctx,
const struct dns_name_question *zone,
const struct dns_res_rec *prereqs, uint16_t pcount,
struct dns_res_rec *updates, uint16_t upd_count,
struct dns_server_tkey *tkey)
{
struct ldb_dn *zone_dn = NULL;
WERROR werror = WERR_OK;
int ret;
uint16_t ri;
TALLOC_CTX *tmp_ctx = talloc_new(mem_ctx);
if (tkey != NULL) {
ret = ldb_set_opaque(
dns->samdb,
DSDB_SESSION_INFO,
tkey->session_info);
if (ret != LDB_SUCCESS) {
DEBUG(1, ("unable to set session info\n"));
werror = DNS_ERR(SERVER_FAILURE);
goto failed;
}
}
werror = dns_name2dn(dns, tmp_ctx, zone->name, &zone_dn);
DBG_DEBUG("dns_name2dn(): %s\n", win_errstr(werror));
W_ERROR_NOT_OK_GOTO(werror, failed);
ret = ldb_transaction_start(dns->samdb);
if (ret != LDB_SUCCESS) {
werror = DNS_ERR(SERVER_FAILURE);
goto failed;
}
werror = check_prerequisites(dns, tmp_ctx, zone, prereqs, pcount);
W_ERROR_NOT_OK_GOTO(werror, failed);
DBG_DEBUG("dns update count is %u\n", upd_count);
for (ri = 0; ri < upd_count; ri++) {
werror = handle_one_update(dns, tmp_ctx, zone,
&updates[ri], tkey);
DBG_DEBUG("handle_one_update(%u): %s\n",
ri, win_errstr(werror));
W_ERROR_NOT_OK_GOTO(werror, failed);
}
failed:
if (W_ERROR_IS_OK(werror)) {
ret = ldb_transaction_commit(dns->samdb);
if (ret != LDB_SUCCESS) {
werror = DNS_ERR(SERVER_FAILURE);
}
} else {
ldb_transaction_cancel(dns->samdb);
}
if (tkey != NULL) {
ldb_set_opaque(
dns->samdb,
DSDB_SESSION_INFO,
system_session(dns->task->lp_ctx));
}
TALLOC_FREE(tmp_ctx);
return werror;
}
static WERROR dns_update_allowed(struct dns_server *dns,
const struct dns_request_state *state,
struct dns_server_tkey **tkey)
{
if (lpcfg_allow_dns_updates(dns->task->lp_ctx) == DNS_UPDATE_ON) {
DEBUG(2, ("All updates allowed.\n"));
return WERR_OK;
}
if (lpcfg_allow_dns_updates(dns->task->lp_ctx) == DNS_UPDATE_OFF) {
DEBUG(2, ("Updates disabled.\n"));
return DNS_ERR(REFUSED);
}
if (state->authenticated == false ) {
DEBUG(2, ("Update not allowed for unsigned packet.\n"));
return DNS_ERR(REFUSED);
}
*tkey = dns_find_tkey(dns->tkeys, state->key_name);
if (*tkey == NULL) {
DEBUG(0, ("Authenticated, but key not found. Something is wrong.\n"));
return DNS_ERR(REFUSED);
}
return WERR_OK;
}
2010-10-12 01:39:44 +04:00
WERROR dns_server_process_update(struct dns_server *dns,
const struct dns_request_state *state,
2010-10-12 01:39:44 +04:00
TALLOC_CTX *mem_ctx,
const struct dns_name_packet *in,
struct dns_res_rec **prereqs, uint16_t *prereq_count,
struct dns_res_rec **updates, uint16_t *update_count,
struct dns_res_rec **additional, uint16_t *arcount)
{
struct dns_name_question *zone;
const struct dns_server_zone *z;
size_t host_part_len = 0;
WERROR werror = DNS_ERR(NOT_IMPLEMENTED);
struct dns_server_tkey *tkey = NULL;
if (in->qdcount != 1) {
2010-10-12 01:39:44 +04:00
return DNS_ERR(FORMAT_ERROR);
}
zone = &in->questions[0];
if (zone->question_class != DNS_QCLASS_IN &&
zone->question_class != DNS_QCLASS_ANY) {
return DNS_ERR(NOT_IMPLEMENTED);
}
if (zone->question_type != DNS_QTYPE_SOA) {
2010-10-12 01:39:44 +04:00
return DNS_ERR(FORMAT_ERROR);
}
2012-03-11 03:25:05 +04:00
DEBUG(2, ("Got a dns update request.\n"));
for (z = dns->zones; z != NULL; z = z->next) {
bool match;
match = dns_name_match(z->name, zone->name, &host_part_len);
if (match) {
break;
}
}
if (z == NULL) {
DEBUG(1, ("We're not authoritative for this zone\n"));
2010-10-12 01:39:44 +04:00
return DNS_ERR(NOTAUTH);
}
if (host_part_len != 0) {
/* TODO: We need to delegate this one */
DEBUG(1, ("Would have to delegate zone '%s'.\n", zone->name));
2010-10-12 01:39:44 +04:00
return DNS_ERR(NOT_IMPLEMENTED);
}
*prereq_count = in->ancount;
*prereqs = in->answers;
werror = check_prerequisites(dns, mem_ctx, in->questions, *prereqs,
*prereq_count);
W_ERROR_NOT_OK_RETURN(werror);
werror = dns_update_allowed(dns, state, &tkey);
if (!W_ERROR_IS_OK(werror)) {
return werror;
}
*update_count = in->nscount;
*updates = in->nsrecs;
werror = update_prescan(in->questions, *updates, *update_count);
DBG_DEBUG("update_prescan(): %s\n", win_errstr(werror));
W_ERROR_NOT_OK_RETURN(werror);
werror = handle_updates(dns, mem_ctx, in->questions, *prereqs,
*prereq_count, *updates, *update_count, tkey);
DBG_DEBUG("handle_updates(): %s\n", win_errstr(werror));
W_ERROR_NOT_OK_RETURN(werror);
return werror;
}