From 0127ddd7e26c517f65889c60da6a09a1c9b48759 Mon Sep 17 00:00:00 2001 From: Rob van der Linde Date: Fri, 16 Feb 2024 08:03:37 +1300 Subject: [PATCH] python: sd_utils: remove redundant brackets around simple assert statements Ideally these should be exceptions not asserts Signed-off-by: Rob van der Linde Reviewed-by: Andrew Bartlett Reviewed-by: Douglas Bagnall --- python/samba/sd_utils.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/python/samba/sd_utils.py b/python/samba/sd_utils.py index eace8cf0388..57d9a1423c8 100644 --- a/python/samba/sd_utils.py +++ b/python/samba/sd_utils.py @@ -91,7 +91,7 @@ class SDUtils(object): def ace_from_sddl(ace_sddl): ace_sd = security.descriptor.from_sddl("D:" + ace_sddl, self.domain_sid) - assert (len(ace_sd.dacl.aces) == 1) + assert len(ace_sd.dacl.aces) == 1 return ace_sd.dacl.aces[0] if sddl_attr is None: @@ -131,7 +131,7 @@ class SDUtils(object): for ace in del_aces: if isinstance(ace, str): ace = ace_from_sddl(ace) - assert (isinstance(ace, security.ace)) + assert isinstance(ace, security.ace) if ace.flags & security.SEC_ACE_FLAG_INHERITED_ACE: inherited_ignored.append(ace) @@ -152,7 +152,7 @@ class SDUtils(object): ace = ace["ace"] if isinstance(ace, str): ace = ace_from_sddl(ace) - assert (isinstance(ace, security.ace)) + assert isinstance(ace, security.ace) if ace.flags & security.SEC_ACE_FLAG_INHERITED_ACE: inherited_ignored.append(ace)