From 01d42744903d7ef9044fa4d2ad1cc64594717573 Mon Sep 17 00:00:00 2001 From: Gerald Carter Date: Fri, 14 Sep 2007 12:06:34 +0000 Subject: [PATCH] r25156: Update coding guiding wrt to primitive data types --- README.Coding | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/README.Coding b/README.Coding index 73ceb5028cf..da6bb382078 100644 --- a/README.Coding +++ b/README.Coding @@ -214,3 +214,18 @@ or if (!x) { fprintf(stderr, "Unable to alloc memory!\n"); } + + +Primitive Data Types +-------------------- + +Samba has large amounts of historical code which makes use of data types +commonly supported by the C99 standard. However, at the time such types +as boolean and exact width integers did not exist and Samba developers +were forced to provide their own. Now that these types are guaranteed to +be available either as part of the compiler C99 support or from lib/replace/, +new code should adhere to the following conventions: + + * Booleans are of type "bool" (not BOOL) + * Boolean values are "true" and "false" (not True or False) + * Exact width integers are of type [u]int[8|16|32|64]_t