sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-24 21:34:56 +03:00
Code

python/gp_cert_auto_enroll: Fix bitwise test in expression

Browse Source 
Found by covscan.

result_independent_of_operands: "(e.data & 4) == 1" is always false regardless of the values of its operands. This occurs as the operand of assignment.

Signed-off-by: Pavel Filipenský <pfilipen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
Pavel Filipenský 2022-05-23 13:10:31 +02:00 committed by Jeremy Allison
parent 3bb6b05781
commit 02a9a160e2
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
python/samba/gp_cert_auto_enroll_ext.py
View File

@ -358,9 +358,9 @@ class gp_cert_auto_enroll_ext(gp_pol_ext):
# This policy applies as specified in [MS-CAESO] 4.4.5.1
if e.data == 0x8000:
continue # The policy is disabled
enroll = e.data & 0x1 == 1
manage = e.data & 0x2 == 1
retrive_pending = e.data & 0x4 == 1
enroll = e.data & 0x1 == 0x1
manage = e.data & 0x2 == 0x2
retrive_pending = e.data & 0x4 == 0x4
if enroll:
self.__enroll(pol_conf.entries, trust_dir,
private_dir)