1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-21 18:04:06 +03:00

ctdb-tests: Avoid a race

See the comment in the code for details.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
This commit is contained in:
Martin Schwenke 2020-03-17 17:58:02 +11:00 committed by Martin Schwenke
parent ef7e3265f7
commit 037abf8620

View File

@ -60,6 +60,19 @@ echo "Set ban period to 30s"
ctdb_onnode all setvar RecoveryBanPeriod 30
echo
# Avoid a race where the election handler can be called before the
# tunables are updated in the recovery daemon. Ideally, since
# everything is idle, this should take one RecoverInterval
# (i.e. iteration of the monitor loop in the recovery daemon).
# However, this is the interval between loops and each loop can take
# an arbitrary amount of time. The only way to be sure that the
# tunables have definitely been updated is to do 2 recoveries - this
# guarantees the tunables were read at the top of the loop between the
# 2 recoveries.
echo "2 recoveries to ensure that tunables have been re-read"
ctdb_onnode "$test_node" "recover"
ctdb_onnode "$test_node" "recover"
dir=$(dirname "$reclock")
echo "Rename recovery lock directory"