sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-03 13:47:25 +03:00
Code

dsdb repl_meta_data: Don't print ldif on error

Browse Source 
Don't call ldb_ldif_message_redacted_string when linked_attr_modify
fails.  When joining a large domain this takes way to much time, in excess of 3
hours for a join on a 200k domain.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Tim Beale <timbeale@catalyst.net.nz>

Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Tue Jul  9 03:03:25 UTC 2019 on sn-devel-184
This commit is contained in:
Gary Lockyer 2019-07-08 16:14:26 +12:00 committed by Gary Lockyer
parent 59cca4c5d6
commit 063809bc96
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
source4/dsdb/samdb/ldb_modules/repl_meta_data.c
View File

@ -8459,12 +8459,11 @@ static int replmd_process_la_group(struct ldb_module *module,
ret = linked_attr_modify(module, msg, NULL);
if (ret != LDB_SUCCESS) {
ldb_debug(ldb, LDB_DEBUG_WARNING,
"Failed to apply linked attribute change '%s'\n%s\n",
"Failed to apply linked attribute change "
"Error: '%s' DN: '%s' Attribute: '%s'\n",
ldb_errstring(ldb),
ldb_ldif_message_redacted_string(ldb,
tmp_ctx,
LDB_CHANGETYPE_MODIFY,
msg));
ldb_dn_get_linearized(msg->dn),
attr->lDAPDisplayName);
TALLOC_FREE(tmp_ctx);
return ret;
}