sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-26 10:04:02 +03:00
Code

fixed ldb rename now that we have unique indexes

Browse Source 
With unique indexes, any rename of a record that has an attribute that
is uniquely indexed needs to be done as a delete followed by an add,
otherwse you'll get an error that the attribute value already exists.
This commit is contained in:
Andrew Tridgell 2009-06-04 13:52:40 +10:00
parent 8ca8dabe46
commit 0849c1ef77
1 changed files with 11 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
source4/lib/ldb/ldb_tdb/ldb_tdb.c
View File

@ -805,37 +805,18 @@ static int ltdb_rename(struct ltdb_context *ctx)
return LDB_ERR_OPERATIONS_ERROR;
}
if (ldb_dn_compare(req->op.rename.olddn, req->op.rename.newdn) == 0) {
/* The rename operation is apparently only changing case -
the DNs are the same. Delete the old DN before adding
the new one to avoid a TDB_ERR_EXISTS error.
/* Always delete first then add, to avoid conflicts with
* unique indexes. We rely on the transaction to make this
* atomic
*/
tret = ltdb_delete_internal(module, req->op.rename.olddn);
if (tret != LDB_SUCCESS) {
return tret;
}
The only drawback to this is that if the delete
succeeds but the add fails, we rely on the
transaction to roll this all back. */
tret = ltdb_delete_internal(module, req->op.rename.olddn);
if (tret != LDB_SUCCESS) {
return tret;
}
tret = ltdb_add_internal(module, msg);
if (tret != LDB_SUCCESS) {
return tret;
}
} else {
/* The rename operation is changing DNs. Try to add the new
DN first to avoid clobbering another DN not related to
this rename operation. */
tret = ltdb_add_internal(module, msg);
if (tret != LDB_SUCCESS) {
return tret;
}
tret = ltdb_delete_internal(module, req->op.rename.olddn);
if (tret != LDB_SUCCESS) {
ltdb_delete_internal(module, req->op.rename.newdn);
return LDB_ERR_OPERATIONS_ERROR;
}
tret = ltdb_add_internal(module, msg);
if (tret != LDB_SUCCESS) {
return tret;
}
return LDB_SUCCESS;