sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
Code

winbindd: fix logic calling dcerpc_binding_handle_is_connected()

Browse Source 
The calls were missing the negation operator, a retry should be
attempted is the binding handle got somehow disconnected behind the
scenes and is NOT connected.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
This commit is contained in:
Ralph Boehme 2018-03-12 16:15:02 +01:00
parent 966ff3793a
commit 08718af36f
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
source3/winbindd/winbindd_dual_srv.c
View File

@ -1327,7 +1327,7 @@ reconnect:
status = NT_STATUS_OK;
}
if (!NT_STATUS_IS_OK(status)) {
if (!retry && dcerpc_binding_handle_is_connected(b)) {
if (!retry && !dcerpc_binding_handle_is_connected(b)) {
invalidate_cm_connection(domain);
retry = true;
goto reconnect;
@ -1393,7 +1393,7 @@ reconnect:
goto verify_return;
}
if (!NT_STATUS_IS_OK(status)) {
if (!retry && dcerpc_binding_handle_is_connected(b)) {
if (!retry && !dcerpc_binding_handle_is_connected(b)) {
invalidate_cm_connection(domain);
retry = true;
goto reconnect;
@ -1547,7 +1547,7 @@ reconnect:
domain->dcname,
true); /* force */
if (!NT_STATUS_IS_OK(status)) {
if (!retry && dcerpc_binding_handle_is_connected(b)) {
if (!retry && !dcerpc_binding_handle_is_connected(b)) {
invalidate_cm_connection(domain);
retry = true;
goto reconnect;
@ -1744,7 +1744,7 @@ reconnect:
b, p->mem_ctx,
&new_fti);
if (!NT_STATUS_IS_OK(status)) {
if (!retry && dcerpc_binding_handle_is_connected(b)) {
if (!retry && !dcerpc_binding_handle_is_connected(b)) {
invalidate_cm_connection(domain);
retry = true;
goto reconnect;