sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-02 09:47:23 +03:00
Code

rpc_server: Introduce "goto nomem;" to dcesrv_endpoint_connect()

Browse Source 
Avoid the control-flow changing NT_STATUS_HAVE_NO_MEMORY macro.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@samba.org>
This commit is contained in:
Volker Lendecke 2021-01-20 14:30:57 +01:00
parent c1614edf29
commit 08757d213e
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
librpc/rpc/dcesrv_core.c
View File

@ -533,14 +533,16 @@ _PUBLIC_ NTSTATUS dcesrv_endpoint_connect(struct dcesrv_context *dce_ctx,
struct dcesrv_connection **_p)
{
struct dcesrv_auth *auth = NULL;
struct dcesrv_connection *p;
struct dcesrv_connection *p = NULL;
if (!session_info) {
return NT_STATUS_ACCESS_DENIED;
}
p = talloc_zero(mem_ctx, struct dcesrv_connection);
NT_STATUS_HAVE_NO_MEMORY(p);
if (p == NULL) {
goto nomem;
}
p->dce_ctx = dce_ctx;
p->endpoint = ep;
@ -568,14 +570,12 @@ _PUBLIC_ NTSTATUS dcesrv_endpoint_connect(struct dcesrv_context *dce_ctx,
auth = dcesrv_auth_create(p);
if (auth == NULL) {
talloc_free(p);
return NT_STATUS_NO_MEMORY;
goto nomem;
}
auth->session_info = talloc_reference(auth, session_info);
if (auth->session_info == NULL) {
talloc_free(p);
return NT_STATUS_NO_MEMORY;
goto nomem;
}
p->default_auth_state = auth;
@ -587,6 +587,9 @@ _PUBLIC_ NTSTATUS dcesrv_endpoint_connect(struct dcesrv_context *dce_ctx,
*_p = p;
return NT_STATUS_OK;
nomem:
TALLOC_FREE(p);
return NT_STATUS_NO_MEMORY;
}
/*