From 092e11295a9cfaed1cc0b70a4d1e25a6a106826c Mon Sep 17 00:00:00 2001
From: Andreas Schneider <asn@samba.org>
Date: Tue, 14 Dec 2021 15:46:05 +0100
Subject: [PATCH] s3:winbindd: Remove dead code from sam_rids_to_names()

domain_name is never NULL in this case. Found by covscan.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---
 source3/winbindd/winbindd_samr.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/source3/winbindd/winbindd_samr.c b/source3/winbindd/winbindd_samr.c
index 6740d11dfb0..d4ecb55fce3 100644
--- a/source3/winbindd/winbindd_samr.c
+++ b/source3/winbindd/winbindd_samr.c
@@ -968,7 +968,6 @@ static NTSTATUS sam_rids_to_names(struct winbindd_domain *domain,
 
 		for (i=0; i<num_rids; i++) {
 			struct dom_sid sid;
-			char *dom_name = NULL;
 			char *name = NULL;
 
 			sid_compose(&sid, domain_sid, rids[i]);
@@ -980,16 +979,10 @@ static NTSTATUS sam_rids_to_names(struct winbindd_domain *domain,
 				domain,
 				tmp_ctx,
 				&sid,
-				&dom_name,
+				NULL,
 				&name,
 				&types[i]);
 			if (NT_STATUS_IS_OK(status)) {
-				if (domain_name == NULL) {
-					domain_name = dom_name;
-				} else {
-					/* always the same */
-					TALLOC_FREE(dom_name);
-				}
 				names[i] = talloc_move(names, &name);
 				num_mapped += 1;
 			}