sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-08-30 17:49:30 +03:00
Code Activity

s4:torture/rpc: test how CSDVersion="" wipes operatingSystemServicePack

Browse Source 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14936

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 4a0a0d2fc9)
This commit is contained in:
Stefan Metzmacher
2021-12-21 13:58:07 +01:00
committed by Jule Anger
parent 6417cadc27
commit 09832c6f95
2 changed files with 14 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
selftest/knownfail.d/samba4.rpc.netlogon Normal file
View File

@ -0,0 +1,9 @@
^samba4.rpc.netlogon.on.ncacn_np.with.seal,padcheck.netlogon.GetDomainInfo\(ad_dc_ntvfs\)
^samba4.rpc.netlogon.on.ncacn_ip_tcp.with.seal,padcheck.netlogon.GetDomainInfo\(ad_dc_ntvfs\)
^samba4.rpc.netlogon.on.ncacn_np.with.validate.netlogon.GetDomainInfo\(ad_dc_ntvfs\)
^samba4.rpc.netlogon.on.ncacn_ip_tcp.with.validate.netlogon.GetDomainInfo\(ad_dc_ntvfs\)
^samba4.rpc.netlogon.on.ncacn_np.with.bigendian.netlogon.GetDomainInfo\(ad_dc_ntvfs\)
^samba4.rpc.netlogon.on.ncacn_ip_tcp.with.bigendian.netlogon.GetDomainInfo\(ad_dc_ntvfs\)
^samba4.rpc.netlogon.with.seal,padcheck.netlogon.GetDomainInfo\(ad_dc\)
^samba4.rpc.netlogon.with.validate.netlogon.GetDomainInfo\(ad_dc\)
^samba4.rpc.netlogon.with.bigendian.netlogon.GetDomainInfo\(ad_dc\)

10
source4/torture/rpc/netlogon.c
View File

@ -5143,8 +5143,8 @@ static bool test_GetDomainInfo(struct torture_context *tctx,
torture_comment(tctx, "Testing netr_LogonGetDomainInfo 2nd call (variation of DNS hostname doesn't work)\n"); torture_comment(tctx, "Testing netr_LogonGetDomainInfo 2nd call (variation of DNS hostname doesn't work)\n");
netlogon_creds_client_authenticator(creds, &a); netlogon_creds_client_authenticator(creds, &a);
/* Wipe out the osVersion, and prove which values still 'stick' */ /* Wipe out the CSDVersion, and prove which values still 'stick' */
q1.os_version.os = NULL; os.os.CSDVersion = "";
/* Change also the DNS hostname to test differences in behaviour */ /* Change also the DNS hostname to test differences in behaviour */
talloc_free(discard_const_p(char, q1.dns_hostname)); talloc_free(discard_const_p(char, q1.dns_hostname));
@ -5175,9 +5175,9 @@ static bool test_GetDomainInfo(struct torture_context *tctx,
torture_assert(tctx, torture_assert(tctx,
ldb_msg_find_attr_as_string(res[0], "operatingSystemServicePack", NULL) == NULL, ldb_msg_find_attr_as_string(res[0], "operatingSystemServicePack", NULL) == NULL,
"'operatingSystemServicePack' shouldn't stick!"); "'operatingSystemServicePack' shouldn't stick!");
torture_assert(tctx, torture_assert_str_equal(tctx,
ldb_msg_find_attr_as_string(res[0], "operatingSystemVersion", NULL) == NULL, ldb_msg_find_attr_as_string(res[0], "operatingSystemVersion", NULL),
"'operatingSystemVersion' shouldn't stick!"); version_str, "'operatingSystemVersion' wrong!");
/* The DNS host name shouldn't have been updated by the server */ /* The DNS host name shouldn't have been updated by the server */