mirror of
https://github.com/samba-team/samba.git
synced 2024-12-29 11:21:54 +03:00
Fix fnum leak under error condition in cacl_dump.
(This used to be commit ab337572b8
)
This commit is contained in:
parent
2e41b42d5a
commit
099c284c47
@ -443,29 +443,36 @@ dump the acls for a file
|
||||
*******************************************************/
|
||||
static int cacl_dump(struct cli_state *cli, char *filename)
|
||||
{
|
||||
int fnum;
|
||||
int result = EXIT_FAILED;
|
||||
int fnum = -1;
|
||||
SEC_DESC *sd;
|
||||
|
||||
if (test_args) return EXIT_OK;
|
||||
if (test_args)
|
||||
return EXIT_OK;
|
||||
|
||||
fnum = cli_nt_create(cli, filename, CREATE_ACCESS_READ);
|
||||
|
||||
if (fnum == -1) {
|
||||
printf("Failed to open %s: %s\n", filename, cli_errstr(cli));
|
||||
return EXIT_FAILED;
|
||||
goto done;
|
||||
}
|
||||
|
||||
sd = cli_query_secdesc(cli, fnum, ctx);
|
||||
|
||||
if (!sd) {
|
||||
printf("ERROR: secdesc query failed: %s\n", cli_errstr(cli));
|
||||
return EXIT_FAILED;
|
||||
goto done;
|
||||
}
|
||||
|
||||
sec_desc_print(stdout, sd);
|
||||
|
||||
cli_close(cli, fnum);
|
||||
result = EXIT_OK;
|
||||
|
||||
return EXIT_OK;
|
||||
done:
|
||||
if (fnum != -1)
|
||||
cli_close(cli, fnum);
|
||||
|
||||
return result;
|
||||
}
|
||||
|
||||
/*****************************************************
|
||||
|
Loading…
Reference in New Issue
Block a user