sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

s4:torture: Skip test_membership_user for users that get incorrectly assigned group sid

Browse Source 
This commit should be removed once wb_queryuser() is fixed.

Signed-off-by: Pavel Filipenský <pfilipensky@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
This commit is contained in:
Pavel Filipenský 2023-03-27 20:00:05 +02:00 committed by Andreas Schneider
parent a1e611a8c7
commit 09e853af7f
2 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source3/winbindd/wb_queryuser.c
View File

@ -141,6 +141,10 @@ static void wb_queryuser_got_uid(struct tevent_req *subreq)
* Default the group sid to "Domain Users" in the user's
* domain. The samlogon cache or the query_user call later on
* can override this.
* TODO: There is still missing functionality to set the correct group
* sid using samlogon cache (needs to use S4USelf).
* Once this is done, remove the workaround in test_membership_user() in
* source4/torture/local/nss_tests.c
*/
sid_copy(&info->group_sid, &info->user_sid);
sid_split_rid(&info->group_sid, &user_rid);

15
source4/torture/local/nss_tests.c
View File

@ -765,6 +765,21 @@ static bool test_membership_user(struct torture_context *tctx,
int g, i;
bool primary_group_had_user_member = false;
/*
* For the local users ('LOCALADMEMBER') below, the test fails.
* wb_queryuser() wrongly defaults the group sid to RID 513 i.e.
* 'LOCALADMEMBER/domusers', but those users have a different group sid.
*
* The fix for wb_queryuser() is not part of this MR. It is a complex
* task that needs to fill samlogon cache using S4USelf and will come
* sometime later. Once wb_queryuser() gets fixed, this can be removed.
*/
if (strcmp(pwd->pw_name, "user1") == 0 ||
strcmp(pwd->pw_name, "user2") == 0 ||
strcmp(pwd->pw_name, "force_user") == 0 || pwd->pw_uid == 1000) {
return true;
}
#ifdef HAVE_GETGROUPLIST
torture_assert(tctx, test_getgrouplist(tctx,
pwd->pw_name,