sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-03 12:58:35 +03:00
Code

s3:smbd: remove pointless static variable in uid.c

Browse Source 
We always free the value at the end of the function,
so we don't need a static variable to hold just NULL
for the time the function isn't executed.

metze
This commit is contained in:
Stefan Metzmacher 2009-01-08 09:04:30 +01:00
parent 9ae0c5e5a7
commit 0a0cd1396a
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
source3/smbd/uid.c
View File

@ -28,13 +28,11 @@ extern struct current_user current_user;
bool change_to_guest(void)
{
static struct passwd *pass=NULL;
struct passwd *pass;
pass = getpwnam_alloc(talloc_autofree_context(), lp_guestaccount());
if (!pass) {
/* Don't need to free() this as its stored in a static */
pass = getpwnam_alloc(talloc_autofree_context(), lp_guestaccount());
if (!pass)
return(False);
return false;
}
#ifdef AIX
@ -49,9 +47,8 @@ bool change_to_guest(void)
current_user.vuid = UID_FIELD_INVALID;
TALLOC_FREE(pass);
pass = NULL;
return True;
return true;
}
/*******************************************************************