From 0c2ceb0435c7d03d72c7f9c29b0240f944f6cc42 Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Fri, 21 May 2021 11:14:19 -0700 Subject: [PATCH] s3: torture: Add regression test for renaming SMB1+POSIX symlinks, dangling and real. Mark as knownfail. Signed-off-by: Jeremy Allison Reviewed-by: Noel Power --- selftest/knownfail.d/posix_symlink_rename | 2 + source3/selftest/tests.py | 1 + source3/torture/proto.h | 1 + source3/torture/test_posix.c | 134 ++++++++++++++++++++++ source3/torture/torture.c | 4 + 5 files changed, 142 insertions(+) create mode 100644 selftest/knownfail.d/posix_symlink_rename diff --git a/selftest/knownfail.d/posix_symlink_rename b/selftest/knownfail.d/posix_symlink_rename new file mode 100644 index 00000000000..b0889e7412a --- /dev/null +++ b/selftest/knownfail.d/posix_symlink_rename @@ -0,0 +1,2 @@ +^samba3.smbtorture_s3.plain.POSIX-SYMLINK-RENAME.smbtorture\(nt4_dc_smb1\) +^samba3.smbtorture_s3.crypt.POSIX-SYMLINK-RENAME.smbtorture\(nt4_dc_smb1\) diff --git a/source3/selftest/tests.py b/source3/selftest/tests.py index 13f0466802e..d4f9ea27ba6 100755 --- a/source3/selftest/tests.py +++ b/source3/selftest/tests.py @@ -265,6 +265,7 @@ posix_tests = ["POSIX", "POSIX-APPEND", "POSIX-SYMLINK-ACL", "POSIX-SYMLINK-EA", "POSIX-SYMLINK-PARENT", "POSIX-SYMLINK-CHMOD", "POSIX-DIR-DEFAULT-ACL", + "POSIX-SYMLINK-RENAME", ] for t in posix_tests: diff --git a/source3/torture/proto.h b/source3/torture/proto.h index bc2d8c7b3f2..4e813c473b1 100644 --- a/source3/torture/proto.h +++ b/source3/torture/proto.h @@ -93,6 +93,7 @@ bool run_posix_symlink_parent_test(int dummy); bool run_posix_symlink_chmod_test(int dummy); bool run_posix_dir_default_acl_test(int dummy); bool run_case_insensitive_create(int dummy); +bool run_posix_symlink_rename_test(int dummy); bool run_nbench2(int dummy); bool run_async_echo(int dummy); diff --git a/source3/torture/test_posix.c b/source3/torture/test_posix.c index 8c1306c5066..dc25db4c985 100644 --- a/source3/torture/test_posix.c +++ b/source3/torture/test_posix.c @@ -1309,3 +1309,137 @@ out: TALLOC_FREE(frame); return correct; } + +/* + Ensure we can rename a symlink whether it is + pointing to a real object or dangling. + */ +bool run_posix_symlink_rename_test(int dummy) +{ + TALLOC_CTX *frame = NULL; + struct cli_state *cli_unix = NULL; + NTSTATUS status; + uint16_t fnum = (uint16_t)-1; + const char *fname_real = "file_real"; + const char *fname_real_symlink = "file_real_symlink"; + const char *fname_real_symlink_newname = "rename_file_real_symlink"; + const char *nonexist = "nonexist"; + const char *nonexist_symlink = "dangling_symlink"; + const char *nonexist_symlink_newname = "dangling_symlink_rename"; + bool correct = false; + + frame = talloc_stackframe(); + + printf("Starting POSIX-SYMLINK-RENAME test\n"); + + if (!torture_open_connection(&cli_unix, 0)) { + TALLOC_FREE(frame); + return false; + } + + torture_conn_set_sockopt(cli_unix); + + status = torture_setup_unix_extensions(cli_unix); + if (!NT_STATUS_IS_OK(status)) { + TALLOC_FREE(frame); + return false; + } + + /* Start with a clean slate. */ + cli_posix_unlink(cli_unix, fname_real); + cli_posix_unlink(cli_unix, fname_real_symlink); + cli_posix_unlink(cli_unix, fname_real_symlink_newname); + cli_posix_unlink(cli_unix, nonexist); + cli_posix_unlink(cli_unix, nonexist_symlink); + cli_posix_unlink(cli_unix, nonexist_symlink_newname); + + /* Create a real file. */ + status = cli_posix_open(cli_unix, + fname_real, + O_RDWR|O_CREAT, + 0644, + &fnum); + if (!NT_STATUS_IS_OK(status)) { + printf("cli_posix_open of %s failed error %s\n", + fname_real, + nt_errstr(status)); + goto out; + } + status = cli_close(cli_unix, fnum); + if (!NT_STATUS_IS_OK(status)) { + printf("cli_close failed %s\n", nt_errstr(status)); + goto out; + } + fnum = (uint16_t)-1; + + /* Create symlink to real target. */ + status = cli_posix_symlink(cli_unix, + fname_real, + fname_real_symlink); + if (!NT_STATUS_IS_OK(status)) { + printf("cli_posix_symlink of %s -> %s failed error %s\n", + fname_real_symlink, + fname_real, + nt_errstr(status)); + goto out; + } + + /* Ensure we can rename the symlink to the real file. */ + status = cli_rename(cli_unix, + fname_real_symlink, + fname_real_symlink_newname, + false); + if (!NT_STATUS_IS_OK(status)) { + printf("cli_rename of %s -> %s failed %s\n", + fname_real_symlink, + fname_real_symlink_newname, + nt_errstr(status)); + goto out; + } + + /* Now create symlink to non-existing target. */ + status = cli_posix_symlink(cli_unix, + nonexist, + nonexist_symlink); + if (!NT_STATUS_IS_OK(status)) { + printf("cli_posix_symlink of %s -> %s failed error %s\n", + nonexist_symlink, + nonexist, + nt_errstr(status)); + goto out; + } + + /* Ensure we can rename the dangling symlink. */ + status = cli_rename(cli_unix, + nonexist_symlink, + nonexist_symlink_newname, + false); + if (!NT_STATUS_IS_OK(status)) { + printf("cli_rename of %s -> %s failed %s\n", + nonexist_symlink, + nonexist_symlink_newname, + nt_errstr(status)); + goto out; + } + + printf("POSIX-SYMLINK-RENAME test passed\n"); + correct = true; + +out: + if (fnum != (uint16_t)-1) { + cli_close(cli_unix, fnum); + } + cli_posix_unlink(cli_unix, fname_real); + cli_posix_unlink(cli_unix, fname_real_symlink); + cli_posix_unlink(cli_unix, fname_real_symlink_newname); + cli_posix_unlink(cli_unix, nonexist); + cli_posix_unlink(cli_unix, nonexist_symlink); + cli_posix_unlink(cli_unix, nonexist_symlink_newname); + + if (!torture_close_connection(cli_unix)) { + correct = false; + } + + TALLOC_FREE(frame); + return correct; +} diff --git a/source3/torture/torture.c b/source3/torture/torture.c index 06bb44943e6..914c7705faf 100644 --- a/source3/torture/torture.c +++ b/source3/torture/torture.c @@ -14955,6 +14955,10 @@ static struct { .name = "POSIX-SYMLINK-CHMOD", .fn = run_posix_symlink_chmod_test, }, + { + .name = "POSIX-SYMLINK-RENAME", + .fn = run_posix_symlink_rename_test, + }, { .name = "POSIX-DIR-DEFAULT-ACL", .fn = run_posix_dir_default_acl_test,