From 0cb8b9d113b322f784100365669d2be8b7fa635a Mon Sep 17 00:00:00 2001 From: Volker Lendecke <vl@samba.org> Date: Thu, 7 Jan 2016 21:14:05 +0100 Subject: [PATCH] ctdb: Fix CID 1347319 Unchecked return value Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> --- ctdb/common/system_linux.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/ctdb/common/system_linux.c b/ctdb/common/system_linux.c index 6447f56062c..55c22c52b6c 100644 --- a/ctdb/common/system_linux.c +++ b/ctdb/common/system_linux.c @@ -247,7 +247,13 @@ int ctdb_sys_send_arp(const ctdb_sock_addr *addr, const char *iface) ip6->ip6_hlim = 255; ip6->ip6_src = addr->ip6.sin6_addr; /* all-nodes multicast */ - inet_pton(AF_INET6, "ff02::1", &ip6->ip6_dst); + + ret = inet_pton(AF_INET6, "ff02::1", &ip6->ip6_dst); + if (ret != 1) { + close(s); + DEBUG(DEBUG_CRIT,(__location__ " failed inet_pton\n")); + return -1; + } nd_na = (struct nd_neighbor_advert *)(ip6+1); nd_na->nd_na_type = ND_NEIGHBOR_ADVERT;