sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-15 23:24:37 +03:00
Code

Check for security on delete printer was reversed...

Browse Source 
Jeremy.
This commit is contained in:
Jeremy Allison -
parent e42b76337b
commit 0d27cc909b
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
source/rpc_server/srv_spoolss_nt.c
View File

@ -313,11 +313,6 @@ static WERROR delete_printer_handle(pipes_struct *p, POLICY_HND *hnd)
return WERR_BADFID; return WERR_BADFID;
} }
if (del_a_printer(Printer->dev.handlename) != 0) {
DEBUG(3,("Error deleting printer %s\n", Printer->dev.handlename));
return WERR_BADFID;
}
/* Check calling user has permission to delete printer. Note that /* Check calling user has permission to delete printer. Note that
since we set the snum parameter to -1 only administrators can since we set the snum parameter to -1 only administrators can
delete the printer. This stops people with the Full Control delete the printer. This stops people with the Full Control
@ -328,6 +323,11 @@ static WERROR delete_printer_handle(pipes_struct *p, POLICY_HND *hnd)
return WERR_ACCESS_DENIED; return WERR_ACCESS_DENIED;
} }
if (del_a_printer(Printer->dev.handlename) != 0) {
DEBUG(3,("Error deleting printer %s\n", Printer->dev.handlename));
return WERR_BADFID;
}
if (*lp_deleteprinter_cmd()) { if (*lp_deleteprinter_cmd()) {
char *cmd = lp_deleteprinter_cmd(); char *cmd = lp_deleteprinter_cmd();