sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-03 13:47:25 +03:00
Code

krb5pac/netlogon: add a comment regarding PAC_LOGON_INFO unique pointers on push

Browse Source 
This difference is the reason why we can't fully (ndr)validate some
PAC blobs.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
This commit is contained in:
Stefan Metzmacher 2016-07-14 09:34:43 +02:00
parent a6f672d69f
commit 0e201ecdc5
2 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
librpc/idl/krb5pac.idl
View File

@ -33,6 +33,12 @@ interface krb5pac
typedef struct {
netr_SamInfo3 info3;
/*
* On ndr_push:
* Pointers values of info3.sids[*].sid
* should be allocated before the following ones?
* (just the 0x30 0x00 0x02 0x00 value).
*/
PAC_DOMAIN_GROUP_MEMBERSHIP resource_groups;
} PAC_LOGON_INFO;

8
librpc/idl/netlogon.idl
View File

@ -263,6 +263,14 @@ interface netlogon
netr_SamBaseInfo base;
uint32 sidcount;
[size_is(sidcount)] netr_SidAttr *sids;
/*
* On ndr_push:
* Should pointer values be allocated
* of sids[*].sid before the following ones?
*
* That's at least the case for
* PAC_LOGON_INFO.
*/
lsa_String dns_domainname;
lsa_String principal_name;
uint32 unknown4[20];