sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

smbd: Simplify check_user_ok()

Browse Source 
Don't walk the cache at all if we get UID_FIELD_INVALID

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
Volker Lendecke 2024-07-29 04:24:30 -07:00 committed by Jeremy Allison
parent 95c031b660
commit 0e8a0f3bd4
1 changed files with 14 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
source3/smbd/uid.c
View File

@ -268,7 +268,6 @@ static bool check_user_ok(connection_struct *conn,
{
const struct loadparm_substitution *lp_sub =
loadparm_s3_global_substitution();
unsigned int i;
bool readonly_share = false;
bool admin_user = false;
struct vuid_cache_entry *ent = NULL;
@ -276,24 +275,21 @@ static bool check_user_ok(connection_struct *conn,
NTSTATUS status;
bool ok;
for (i=0; i<VUID_CACHE_SIZE; i++) {
ent = &conn->vuid_cache->array[i];
if (ent->vuid == vuid) {
if (vuid == UID_FIELD_INVALID) {
/*
* Slow path, we don't care
* about the array traversal.
*/
continue;
if (vuid != UID_FIELD_INVALID) {
unsigned int i;
for (i=0; i<VUID_CACHE_SIZE; i++) {
ent = &conn->vuid_cache->array[i];
if (ent->vuid == vuid) {
free_conn_state_if_unused(conn);
conn->session_info = ent->session_info;
conn->read_only = ent->read_only;
conn->share_access = ent->share_access;
conn->vuid = ent->vuid;
conn->veto_list = ent->veto_list;
conn->hide_list = ent->hide_list;
return(True);
}
free_conn_state_if_unused(conn);
conn->session_info = ent->session_info;
conn->read_only = ent->read_only;
conn->share_access = ent->share_access;
conn->vuid = ent->vuid;
conn->veto_list = ent->veto_list;
conn->hide_list = ent->hide_list;
return(True);
}
}