mirror of
https://github.com/samba-team/samba.git
synced 2025-02-22 05:57:43 +03:00
README.Coding: Add __func__
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Mon Nov 11 16:08:09 CET 2013 on sn-devel-104
This commit is contained in:
parent
bbb5f66bcd
commit
0eaae1a87f
@ -377,3 +377,17 @@ do not use them in new code.
|
||||
|
||||
The only exception is the test code that depends repeated use of calls
|
||||
like CHECK_STATUS, CHECK_VAL and others.
|
||||
|
||||
|
||||
Function names in DEBUG statements
|
||||
----------------------------------
|
||||
|
||||
Many DEBUG statements contain the name of the function they appear in. This is
|
||||
not a good idea, as this is prone to bitrot. Function names change, code
|
||||
moves, but the DEBUG statements are not adapted. Use %s and __func__ for this:
|
||||
|
||||
Bad Example:
|
||||
DEBUG(0, ("strstr_m: src malloc fail\n"));
|
||||
|
||||
Good Example:
|
||||
DEBUG(0, ("%s: src malloc fail\n", __func__));
|
||||
|
Loading…
x
Reference in New Issue
Block a user