sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

s3: smbd: smbd_smb2_setinfo_send(). All calls to SMB_VFS_FSTAT(fsp, &fsp->fsp_name->st) clobber fsp->fsp_name->st.st_ex_iflags.

Browse Source 
If doing an SMB_VFS_FSTAT() returning onto the stat struct stored in the fsp,
we must call vfs_stat_fsp() as this preserves the iflags.

This is the last SMB_VFS_FSTAT that uses fsp->fsp_name->st, so
remove knownfail.d/durable-v2-setinfo

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15022

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Mar 24 17:21:29 UTC 2022 on sn-devel-184

(cherry picked from commit c4f9c37240)
This commit is contained in:
Jeremy Allison 2022-03-18 12:30:27 -07:00 committed by Jule Anger
parent c8b6ddb08c
commit 0f0c12b64f
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
selftest/knownfail.d/durable-v2-setinfo
View File

@ -1 +0,0 @@
^samba3.smb2.durable-v2-open.durable-v2-setinfo\(nt4_dc\)

6
source3/smbd/smb2_setinfo.c
View File

@ -458,12 +458,12 @@ static struct tevent_req *smbd_smb2_setinfo_send(TALLOC_CTX *mem_ctx,
* Original code - this is an open file.
*/
if (SMB_VFS_FSTAT(fsp, &fsp->fsp_name->st) != 0) {
status = vfs_stat_fsp(fsp);
if (!NT_STATUS_IS_OK(status)) {
DEBUG(3,("smbd_smb2_setinfo_send: fstat "
"of %s failed (%s)\n",
fsp_fnum_dbg(fsp),
strerror(errno)));
status = map_nt_error_from_unix(errno);
nt_errstr(status)));
tevent_req_nterror(req, status);
return tevent_req_post(req, ev);
}