sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-11 05:18:09 +03:00
Code

ldb:includes: protect ldb_modules.h from being used by Samba < 4.7

Browse Source 
Samba versions before 4.7 are incompatible with the read_[un]lock()
behaviour introduced into ldb.

This makes sure older Samba versions fail to compile against
ldb >= 1.2.0.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12859

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Stefan Metzmacher 2017-06-30 08:14:02 +02:00
parent a1158d2237
commit 0fac7e4d73
1 changed files with 35 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
lib/ldb/include/ldb_module.h
View File

@ -35,6 +35,41 @@
#include <ldb.h>
#if defined(_SAMBA_BUILD_) && defined(USING_SYSTEM_LDB)
/*
* Versions before 1.2.0 doesn't define these values
* so we assime 1.1.29 (which was used in Samba 4.6)
*
* See https://bugzilla.samba.org/show_bug.cgi?id=12859
*/
#ifndef EXPECTED_SYSTEM_LDB_VERSION_MAJOR
#define EXPECTED_SYSTEM_LDB_VERSION_MAJOR 1
#endif
#ifndef EXPECTED_SYSTEM_LDB_VERSION_MINOR
#define EXPECTED_SYSTEM_LDB_VERSION_MINOR 1
#endif
#ifndef EXPECTED_SYSTEM_LDB_VERSION_MINOR
#define EXPECTED_SYSTEM_LDB_VERSION_MINOR 29
#endif
/*
* Only Samba versions which expect ldb >= 1.2.0
* are compatible with read_[un]lock() behaviour.
*
* See https://bugzilla.samba.org/show_bug.cgi?id=12859
*/
#if EXPECTED_SYSTEM_LDB_VERSION_MAJOR > 1
#define __LDB_READ_LOCK_COMPATIBLE__ 1
#elif EXPECTED_SYSTEM_LDB_VERSION_MINOR > 1
#define __LDB_READ_LOCK_COMPATIBLE__ 1
#endif
#ifndef __LDB_READ_LOCK_COMPATIBLE__
#error "Samba < 4.7 is not compatible with this version of ldb due to assumptions around read locks"
#endif
#endif /* defined(_SAMBA_BUILD_) && defined(USING_SYSTEM_LDB) */
struct ldb_context;
struct ldb_module;