sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

CVE-2023-34968: mdssvc: switch to doing an early return

Browse Source 
Just reduce indentation of the code handling the success case. No change in
behaviour.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15388

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
This commit is contained in:
Ralph Boehme 2023-06-20 11:05:22 +02:00 committed by Jule Anger
parent 34f9f1b37e
commit 0fdfc85f28
1 changed files with 14 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
source3/rpc_server/mdssvc/mdssvc.c
View File

@ -1817,20 +1817,22 @@ bool mds_dispatch(struct mds_ctx *mds_ctx,
} }
ok = slcmd->function(mds_ctx, query, reply); ok = slcmd->function(mds_ctx, query, reply);
if (ok) { if (!ok) {
DBG_DEBUG("%s", dalloc_dump(reply, 0)); goto cleanup;
len = sl_pack(reply,
(char *)response_blob->spotlight_blob,
response_blob->size);
if (len == -1) {
DBG_ERR("error packing Spotlight RPC reply\n");
ok = false;
goto cleanup;
}
response_blob->length = len;
} }
DBG_DEBUG("%s", dalloc_dump(reply, 0));
len = sl_pack(reply,
(char *)response_blob->spotlight_blob,
response_blob->size);
if (len == -1) {
DBG_ERR("error packing Spotlight RPC reply\n");
ok = false;
goto cleanup;
}
response_blob->length = len;
cleanup: cleanup:
talloc_free(query); talloc_free(query);
talloc_free(reply); talloc_free(reply);