sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-22 22:04:08 +03:00
Code

rpc_server3: Remove dcerpc_ncacn_conn->remote_client_addr

Browse Source 
This was only used inside rpc_worker_new_client(), a leftover from
times where accepting a client was an async process waiting for the
struct named_pipe_auth_req_info4.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
Volker Lendecke 2021-10-06 11:16:21 +02:00 committed by Jeremy Allison
parent 7c5b247e31
commit 10478d39a1
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
source3/rpc_server/rpc_server.h
View File

@ -41,7 +41,6 @@ struct dcerpc_ncacn_conn {
struct dcesrv_endpoint *endpoint;
struct tsocket_address *remote_client_addr;
char *remote_client_name;
struct tsocket_address *local_server_addr;
char *local_server_name;

8
source3/rpc_server/rpc_worker.c
View File

@ -171,6 +171,7 @@ static void rpc_worker_new_client(
{
struct dcesrv_context *dce_ctx = worker->dce_ctx;
struct named_pipe_auth_req_info5 *info5 = client->npa_info5;
struct tsocket_address *remote_client_addr = NULL;
struct dcerpc_binding *b = NULL;
enum dcerpc_transport_t transport;
struct dcesrv_endpoint *ep = NULL;
@ -260,7 +261,7 @@ static void rpc_worker_new_client(
ret = tsocket_address_unix_from_path(
ncacn_conn,
info5->remote_client_addr,
&ncacn_conn->remote_client_addr);
&remote_client_addr);
if (ret == -1) {
DBG_DEBUG("tsocket_address_unix_from_path"
"(%s) failed: %s\n",
@ -302,7 +303,7 @@ static void rpc_worker_new_client(
"ip",
info5->remote_client_addr,
info5->remote_client_port,
&ncacn_conn->remote_client_addr);
&remote_client_addr);
if (ret == -1) {
DBG_DEBUG("tsocket_address_inet_from_strings"
"(%s, %"PRIu16") failed: %s\n",
@ -423,7 +424,8 @@ static void rpc_worker_new_client(
dcesrv_conn->stream = talloc_move(dcesrv_conn, &tstream);
dcesrv_conn->local_address = ncacn_conn->local_server_addr;
dcesrv_conn->remote_address = ncacn_conn->remote_client_addr;
dcesrv_conn->remote_address =
talloc_move(dcesrv_conn, &remote_client_addr);
if (client->bind_packet.length == 0) {
DBG_DEBUG("Expected bind packet\n");