sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

s3:smbd multichannel: improve smbXsrv_connection_dbg()

Browse Source 
client_guid as well as local and remote address help a lot
for debugging...

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
This commit is contained in:
Stefan Metzmacher 2023-11-17 13:36:02 +01:00
parent 475784d63e
commit 10b084f824
1 changed files with 22 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
source3/smbd/smb2_process.c
View File

@ -688,20 +688,33 @@ NTSTATUS smbXsrv_connection_init_tables(struct smbXsrv_connection *conn,
*/
const char *smbXsrv_connection_dbg(const struct smbXsrv_connection *xconn)
{
const char *ret;
char *addr;
const char *ret = NULL;
char *raddr = NULL;
char *laddr = NULL;
struct GUID_txt_buf guid_buf = {};
/*
* TODO: this can be improved later
* maybe including the client guid or more
* TODO: this can be improved further later...
*/
addr = tsocket_address_string(xconn->remote_address, talloc_tos());
if (addr == NULL) {
raddr = tsocket_address_string(xconn->remote_address, talloc_tos());
if (raddr == NULL) {
return "<tsocket_address_string() failed>";
}
laddr = tsocket_address_string(xconn->local_address, talloc_tos());
if (laddr == NULL) {
return "<tsocket_address_string() failed>";
}
ret = talloc_asprintf(talloc_tos(), "ptr=%p,id=%llu,addr=%s",
xconn, (unsigned long long)xconn->channel_id, addr);
TALLOC_FREE(addr);
ret = talloc_asprintf(talloc_tos(),
"PID=%d,CLIENT=%s,channel=%"PRIu64",remote=%s,local=%s",
getpid(),
GUID_buf_string(&xconn->smb2.client.guid, &guid_buf),
xconn->channel_id,
raddr,
laddr);
TALLOC_FREE(raddr);
TALLOC_FREE(laddr);
if (ret == NULL) {
return "<talloc_asprintf() failed>";
}