sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

s3: smbd: Ensure we remove any pending aio values for named pipes on forced shutdown.

Browse Source 
Matches file and directory closes.

Remove knownfail.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15423

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Sep 20 02:43:18 UTC 2023 on atb-devel-224
This commit is contained in:
Jeremy Allison 2023-09-19 14:36:45 -07:00
parent 66398dd03c
commit 11280f1705
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
selftest/knownfail.d/smb2_pipe_read_async_disconnect
View File

@ -1 +0,0 @@
^samba3.smbtorture_s3.plain.SMB2-PIPE-READ-ASYNC-DISCONNECT.check_panic\(fileserver\)

8
source3/smbd/close.c
View File

@ -1630,6 +1630,14 @@ NTSTATUS close_file_smb(struct smb_request *req,
SMB_ASSERT(fsp->stream_fsp == NULL);
if (fsp->fake_file_handle != NULL) {
/*
* Named pipes are opened as fake files and
* can have pending aio requests. Ensure
* we clear out all pending aio on force
* shutdown of named pipes also.
* BUG: https://bugzilla.samba.org/show_bug.cgi?id=15423
*/
assert_no_pending_aio(fsp, close_type);
status = close_fake_file(req, fsp);
} else if (fsp->print_file != NULL) {
/* FIXME: return spool errors */