sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-18 06:04:06 +03:00
Code

s3: libsmbclient: Fix smbc_getxattr() to return 0 on success.

Browse Source 
Remove knownfail.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14808

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Mulder <dmulder@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Nov  1 18:31:22 UTC 2022 on sn-devel-184

(cherry picked from commit bdbb38d16c8eaff33484bb747efa639c4d8e7f35)
This commit is contained in:
Jeremy Allison 2022-10-28 15:31:39 -07:00 committed by Jule Anger
parent 628a1c3382
commit 113536e0d7
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
selftest/knownfail.d/libsmbclient_getxattr
View File

@ -1 +0,0 @@
^samba4.libsmbclient.getxattr.*

6
source3/libsmb/libsmb_xattr.c
View File

@ -2176,7 +2176,11 @@ SMBC_getxattr_ctx(SMBCCTX *context,
errno = SMBC_errno(context, srv->cli);
}
TALLOC_FREE(frame);
return ret;
/*
* static function cacl_get returns a value greater than zero
* on success. Map this to zero meaning success.
*/
return ret < 0 ? -1 : 0;
}
/* Unsupported attribute name */