sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-25 06:04:04 +03:00
Code

s4:librpc/rpc: fix padding caclucation in ncacn_push_request_sign()

Browse Source 
This is simplified by using DCERPC_AUTH_PAD_LENGTH() and changes the behaviour
so that we will use no padding if the stub_length is already aligned
to DCERPC_AUTH_PAD_ALIGNMENT (16 bytes).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11061

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Stefan Metzmacher 2015-06-20 17:49:02 +02:00
parent 48f2c383e1
commit 114c52e73e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
source4/librpc/rpc/dcerpc.c
View File

@ -884,7 +884,7 @@ static NTSTATUS ncacn_push_request_sign(struct dcecli_connection *c,
whole packet, whereas w2k8 wants it relative to the start whole packet, whereas w2k8 wants it relative to the start
of the stub */ of the stub */
c->security_state.auth_info->auth_pad_length = c->security_state.auth_info->auth_pad_length =
(16 - (pkt->u.request.stub_and_verifier.length & 15)) & 15; DCERPC_AUTH_PAD_LENGTH(pkt->u.request.stub_and_verifier.length);
ndr_err = ndr_push_zero(ndr, c->security_state.auth_info->auth_pad_length); ndr_err = ndr_push_zero(ndr, c->security_state.auth_info->auth_pad_length);
if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) { if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
return ndr_map_error2ntstatus(ndr_err); return ndr_map_error2ntstatus(ndr_err);