sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-08 21:18:16 +03:00
Code

s3: smbd: Always use metadata_fsp() when processing fsctls.

Browse Source 
Currently all fsctls we implement need the base fsp, not
an alternate data stream fsp. We may revisit this later
if we implement fsctls that operate on an ADS.

Remove knownfail.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15236

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Walker <awalker@ixsystems.com>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Nov 14 18:13:31 UTC 2022 on sn-devel-184

(cherry picked from commit fa4eba131b)
This commit is contained in:
Jeremy Allison 2022-11-10 14:43:15 -08:00 committed by Jule Anger
parent c6733cbe87
commit 1189604995
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
selftest/knownfail.d/smb2-ioctl-stream
View File

@ -1 +0,0 @@
^samba3.smb2.ioctl-on-stream.ioctl-on-stream\(fileserver\)

8
source3/modules/vfs_default.c
View File

@ -1392,7 +1392,13 @@ static NTSTATUS vfswrap_fsctl(struct vfs_handle_struct *handle,
char **out_data = (char **)_out_data;
NTSTATUS status;
SMB_ASSERT(!fsp_is_alternate_stream(fsp));
/*
* Currently all fsctls operate on the base
* file if given an alternate data stream.
* Revisit this if we implement fsctls later
* that need access to the ADS handle.
*/
fsp = metadata_fsp(fsp);
switch (function) {
case FSCTL_SET_SPARSE: