sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-12-13 16:23:50 +03:00
Code Activity

python: Handle LdbError thrown from functions operating on DNs

Browse Source 
None of these functions can return False now. Instead we must catch the
LdbError if we want to perform further error handling.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Joseph Sutton
2022-09-30 11:50:30 +13:00
committed by Andrew Bartlett
parent a68428a951
commit 12677ff65e
7 changed files with 76 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
python/samba/sites.py
View File

@@ -93,9 +93,13 @@ def delete_site(samdb, configDn, siteName):
"""
dnsite = ldb.Dn(samdb, "CN=Sites")
if dnsite.add_base(configDn) == False:
try:
dnsite.add_base(configDn)
except ldb.LdbError:
raise SiteException("dnsite.add_base() failed")
if dnsite.add_child("CN=X") == False:
try:
dnsite.add_child("CN=X")
except ldb.LdbError:
raise SiteException("dnsite.add_child() failed")
dnsite.set_component(0, "CN", siteName)