From 1288989f0f5043f3a3dff9fda217f41b16d33958 Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Tue, 30 Aug 2022 05:57:48 +0000 Subject: [PATCH] s3:smbd: let update_write_time_on_close() use share_mode_{old,changed}_write_time() We're already holding a share_mode_lock, so we can use it directly. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15125 Signed-off-by: Stefan Metzmacher Reviewed-by: Jeremy Allison --- source3/smbd/close.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source3/smbd/close.c b/source3/smbd/close.c index 4306a59342f..d50d34229b7 100644 --- a/source3/smbd/close.c +++ b/source3/smbd/close.c @@ -608,12 +608,12 @@ static NTSTATUS update_write_time_on_close(struct files_struct *fsp) NTTIME share_mtime = share_mode_changed_write_time(lck); /* On close if we're changing the real file time we * must update it in the open file db too. */ - (void)set_write_time(fsp->file_id, fsp->close_write_time); + share_mode_set_old_write_time(lck, fsp->close_write_time); /* Close write times overwrite sticky write times so we must replace any sticky write time here. */ if (!null_nttime(share_mtime)) { - (void)set_sticky_write_time(fsp->file_id, fsp->close_write_time); + share_mode_set_changed_write_time(lck, fsp->close_write_time); } TALLOC_FREE(lck); }