sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-27 22:50:26 +03:00
Code

winexe: Fix a possible null pointer derference

Browse Source 
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Andreas Schneider 2020-11-25 11:38:01 +01:00 committed by Andreas Schneider
parent 6123bd25ad
commit 12b9e4408d
1 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
examples/winexe/winexe.c
View File

@ -347,7 +347,7 @@ static NTSTATUS winexe_svc_upload(
int flags)
{
struct cli_state *cli;
uint16_t fnum;
uint16_t fnum = 0xffff;
NTSTATUS status;
const DATA_BLOB *binary = NULL;
@ -389,7 +389,7 @@ static NTSTATUS winexe_svc_upload(
}
if (binary == NULL) {
//TODO
goto done;
}
status = cli_ntcreate(
@ -420,16 +420,20 @@ static NTSTATUS winexe_svc_upload(
NULL);
if (!NT_STATUS_IS_OK(status)) {
DBG_WARNING("Could not write file: %s\n", nt_errstr(status));
goto close_done;
goto done;
}
close_done:
status = cli_close(cli, fnum);
if (!NT_STATUS_IS_OK(status)) {
DBG_WARNING("Close(%"PRIu16") failed for %s: %s\n", fnum,
service_filename, nt_errstr(status));
}
done:
if (fnum != 0xffff) {
status = cli_close(cli, fnum);
if (!NT_STATUS_IS_OK(status)) {
DBG_WARNING("Close(%"PRIu16") failed for %s: %s\n",
fnum,
service_filename,
nt_errstr(status));
}
}
TALLOC_FREE(cli);
return status;
}