sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-14 19:24:43 +03:00
Code

s3:winbind: Move sighup handling related functions to winbindd-lib subsystem

Browse Source 
The source3/winbindd/winbindd.c file does not belong to 'winbindd-lib'
subsystem. Funtions called from winbindd-lib must be part of it.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
Samuel Cabrero 2022-03-02 18:44:07 +01:00 committed by Jeremy Allison
parent dfba83e14a
commit 12ef154345
2 changed files with 62 additions and 64 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

64
source3/winbindd/winbindd.c
View File

@ -87,31 +87,6 @@ static void winbindd_status(void)
}
}
/* Flush client cache */
static void flush_caches_noinit(void)
{
/*
* We need to invalidate cached user list entries on a SIGHUP
* otherwise cached access denied errors due to restrict anonymous
* hang around until the sequence number changes.
* NB
* Skip uninitialized domains when flush cache.
* If domain is not initialized, it means it is never
* used or never become online. look, wcache_invalidate_cache()
* -> get_cache() -> init_dc_connection(). It causes a lot of traffic
* for unused domains and large traffic for primay domain's DC if there
* are many domains..
*/
if (!wcache_invalidate_cache_noinit()) {
DEBUG(0, ("invalidating the cache failed; revalidate the cache\n"));
if (!winbindd_cache_validate_and_initialize()) {
exit(1);
}
}
}
/*
handle stdin becoming readable when we are in --foreground mode
*/
@ -167,45 +142,6 @@ bool winbindd_setup_stdin_handler(bool parent, bool foreground)
return true;
}
static void winbindd_sig_hup_handler(struct tevent_context *ev,
struct tevent_signal *se,
int signum,
int count,
void *siginfo,
void *private_data)
{
const char *file = (const char *)private_data;
DEBUG(1,("Reloading services after SIGHUP\n"));
flush_caches_noinit();
winbindd_reload_services_file(file);
}
bool winbindd_setup_sig_hup_handler(const char *lfile)
{
struct tevent_signal *se;
char *file = NULL;
if (lfile) {
file = talloc_strdup(global_event_context(),
lfile);
if (!file) {
return false;
}
}
se = tevent_add_signal(global_event_context(),
global_event_context(),
SIGHUP, 0,
winbindd_sig_hup_handler,
file);
if (!se) {
return false;
}
return true;
}
static void winbindd_sig_chld_handler(struct tevent_context *ev,
struct tevent_signal *se,
int signum,

62
source3/winbindd/winbindd_dual.c
View File

@ -2005,3 +2005,65 @@ bool winbindd_setup_sig_term_handler(bool parent)
return true;
}
static void flush_caches_noinit(void)
{
/*
* We need to invalidate cached user list entries on a SIGHUP
* otherwise cached access denied errors due to restrict anonymous
* hang around until the sequence number changes.
* NB
* Skip uninitialized domains when flush cache.
* If domain is not initialized, it means it is never
* used or never become online. look, wcache_invalidate_cache()
* -> get_cache() -> init_dc_connection(). It causes a lot of traffic
* for unused domains and large traffic for primay domain's DC if there
* are many domains..
*/
if (!wcache_invalidate_cache_noinit()) {
DEBUG(0, ("invalidating the cache failed; revalidate the cache\n"));
if (!winbindd_cache_validate_and_initialize()) {
exit(1);
}
}
}
static void winbindd_sig_hup_handler(struct tevent_context *ev,
struct tevent_signal *se,
int signum,
int count,
void *siginfo,
void *private_data)
{
const char *file = (const char *)private_data;
DEBUG(1,("Reloading services after SIGHUP\n"));
flush_caches_noinit();
winbindd_reload_services_file(file);
}
bool winbindd_setup_sig_hup_handler(const char *lfile)
{
struct tevent_signal *se;
char *file = NULL;
if (lfile) {
file = talloc_strdup(global_event_context(),
lfile);
if (!file) {
return false;
}
}
se = tevent_add_signal(global_event_context(),
global_event_context(),
SIGHUP, 0,
winbindd_sig_hup_handler,
file);
if (!se) {
return false;
}
return true;
}