From 14132e89b4b9ac6712fe6f49945da3f4d987cc14 Mon Sep 17 00:00:00 2001 From: Ralph Boehme Date: Sun, 2 Dec 2018 09:22:56 +0100 Subject: [PATCH] docs-xml: add "smbd max async dosmode" The parameter is added to the lists of ignored-paremteres in the samba.docs tests, as the given default "aio max threads * 2" works only as manpage string. "aio max threads" can only be calculated at run time and requires a handle to a pthreadpool_tevent which loadparm will never have. Because of that lp_smbd_max_async_dosmode() will always return 0 as default and it's up to the caller to calculate "aio max threads * 2" if lp_smbd_max_async_dosmode() returns 0. Cf the next commit. Signed-off-by: Ralph Boehme Reviewed-by: Jeremy Allison --- docs-xml/smbdotconf/misc/smbdmaxasyncdosmode.xml | 12 ++++++++++++ python/samba/tests/docs.py | 2 ++ 2 files changed, 14 insertions(+) create mode 100644 docs-xml/smbdotconf/misc/smbdmaxasyncdosmode.xml diff --git a/docs-xml/smbdotconf/misc/smbdmaxasyncdosmode.xml b/docs-xml/smbdotconf/misc/smbdmaxasyncdosmode.xml new file mode 100644 index 00000000000..b375298be31 --- /dev/null +++ b/docs-xml/smbdotconf/misc/smbdmaxasyncdosmode.xml @@ -0,0 +1,12 @@ + + + + This parameter controls how many async operations to fetch the DOS + attributes the fileserver will queue when doing directory listings. + + +aio max threads * 2 + diff --git a/python/samba/tests/docs.py b/python/samba/tests/docs.py index b64f9726367..b6c15b7d8de 100644 --- a/python/samba/tests/docs.py +++ b/python/samba/tests/docs.py @@ -125,6 +125,7 @@ class SmbDotConfTests(TestCase): 'include system krb5 conf', 'rpc server dynamic port range', 'mit kdc command', + 'smbd max async dosmode', ]) def setUp(self): @@ -247,6 +248,7 @@ class SmbDotConfTests(TestCase): exceptions = set([ 'printing', 'rpc server dynamic port range', + 'smbd max async dosmode', ]) if param in exceptions: