sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
Code

s3-lsa: Fix Bug #6263. Unexpected LookupSids reply crashes XP pre-SP3.

Browse Source 
LookupSids needs to bounce back string sids in case of NT_STATUS_NONE_MAPPED.

Guenther
(cherry picked from commit 1c9266c8ca)
This commit is contained in:
Günther Deschner 2009-04-16 01:42:35 +02:00
parent d9804ae3cc
commit 14304fc5e5
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
source3/rpc_server/srv_lsa_nt.c
View File

@ -827,7 +827,15 @@ NTSTATUS _lsa_LookupSids(pipes_struct *p,
&names,
&mapped_count);
if (NT_STATUS_IS_ERR(status)) {
/* Only return here when there is a real error.
NT_STATUS_NONE_MAPPED is a special case as it indicates that none of
the requested sids could be resolved. Older versions of XP (pre SP3)
rely that we return with the string representations of those SIDs in
that case. If we don't, XP crashes - Guenther
*/
if (NT_STATUS_IS_ERR(status) &&
!NT_STATUS_EQUAL(status, NT_STATUS_NONE_MAPPED)) {
return status;
}