1
0
mirror of https://github.com/samba-team/samba.git synced 2025-03-20 22:50:26 +03:00

netcmd: Fix kerberos option for domain backups

The previous fix still didn't work if you specified --kerberos=yes (in
which case the creds still doesn't have a password).

credopts.get_credentials(lp) should be enough to ensure a user/password
is set (it's all that the other commands seem to do).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13566

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
(cherry picked from commit 8fb706c34682bf6dc6033963518c7eccffc3944f)
This commit is contained in:
Tim Beale 2018-08-09 15:34:51 +12:00 committed by Karolin Seeger
parent 69583d1d32
commit 15e1a41130

View File

@ -152,10 +152,6 @@ def check_targetdir(logger, targetdir):
def check_online_backup_args(logger, creds, server, targetdir):
# Make sure we have all the required args.
u_p = {'user': creds.get_username(),
'pass': creds.get_password()}
if None in u_p.values():
raise CommandError("Creds required.")
if server is None:
raise CommandError('Server required')