1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-24 21:34:56 +03:00

dsdb: Fix CID 1435968 Dereference before null check

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Jun 13 13:40:56 CEST 2018 on sn-devel-144
This commit is contained in:
Volker Lendecke 2018-06-12 21:31:15 +02:00 committed by Andrew Bartlett
parent 11cac8a21c
commit 15fa8f9f24

View File

@ -547,7 +547,6 @@ static int partition_copy_all_callback_handler(
struct ldb_reply *ares)
{
struct partition_copy_context *ac = NULL;
int error = ares->error;
ac = talloc_get_type(
req->context,
@ -574,8 +573,8 @@ static int partition_copy_all_callback_handler(
ac->request,
ares->referral);
case LDB_REPLY_DONE:
error = ares->error;
case LDB_REPLY_DONE: {
int error = ares->error;
if (error == LDB_SUCCESS) {
error = partition_copy_all_callback_action(
ac->module,
@ -588,6 +587,7 @@ static int partition_copy_all_callback_handler(
ares->controls,
ares->response,
error);
}
default:
/* Can't happen */