sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-08 21:18:16 +03:00
Code

libcli/auth: let netlogon_creds_cli_store_internal() use talloc_stackframe()

Browse Source 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15425

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
This commit is contained in:
Stefan Metzmacher 2024-10-10 13:24:37 +02:00 committed by Douglas Bagnall
parent 8b972fea09
commit 17394ed7bb
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
libcli/auth/netlogon_creds_cli.c
View File

@ -747,6 +747,7 @@ static NTSTATUS netlogon_creds_cli_store_internal(
struct netlogon_creds_cli_context *context, struct netlogon_creds_cli_context *context,
struct netlogon_creds_CredentialState *creds) struct netlogon_creds_CredentialState *creds)
{ {
TALLOC_CTX *frame = talloc_stackframe();
NTSTATUS status; NTSTATUS status;
enum ndr_err_code ndr_err; enum ndr_err_code ndr_err;
DATA_BLOB blob; DATA_BLOB blob;
@ -756,10 +757,11 @@ static NTSTATUS netlogon_creds_cli_store_internal(
NDR_PRINT_DEBUG(netlogon_creds_CredentialState, creds); NDR_PRINT_DEBUG(netlogon_creds_CredentialState, creds);
} }
ndr_err = ndr_push_struct_blob(&blob, creds, creds, ndr_err = ndr_push_struct_blob(&blob, frame, creds,
(ndr_push_flags_fn_t)ndr_push_netlogon_creds_CredentialState); (ndr_push_flags_fn_t)ndr_push_netlogon_creds_CredentialState);
if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) { if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
status = ndr_map_error2ntstatus(ndr_err); status = ndr_map_error2ntstatus(ndr_err);
TALLOC_FREE(frame);
return status; return status;
} }
@ -769,11 +771,12 @@ static NTSTATUS netlogon_creds_cli_store_internal(
status = dbwrap_store(context->db.ctx, status = dbwrap_store(context->db.ctx,
context->db.key_data, context->db.key_data,
data, TDB_REPLACE); data, TDB_REPLACE);
TALLOC_FREE(data.dptr);
if (!NT_STATUS_IS_OK(status)) { if (!NT_STATUS_IS_OK(status)) {
TALLOC_FREE(frame);
return status; return status;
} }
TALLOC_FREE(frame);
return NT_STATUS_OK; return NT_STATUS_OK;
} }