sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-04 16:58:42 +03:00
Code

s3-winbindd: add comments about dump_core_setup

Browse Source 
This patch is related to change 0ea7152ff479e32e25817e4ddb1c2a1569bad81d
Comments are added to explain why we call dump_core_setup 3 times.

Autobuild-User(master): Matthieu Patou <mat@samba.org>
Autobuild-Date(master): Mon Jun 11 21:21:11 CEST 2012 on sn-devel-104
This commit is contained in:
Matthieu Patou 2012-06-11 10:23:51 -07:00 committed by Matthieu Patou
parent 4c33f28dc2
commit 17d5fbde43
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
source3/winbindd/winbindd.c
View File

@ -1350,6 +1350,13 @@ int main(int argc, char **argv, char **envp)
} }
} }
/* We call dump_core_setup one more time because the command line can
* set the log file or the log-basename and this will influence where
* cores are stored. Without this call get_dyn_LOGFILEBASE will be
* the default value derived from build's prefix. For EOM this value
* is often not related to the path where winbindd is actually run
* in production.
*/
dump_core_setup("winbindd", lp_logfile()); dump_core_setup("winbindd", lp_logfile());
if (is_daemon && interactive) { if (is_daemon && interactive) {
d_fprintf(stderr,"\nERROR: " d_fprintf(stderr,"\nERROR: "
@ -1390,6 +1397,10 @@ int main(int argc, char **argv, char **envp)
DEBUG(0, ("error opening config file '%s'\n", get_dyn_CONFIGFILE())); DEBUG(0, ("error opening config file '%s'\n", get_dyn_CONFIGFILE()));
exit(1); exit(1);
} }
/* After parsing the configuration file we setup the core path one more time
* as the log file might have been set in the configuration and cores's
* path is by default basename(lp_logfile()).
*/
dump_core_setup("winbindd", lp_logfile()); dump_core_setup("winbindd", lp_logfile());
/* Initialise messaging system */ /* Initialise messaging system */