sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-08-02 00:22:11 +03:00
Code Activity

pyldb: remove ldb.open, which was never survivable

Browse Source 
There was no way to call ldb.open without evoking signal 11, so it is
unlikely anyone was using it.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
This commit is contained in:
Douglas Bagnall
2019-07-04 16:29:56 +12:00
committed by Douglas Bagnall
parent 3af57daa84
commit 192386ede6
3 changed files with 0 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/ldb/pyldb.c
View File

@ -4267,10 +4267,6 @@ static PyMethodDef py_ldb_global_methods[] = {
{ "valid_attr_name", py_valid_attr_name, METH_VARARGS,
"S.valid_attr_name(name) -> bool\n\nn"
"Check whether the supplied name is a valid attribute name." },
{ "open", PY_DISCARD_FUNC_SIG(PyCFunction,py_ldb_new),
METH_VARARGS|METH_KEYWORDS,
"S.open() -> Ldb\n\n"
"Open a new LDB context." },
{ "binary_encode", py_binary_encode, METH_VARARGS,
"S.binary_encode(string) -> string\n\n"
"Perform a RFC2254 binary encoding on a string" },

8
python/samba/tests/segfault.py
View File

@ -138,11 +138,3 @@ class SegfaultTests(samba.tests.TestCase):
@segfault_detector
def test_ldb_register_module(self):
ldb.register_module('')
@segfault_detector
def test_ldb_open_0(self):
ldb.open()
@segfault_detector
def test_ldb_open_1(self):
ldb.open('')

2
selftest/knownfail.d/python-segfaults
View File

@ -1,7 +1,5 @@
samba.tests.segfault.samba.tests.segfault.SegfaultTests.test_encrypt_netr_crypt_password
samba.tests.segfault.samba.tests.segfault.SegfaultTests.test_hive_open_ldb
samba.tests.segfault.samba.tests.segfault.SegfaultTests.test_ldb_open_0
samba.tests.segfault.samba.tests.segfault.SegfaultTests.test_ldb_open_1
samba.tests.segfault.samba.tests.segfault.SegfaultTests.test_ldb_register_module
samba.tests.segfault.samba.tests.segfault.SegfaultTests.test_net_replicate_chunk_1
samba.tests.segfault.samba.tests.segfault.SegfaultTests.test_net_replicate_init__3