sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-08 21:18:16 +03:00
Code

nsswitch pam_winbind: Fix Asan use after free

Browse Source 
Fix use after free condition detected by Address Sanitizer triggered by
wbcLogonUserInfoDestructor, wbcFreeMemory has code to detect and prevent a
double free.  This patch prevents the Address Sanitizer error, allowing
tests to be run with Address Sanitizer enabled.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13927

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon May  6 08:55:22 UTC 2019 on sn-devel-184
This commit is contained in:
Gary Lockyer 2019-04-18 09:29:28 +12:00 committed by Andrew Bartlett
parent e129d4ea3e
commit 193b44466b
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
nsswitch/pam_winbind.c
View File

@ -1931,6 +1931,11 @@ static int winbind_auth_request(struct pwb_context *ctx,
wbcFreeMemory(logon.blobs);
if (info && info->blobs && !p_info) {
wbcFreeMemory(info->blobs);
/*
* We set blobs to NULL to prevent a use after free in the
* in the wbcLogonUserInfoDestructor
*/
info->blobs = NULL;
}
if (error && !p_error) {
wbcFreeMemory(error);