sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-20 14:03:59 +03:00
Code

libndr: Add overflow check to ndr_push_subcontext_end()

Browse Source 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Mon Nov 25 15:36:07 UTC 2024 on atb-devel-224
This commit is contained in:
Volker Lendecke 2024-11-25 15:08:26 +01:00
parent 95e1998a4a
commit 19cc587031
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
librpc/ndr/ndr.c
View File

@ -936,6 +936,14 @@ _PUBLIC_ enum ndr_err_code ndr_push_subcontext_end(struct ndr_push *ndr,
break; break;
case 2: case 2:
if (subndr->offset > UINT16_MAX) {
return ndr_push_error(
ndr,
NDR_ERR_BUFSIZE,
"Subcontext (PUSH) too large: %" PRIu32
" does not fit into 16 bits",
subndr->offset);
}
NDR_CHECK(ndr_push_uint16(ndr, NDR_SCALARS, subndr->offset)); NDR_CHECK(ndr_push_uint16(ndr, NDR_SCALARS, subndr->offset));
break; break;