sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

CVE-2022-0336: s4/dsdb/samldb: Don't return early when an SPN is re-added to an object

Browse Source 
If an added SPN already exists on an object, we still want to check the
rest of the element values for conflicts.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14950

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
This commit is contained in:
Joseph Sutton 2022-01-18 12:02:45 +13:00 committed by Stefan Metzmacher
parent c58ede44f3
commit 1a5dc817c0
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
selftest/knownfail.d/ldap_spn
View File

@ -1,2 +1 @@
samba.tests.ldap_spn.+LdapSpnTest.test_spn_dodgy_spns samba.tests.ldap_spn.+LdapSpnTest.test_spn_dodgy_spns
samba.tests.ldap_spn.+LdapSpnSambaOnlyTest.test_spn_add_a_conflict_along_with_a_re_added_SPN

3
source4/dsdb/samdb/ldb_modules/samldb.c
View File

@ -4006,8 +4006,7 @@ static int samldb_spn_uniqueness_check(struct samldb_ctx *ac,
ac->msg->dn); ac->msg->dn);
if (ret == LDB_ERR_COMPARE_TRUE) { if (ret == LDB_ERR_COMPARE_TRUE) {
DBG_INFO("SPN %s re-added to the same object\n", spn); DBG_INFO("SPN %s re-added to the same object\n", spn);
talloc_free(tmp_ctx); continue;
return LDB_SUCCESS;
} }
if (ret != LDB_SUCCESS) { if (ret != LDB_SUCCESS) {
DBG_ERR("SPN %s failed direct uniqueness check\n", spn); DBG_ERR("SPN %s failed direct uniqueness check\n", spn);