sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-25 23:21:54 +03:00
Code

s3:registry: refactor adding of builtin reg values out

Browse Source 
into regdb_ctr_add_value(). For readability.

Michael
This commit is contained in:
Michael Adam 2009-07-08 13:58:52 +02:00
parent cf4f808b8b
commit 1c65c98f33
1 changed files with 27 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
source3/registry/reg_backend_db.c
View File

@ -240,6 +240,31 @@ WERROR init_registry_key(const char *add_path)
Open the registry data in the tdb Open the registry data in the tdb
***********************************************************************/ ***********************************************************************/
static void regdb_ctr_add_value(struct regval_ctr *ctr,
struct builtin_regkey_value *value)
{
UNISTR2 data;
switch(value->type) {
case REG_DWORD:
regval_ctr_addvalue(ctr, value->valuename, REG_DWORD,
(char*)&value->data.dw_value,
sizeof(uint32));
break;
case REG_SZ:
init_unistr2(&data, value->data.string, UNI_STR_TERMINATE);
regval_ctr_addvalue(ctr, value->valuename, REG_SZ,
(char*)data.buffer,
data.uni_str_len*sizeof(uint16));
break;
default:
DEBUG(0, ("regdb_ctr_add_value: invalid value type in "
"registry values [%d]\n", value->type));
}
}
static NTSTATUS init_registry_data_action(struct db_context *db, static NTSTATUS init_registry_data_action(struct db_context *db,
void *private_data) void *private_data)
{ {
@ -247,7 +272,6 @@ static NTSTATUS init_registry_data_action(struct db_context *db,
TALLOC_CTX *frame = talloc_stackframe(); TALLOC_CTX *frame = talloc_stackframe();
struct regval_ctr *values; struct regval_ctr *values;
int i; int i;
UNISTR2 data;
/* loop over all of the predefined paths and add each component */ /* loop over all of the predefined paths and add each component */
@ -281,32 +305,8 @@ static NTSTATUS init_registry_data_action(struct db_context *db,
if (!regval_ctr_key_exists(values, if (!regval_ctr_key_exists(values,
builtin_registry_values[i].valuename)) builtin_registry_values[i].valuename))
{ {
switch(builtin_registry_values[i].type) { regdb_ctr_add_value(values,
case REG_DWORD: &builtin_registry_values[i]);
regval_ctr_addvalue(values,
builtin_registry_values[i].valuename,
REG_DWORD,
(char*)&builtin_registry_values[i].data.dw_value,
sizeof(uint32));
break;
case REG_SZ:
init_unistr2(&data,
builtin_registry_values[i].data.string,
UNI_STR_TERMINATE);
regval_ctr_addvalue(values,
builtin_registry_values[i].valuename,
REG_SZ,
(char*)data.buffer,
data.uni_str_len*sizeof(uint16));
break;
default:
DEBUG(0, ("init_registry_data: invalid value "
"type in builtin_registry_values "
"[%d]\n",
builtin_registry_values[i].type));
}
regdb_store_values_internal(db, regdb_store_values_internal(db,
builtin_registry_values[i].path, builtin_registry_values[i].path,
values); values);