sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-25 06:04:04 +03:00
Code

s4:winbind/wb_cmd_setpwent.c - fix a possible crash condition in the "winbind struct test"

Browse Source 
Use a "talloc_strdup" for duplicating usernames.
This commit is contained in:
Matthias Dieter Wallnöfer 2010-07-05 11:44:48 +02:00
parent afcf18f3c9
commit 1d166fd3cf
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
source4/winbind/wb_cmd_setpwent.c
View File

@ -112,28 +112,30 @@ static void cmd_setpwent_recv_user_list(struct composite_context *ctx)
if (composite_nomem(user_list, state->ctx)) return;
state->ctx->status = libnet_UserList_recv(ctx, state->result,
user_list);
user_list);
if (NT_STATUS_IS_OK(state->ctx->status) ||
NT_STATUS_EQUAL(state->ctx->status, STATUS_MORE_ENTRIES)) {
if( state->result->page_index == -1) { /* First run*/
if (state->result->page_index == -1) { /* First run*/
state->result->user_list = user_list;
state->result->page_index = 0;
state->result->libnet_ctx = state->libnet_ctx;
} else {
int i;
int i, cnt = state->result->user_list->out.count
+ user_list->out.count;
struct userlist *tmp;
tmp = state->result->user_list->out.users;
state->result->user_list->out.users = talloc_realloc(state->result,tmp,struct userlist,
state->result->user_list->out.count+user_list->out.count);
state->result->user_list->out.users = talloc_realloc(state->result,
tmp, struct userlist,
cnt);
tmp = state->result->user_list->out.users;
for(i=0;i<user_list->out.count;i++ ) {
tmp[i+state->result->user_list->out.count].username = talloc_steal(state->result,user_list->out.users[i].username);
tmp[state->result->user_list->out.count + i].username
= talloc_strdup(state->result, user_list->out.users[i].username);
}
state->result->user_list->out.count += user_list->out.count;
state->result->user_list->out.count = cnt;
talloc_free(user_list);
}
if (NT_STATUS_IS_OK(state->ctx->status) ) {
composite_done(state->ctx);
} else {