sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-08 05:57:51 +03:00
Code

smbd: README.Coding fixes

Browse Source 
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
Ralph Boehme 2019-07-13 16:10:53 +02:00 committed by Jeremy Allison
parent 1f4ec34447
commit 1d6fe10ec6
1 changed files with 20 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
source3/smbd/uid.c
View File

@ -466,9 +466,9 @@ bool change_to_user_and_service(connection_struct *conn, uint64_t vuid)
struct user_struct *vuser;
int snum = SNUM(conn);
if (!conn) {
DEBUG(2,("Connection not open\n"));
return(False);
if (conn == NULL) {
DBG_WARNING("Connection not open\n");
return false;
}
vuser = get_valid_user_struct(conn->sconn, vuid);
@ -670,18 +670,23 @@ void smbd_unbecome_root(void)
bool become_user(connection_struct *conn, uint64_t vuid)
{
if (!push_sec_ctx())
return False;
bool ok;
ok = push_sec_ctx();
if (!ok) {
return false;
}
push_conn_ctx();
if (!change_to_user_and_service(conn, vuid)) {
ok = change_to_user_and_service(conn, vuid);
if (!ok) {
pop_sec_ctx();
pop_conn_ctx();
return False;
return false;
}
return True;
return true;
}
bool become_user_by_fsp(struct files_struct *fsp)
@ -692,12 +697,17 @@ bool become_user_by_fsp(struct files_struct *fsp)
bool become_user_by_session(connection_struct *conn,
const struct auth_session_info *session_info)
{
if (!push_sec_ctx())
bool ok;
ok = push_sec_ctx();
if (!ok) {
return false;
}
push_conn_ctx();
if (!change_to_user_by_session(conn, session_info)) {
ok = change_to_user_by_session(conn, session_info);
if (!ok) {
pop_sec_ctx();
pop_conn_ctx();
return false;