sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-11 05:18:09 +03:00
Code

rpc_server: Simplify dcesrv_handle_lookup()

Browse Source 
Reduce indentation with a "break;" from the loop, best reviewed with
git show -b

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
Volker Lendecke 2021-09-20 16:42:08 +02:00 committed by Jeremy Allison
parent acaa89aac9
commit 1e30fad7ee
1 changed files with 27 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
librpc/rpc/dcesrv_handles.c
View File

@ -116,28 +116,36 @@ struct dcesrv_handle *dcesrv_handle_lookup(struct dcesrv_call_state *call,
for (h=context->conn->assoc_group->handles; h; h=h->next) { for (h=context->conn->assoc_group->handles; h; h=h->next) {
if (h->wire_handle.handle_type == p->handle_type && if (h->wire_handle.handle_type == p->handle_type &&
GUID_equal(&p->uuid, &h->wire_handle.uuid)) { GUID_equal(&p->uuid, &h->wire_handle.uuid)) {
if (!dom_sid_equal(&h->sid, sid)) { break;
struct dom_sid_buf buf1, buf2;
DBG_ERR("Attempt to use invalid sid %s - %s\n",
dom_sid_str_buf(&h->sid, &buf1),
dom_sid_str_buf(sid, &buf2));
return NULL;
}
if (call->auth_state->auth_level < h->min_auth_level) {
DEBUG(0,(__location__ ": Attempt to use invalid auth_level %u < %u\n",
call->auth_state->auth_level,
h->min_auth_level));
return NULL;
}
if (h->iface != context->iface) {
DEBUG(0,(__location__ ": Attempt to use invalid iface\n"));
return NULL;
}
return h;
} }
} }
return NULL; if (h == NULL) {
/* not found */
return NULL;
}
if (!dom_sid_equal(&h->sid, sid)) {
struct dom_sid_buf buf1, buf2;
DBG_ERR("Attempt to use invalid sid %s - %s\n",
dom_sid_str_buf(&h->sid, &buf1),
dom_sid_str_buf(sid, &buf2));
return NULL;
}
if (call->auth_state->auth_level < h->min_auth_level) {
DBG_ERR("Attempt to use invalid auth_level %u < %u\n",
call->auth_state->auth_level,
h->min_auth_level);
return NULL;
}
if (h->iface != context->iface) {
DBG_ERR("Attempt to use invalid iface\n");
return NULL;
}
return h;
} }
struct dcesrv_iface_state { struct dcesrv_iface_state {